106 Commits

Author	SHA1	Message	Date
Bartłomiej Dach	58ecee543a	Trim redundant default argument value	2021-08-17 23:00:10 +02:00
Dean Herbert	d66f7cb6b5	Fix tests by allowing retrieval with files where required	2021-08-17 19:21:22 +09:00
Dean Herbert	4bf22db4ff	Attempt to reduce skin lookup overhead where file access is not required	2021-08-17 00:23:30 +09:00
Dan Balasescu	92fcf90768	Merge branch 'master' into import-early-checksum-abort	2021-06-28 19:29:08 +09:00
Dean Herbert	44f875b802	Bypass optimised existing check in SkinManager (due to custom hashing function)	2021-06-27 16:35:13 +09:00
Dean Herbert	d1f852d102	Make Populate abstract to avoid unnecessary base call async complexity	2021-06-27 14:29:02 +09:00
Salman Ahmed	71e2815e7e	Update and improve code documentation ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2021-06-22 12:05:17 +03:00
Salman Ahmed	c1284940e1	Fix potentially providing the same skin instance twice in AllSources	2021-06-22 10:49:37 +03:00
Salman Ahmed	d0cdc07b11	Reuse AllSources when looking up on FindProvider	2021-06-22 10:49:21 +03:00
Dean Herbert	0ad189e357	Expose skin sources via ISkinSource and revert to consuming based on hierarchy	2021-06-22 16:19:55 +09:00
Salman Ahmed	9e5bb146d3	Add xmldoc to SkinManager ... The `<summary>` part comes from `BeatmapManager`, which I believe works correctly here as well, as this does handle the "storage and retrieval" of skins.	2021-06-22 03:07:31 +03:00
Salman Ahmed	2e01e61177	Move TODO comment to correct location	2021-06-11 11:46:30 +03:00
Dean Herbert	debd359d2e	Update xmldoc	2021-06-11 14:50:21 +09:00
Dean Herbert	b9050f91a4	Expose as Skins and consume SkinInfo from instances	2021-06-11 14:49:35 +09:00
Salman Ahmed	c3a2f2c2a4	Expose default SkinManager providers for use in RulesetSkinProvidingContainer	2021-06-10 13:07:32 +03:00
Dean Herbert	0cf7c56e7e	Add fallback lookup support for DefaultSkin	2021-06-09 18:51:42 +09:00
Dean Herbert	e0f568aa8f	Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup	2021-06-08 15:19:52 +09:00
Dean Herbert	27e3de3ea3	Add TODO about beatmap skin fallback support	2021-06-08 12:12:14 +09:00
Dean Herbert	e7e9197f03	Fix FindProvider not correctly checking legacy default in SkinManager	2021-06-08 00:42:50 +09:00
Dean Herbert	d26c9a66c2	Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup	2021-06-07 12:01:19 +09:00
Dean Herbert	b87a5956dd	Add fallback logic to SkinManager	2021-06-06 12:17:55 +09:00
Dean Herbert	39f99bf785	Move FindProvider to ISkinSource	2021-06-06 12:17:32 +09:00
Dean Herbert	00b3eea840	Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup	2021-05-31 21:39:04 +09:00
Dean Herbert	3ff9f9c89d	Make FindProvider non-default	2021-05-31 21:29:47 +09:00
Dean Herbert	65709ec7d7	Move leagcy resource store construction local to DefaultLegacySkin	2021-05-31 19:14:49 +09:00
Dean Herbert	b16d10bd95	Provide game-wide resources via IStorageResourceProvider	2021-05-31 18:57:47 +09:00
Dean Herbert	70a844ac10	Remove allowFallback parameters completely	2021-05-27 14:50:42 +09:00
Dean Herbert	4fd89faaa4	Fix default skin not having resources or providing samples	2021-05-27 14:09:01 +09:00
Dean Herbert	0959e7156a	Remove outdated TODO	2021-05-13 17:22:05 +09:00
Dean Herbert	cdcd31b546	Replace ISkinSerialisable with IsEditable property	2021-05-13 17:03:17 +09:00
Dean Herbert	19223ba013	Remove left-over debug logging	2021-05-13 16:42:13 +09:00
Dean Herbert	8b9ac86d4b	Merge branch 'master' into skin-serialisation	2021-05-13 12:35:06 +09:00
Bartłomiej Dach	1b579dd838	Extract invariant instantiation info extension method	2021-05-12 23:23:51 +02:00
Dean Herbert	77e422409c	Add SkinInfo.InstantiationInfo to allow creating different skin types	2021-05-11 23:37:06 +09:00
Dean Herbert	a7e83aacfb	Ensure default skins are copied before modifying	2021-05-11 18:39:15 +09:00
Dean Herbert	a67cead0b3	Add SkinInfo.InstantiationInfo to allow creating different skin types	2021-05-11 18:39:15 +09:00
Dean Herbert	b248b2e5e3	Hook up full save/load flow	2021-05-11 18:39:14 +09:00
Dean Herbert	0324bfa857	Change checks back to Contains	2021-03-25 14:14:38 +09:00
Salman Ahmed	fc5719e445	Fix SkinManager not handling extensions casing comparsion properly	2021-03-24 21:31:53 +03:00
Bartłomiej Dach	a16c0641b2	Revert EF Core to version 2.2 ... This reverts commit f3faad74d5, reversing changes made to 712e7bc7bf. Several issues arose after migrating to 5.0, including, but possibly not limited to, performance regressions in song select, as well as failures when attempting to save beatmaps after metadata changes in the editor.	2021-03-21 11:05:15 +01:00
Dean Herbert	f59327cc3e	Merge branch 'master' into fix-unsafe-skinnable-sample-play	2021-03-19 20:29:44 +09:00
Dean Herbert	9491e6394a	Include the bundled skins when selecting a random skin	2021-03-19 15:46:43 +09:00
Bartłomiej Dach	aec859b4d1	Merge branch 'master' into fix-unsafe-skinnable-sample-play	2021-03-18 19:51:46 +01:00
Dean Herbert	2bdffd1004	Move skin requery logic into extension methods	2021-03-15 13:11:58 +09:00
Roman Kapustin	0a1e325fc7	Extract requerying of navigational properties from DbContext	2021-03-14 19:34:53 +03:00
Roman Kapustin	47b80d2474	Workaround InvalidOperation exceptions	2021-03-11 20:51:54 +03:00
Dean Herbert	b1cd01ceb8	Apply ConfigureAwait changes to game side	2021-03-08 14:36:35 +09:00
Dean Herbert	00574a5288	Use ISample everywhere in Skin GetSample lookup path	2021-02-18 18:32:28 +09:00
smoogipoo	de9d075f94	Initial sample + samplechannel rework	2021-01-19 17:11:40 +09:00
Dean Herbert	10c2745682	Add region specifications around implicit interface implementations	2020-12-22 12:01:09 +09:00