3819a1f03b
Remove exit override behaviour
...
I don't actually know under what scenario this could have been hit, and
actually caused expected behaviour. Consider that in the scenario I
describe in the comment (which I added yesterday), the user is
requesting a pause or exit which would be "cancelled showing the results
instead". But in such a scenario, `PerformExit` would first be run,
which cancels the `resultsDisplayDelegate` in the first place.
The only special case would be pressing the close button on the window
decoration? Which I don't think should be a special case in the first
place, so I'm just going to remove this for the time being to keep
things simple.
2021-06-18 16:12:35 +09:00
7ef8eac773
Remove unnecessary (and no longer correct) exception
2021-06-18 16:08:31 +09:00
2bf855fcca
Move all storyboard outro skip logic out of updateCompletionState
...
This method should only be called to trigger the score completion
portion of player progression. The storyboard skip/end logic is now
handled separately in `progressToResults`.
2021-06-18 15:50:43 +09:00
f282326f9a
Move score preparations back below ShowResults check
2021-06-17 19:04:52 +02:00
3a1444e75d
Fix malformed xmldoc tag
...
Oops. Made a typo in the PR suggestion.
2021-06-17 19:02:56 +02:00
9facfe8964
Apply suggestions from code review
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com >
2021-06-18 01:07:54 +09:00
e0a3696145
Merge branch 'master' into player-completion-refactoring
2021-06-17 23:51:42 +09:00
aae2923e14
Merge branch 'master' into player-pause-exit-results-flow-refactoring
2021-06-17 16:05:09 +02:00
10b0d066be
Reword comments slightly
2021-06-17 16:04:58 +02:00
561dbea9e1
Use xmldoc-specific syntax for nicer formatting
2021-06-17 15:26:50 +02:00
d03c6da60c
Refactor and redocument updateCompletionState() and surrounding methods
2021-06-17 19:13:53 +09:00
246ab41cc6
Remove special casing for user exit during storyboard outro
2021-06-17 18:11:15 +09:00
7cbebe6d11
Rewrite xmldoc and inline comments for PerformExit
2021-06-17 18:10:59 +09:00
808b2baa41
Consume new behaviour to fix UserTile discrepancy
...
Closes https://github.com/ppy/osu/issues/13522 .
2021-06-17 16:31:12 +09:00
4b45d8318e
Merge branch 'master' into transformers-per-skin
2021-06-16 16:37:28 +09:00
83402a70db
Fix potential null ref when no beatmap is selected
2021-06-14 15:06:24 +09:00
f8b09b7c81
Avoid refresh if score is not related to current display
2021-06-14 14:28:14 +09:00
fc442713bb
Debounce schedule at base class
2021-06-14 14:26:40 +09:00
8dd48d48f6
Add support for song select leaderboard to handle newly imported scores
2021-06-14 14:20:23 +09:00
9f163f7f20
Use switch statement to be more explicit about state
2021-06-11 19:23:25 +09:00
0a8daab4f7
Pause master clock when too far ahead
2021-06-11 19:15:53 +09:00
59eda70c12
Seek to the least most-recent frame instead
2021-06-11 18:40:56 +09:00
263b8ff097
Wait for full player load
2021-06-11 18:14:37 +09:00
a99cb79738
Seek master clock on multi-spectator start
2021-06-11 16:25:45 +09:00
75d825c85c
Dont control master clock from sync manager
2021-06-11 16:24:52 +09:00
1c67ef7c91
Make catchup clock support seeking
2021-06-11 16:23:59 +09:00
04413f1634
Merge pull request #13444 from peppy/editor-timeline-taiko-hit-colouring
...
Show osu!taiko centre/rim colouring in editor timeline
2021-06-11 15:10:24 +09:00
97375d9625
Merge pull request #13438 from bdach/more-metadata-fields
...
Add remaining metadata fields to editor setup screen
2021-06-11 14:17:34 +09:00
bc3b7233ab
Show osu!taiko centre/rim colouring in editor timeline
...
Closes #13443 .
2021-06-11 14:17:30 +09:00
7fd26ff3b0
Merge branch 'master' into more-metadata-fields
2021-06-11 06:35:51 +02:00
38bf04d7ff
Give more space for time values to allow for negative offsets
2021-06-11 13:25:09 +09:00
417aaacc53
Add test coverage for romanised data transfer
2021-06-10 22:18:39 +02:00
e41a5a0fcd
Add romanised author & title fields
2021-06-10 22:17:45 +02:00
f65f074131
Add star keyword to FilterQueryParser criteria
2021-06-11 02:46:29 +09:00
ef2c4fd0d8
Make RulesetSkinProvidingContainer able to be overriden for testing purposes
2021-06-10 16:36:46 +03:00
e18f4cd4ba
Combine methods
2021-06-10 22:01:39 +09:00
5073ede115
Clear existing frames when starting gameplay
2021-06-10 21:38:46 +09:00
9eecb23fef
Only seek to the end on first frame arrival
2021-06-10 21:35:52 +09:00
252fe0a6cc
Add source and tags text boxes to metadata section
2021-06-10 14:13:59 +02:00
5a2e710095
Split common method for metadata textbox creation
2021-06-10 13:55:34 +02:00
4a4a561ca4
Merge pull request #13330 from nekodex/results-screen-sfx
...
Add sound effects to the results screen
2021-06-10 18:27:17 +09:00
dde84e5cbd
Merge branch 'master' into transformers-per-skin
2021-06-10 11:58:52 +03:00
0667354fbd
Remove unused resolved skin
2021-06-10 17:30:04 +09:00
4f8000a574
Combine cases which return the same value
2021-06-10 17:29:36 +09:00
5e80f454ce
Merge branch 'master' into results-screen-sfx
2021-06-10 17:25:35 +09:00
a44fd887ee
Merge branch 'master' into no-unranked-display
2021-06-10 17:09:46 +09:00
cc38556f61
Fix background being dimmed forever after toggling statistics in results screen
2021-06-09 23:26:57 -07:00
9a3ca09501
Merge pull request #13384 from bdach/fixed-label-width
...
Align label widths of editor setup screen controls
2021-06-10 14:55:49 +09:00
209d217024
Remove unused using statement
2021-06-10 12:37:56 +09:00
3d508f9266
Merge branch 'master' into results-screen-sfx
2021-06-10 11:28:35 +09:00
