Commit Graph

287 Commits

Author SHA1 Message Date
113bbe8c4d Merge pull request #8488 from peppy/fix-autoplay-results-display
Fix auto mod results screen not displaying correctly
2020-03-30 11:01:16 +09:00
d99b445720 Move non-headless tests to correct namespace 2020-03-30 10:00:28 +09:00
98a700ef3a Attempt to fix tests by skipping one break at a time 2020-03-30 00:58:06 +09:00
653480b2f8 Add regression test 2020-03-29 23:29:46 +09:00
a317ef65b8 Remove default for argument 2020-03-28 12:18:28 +09:00
46af4bce32 Cover regression in autoplay test 2020-03-27 19:42:45 +01:00
6ecfeb8cc3 Merge pull request #8455 from Game4all/handle-novideo-beatmaps
Fix NullReferenceException when starting the no-video version of a beatmap with video
2020-03-27 21:12:40 +09:00
6788b7f9cd Add test for loading storyboards with missing video file. 2020-03-27 12:07:47 +01:00
07462120e4 Split break tracking into its own component 2020-03-26 15:30:23 +09:00
0b728f483f Rename base test class to help avoid incorrect reference 2020-03-23 10:01:33 +09:00
1c4296f5e7 Implement the new results screen 2020-03-17 17:43:16 +09:00
c2fbc85e77 Split out test scene for StarCounter 2020-03-09 01:26:34 +09:00
979988235d Increase flexibility of StarCounter component 2020-03-08 15:56:22 +09:00
0ccf691c97 Remove unnecessary interpolation 2020-03-06 18:00:07 +09:00
3b0e3cd71a Remove using statements 2020-03-06 17:55:57 +09:00
40074f10db Remove unnecessary override 2020-03-06 17:55:05 +09:00
90dbb90470 Merge branch 'master' into disable-keycounter-breaks 2020-03-06 17:53:10 +09:00
5200633f9f Centralise TestPlayer implementations as much as possible 2020-03-05 11:25:07 +09:00
3d344a076d Add test for disabled keycounter, don't discard change event values 2020-03-03 06:17:25 +05:30
1ce972dd5b Remove unused variable 2020-02-29 21:53:49 +05:30
bca58ddb42 Make KeyCounter stop counting during breaks 2020-02-29 21:18:43 +05:30
29e2e17144 Merge branch 'master' into fix-dho-lifetimes-via-judgements 2020-02-25 19:07:57 +09:00
a047456354 Revert changes to make HitObject abstract 2020-02-25 19:07:15 +09:00
ffc7eaa3f2 Fix hitobjects with unknown lifetimes by enforcing non-null judgement
We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
CreateJudgement() must be implemented and return a non-null judgement.

This fixes BananaShower and JuiceStreams in osu!catch.

This also makes HitObject abstract and cleans up convert HitObject implementations.
2020-02-23 13:49:06 +09:00
e8ebb31517 Expire old judgement lines if too many exist 2020-02-23 03:53:51 +09:00
05c48cd929 Fix volume mute tests regressing 2020-02-14 19:27:32 +09:00
47325601f4 Add failing test 2020-02-14 19:16:08 +09:00
12469469ad Add reproduction test steps for lifetime bug
Modify TestSceneScrollingHitObjects to contain a test case that serves
as a reproduction for a visual bug in which using the overlapping scroll
algorithm results in an incorrect origin adjustment for lifetime.
2020-02-06 23:12:22 +01:00
ecde641729 Randomise colours in scrolling test scene
Switch to using randomised colours in TestSceneScrollingHitObjects to
better distinguish individual hit objects.
2020-02-06 22:47:59 +01:00
0ccbffde8d Use ChildrenOfType instead 2020-02-03 23:43:04 +03:00
26a9d60437 Avoid exposing whenever possible 2020-02-03 23:17:10 +03:00
4cd4055e7c Rename to AlwaysVisible and add XMLDoc 2020-02-03 20:00:43 +03:00
51ed289c59 Revert namings and behaviour changes 2020-02-03 19:59:58 +03:00
351cb8ac1a Rename Visible to HasReplayLoaded and change default value
Doesn't make sense to be true by default
2020-02-03 15:47:52 +03:00
443063263e Merge remote-tracking branch 'upstream/master' into fix-key-counter-visible-on-reshowing-hud 2020-02-03 15:18:25 +03:00
0f449d1b99 Set config value instead 2020-02-02 18:46:59 +03:00
28e340c486 Inherit Container and fade the key flow instead of individual children 2020-02-02 18:46:27 +03:00
6103674b54 Add tests for changing HUD visibility on hidden key counter configuration 2020-02-02 14:50:05 +03:00
ed368e44ea Merge branch 'master' into safe-screen-lease 2020-02-01 02:11:18 +09:00
19f516e710 Ensure OsuScreen level leases are taken out synchronously 2020-01-31 19:10:44 +09:00
5f48affcba Centralise screen exit logic to ScreenTestScene 2020-01-31 14:19:29 +09:00
2187dbd0c2 Rename steps in test for clarity 2020-01-24 14:37:37 +09:00
997b49f6dc Change display to always show progress bar, only hiding seeking handle instead 2020-01-24 14:21:22 +09:00
da65fff48e Merge remote-tracking branch 'upstream/master' into collapse-graph-option 2020-01-24 13:55:42 +09:00
c390348eab Merge remote-tracking branch 'upstream/master' into colour-score-meter 2020-01-24 11:45:33 +09:00
03c778df75 Merge branch 'master' into update-framework 2020-01-09 19:02:26 +09:00
91735ff367 Update MathUtils namespace usages 2020-01-09 13:43:44 +09:00
f0fe3bc804 Pass bindable to BeatmapMetadataDisplay
It was reported that mods selected in song select would show up during
loading of replays which were recorded under a different set of mods.
This was caused by BeatmapMetadataDisplay accepting a plain read-only
value of the Mods bindable in PlayerLoader.load(), therefore making the
mod value assignment in ReplayPlayerLoader.OnEntering() have no effect
on that component.

To resolve this issue, make BeatmapMetadataDisplay accept the
higher-level bindable, bind to it locally and pass it down the hierarchy
to ModDisplay.
2020-01-08 20:10:43 +01:00
a3f7d3c445 Add failing test
Add test case demonstrating the lack of update of the metadata display's
mods upon setting the Mods property in PlayerLoader.
2020-01-08 19:55:35 +01:00
d828b31ae4 Schedule child mutation in test setup 2019-12-27 17:16:43 +01:00