40ae856dfc
Show 2 decimals for background filesize
2021-04-20 01:34:05 +02:00
14c626ffcb
Use the playable beatmap for file presence checks
2021-04-20 01:33:19 +02:00
8656176ab8
Add the playable beatmap as check argument
...
This is different from the working beatmap's `.Beatmap` property in that it is mutated by the ruleset/editor.
So hit objects, for example, are actually of type `Slider` and such instead of the legacy `ConvertSlider`.
This should be preferred over `workingBeatmap.Beatmap`.
2021-04-20 01:31:51 +02:00
9a69ca34a6
Add audio presence check
2021-04-18 02:07:57 +02:00
010720de74
Factor out general file presence checking
...
This allows us to use the same method of checking for other files that should exist, for example the audio file.
By using the same method, they all share test cases too.
2021-04-18 02:07:33 +02:00
56bf49c85c
Take IWorkingBeatmap instead of WorkingBeatmap
...
This makes testing much easier, and allows for checking of any class deriving from that interface, including `WorkingBeatmap`.
2021-04-18 01:21:20 +02:00
abf512532e
Clean up check logic
...
Makes use of the new `BeatmapSet.GetPathForFile` method and removes dependency on `WorkingBeatmap` specifically, allowing us to switch to `IWorkingBeatmap` later.
2021-04-18 01:19:25 +02:00
cb41c89935
Don't return low res and too low res at the same time
2021-04-17 20:10:07 +02:00
62c54e00cb
Add check for background resolution and filesize
2021-04-17 18:01:04 +02:00
448574e7e6
Use WorkingBeatmap instead of IBeatmap
...
This lets us access things like the background, track, etc. which are necessary for quality and filesize checks.
Also improves the structure of the `CheckBackgroundTest` class in the process.
2021-04-17 17:33:53 +02:00
119c9b4294
Fix placement blueprints not being correctly removed after a rolled back placement
2021-04-16 14:11:33 +09:00
cb4f64133e
Add xmldoc to interfaces
2021-04-13 23:30:20 +09:00
69da804f81
Add missing period
2021-04-13 13:57:56 +02:00
0d6890243f
Fix typo in xmldoc
2021-04-13 20:18:18 +09:00
03ba04e8ce
Split out general checks into its own verifier class (and remove static usage)
2021-04-13 19:50:22 +09:00
aa5fe2e9fc
Rename BeatmapVerifier -> IBeatmapVerifier
2021-04-13 11:02:01 +02:00
60c2494b31
Make BeatmapVerifier an interface
2021-04-13 10:40:56 +02:00
6d3f9fa9ce
Use is class instead of Equals with template index
...
Ensures ordering of `PossibleTemplates` does not affect tests.
2021-04-13 02:29:25 +02:00
d8088777ea
Add Equals method to IssueTemplate
...
This will be useful in tests.
2021-04-13 01:21:34 +02:00
19a154ddf1
Rename checkOrigin -> check
...
More consistent with `Issue.ctor`'s "template".
2021-04-12 17:28:12 +02:00
bb720c23a0
Remove check ctors and locals
2021-04-12 17:12:37 +02:00
62c1812282
Remove redundant parameter naming
2021-04-12 23:37:47 +09:00
36bd235021
Move nested classes to bottom of file
2021-04-12 23:36:10 +09:00
6d50d01186
Make IssueTemplate.Check readonly
2021-04-12 16:23:05 +02:00
caaaba5950
Rename Check -> ICheck
2021-04-12 16:20:53 +02:00
008dbc7dd6
Reverse IssueType ordering
...
Reversed both in the enum and where it's displayed, so ends up the same in the end.
2021-04-12 15:49:13 +02:00
7c4f6d2b62
Rework template usage
...
Includes moving the origin check back to templates, constructing nested template classes in each check, and making parameterized template usage.
2021-04-12 15:47:26 +02:00
65ebdd8f7a
Move check origin from IssueTemplate to Issue
...
As a result we can also make check an interface, and need to provide the check itself when constructing an issue.
2021-04-12 10:08:08 +02:00
8bf85d737c
Change Metadata into a get property
2021-04-12 15:52:29 +09:00
78bbc8f5c8
Tidy some remaining code
2021-04-12 15:52:18 +09:00
8c31e96cdf
Change some methods to get properties
2021-04-12 15:52:18 +09:00
f78239c7f2
Move enums out of nesting
2021-04-12 15:52:18 +09:00
3551322f1d
Fix formatting of colour getter
2021-04-12 15:52:18 +09:00
257acf9cd8
Colour constants to private
2021-04-12 15:52:18 +09:00
136627b9ac
Wrap xmldoc less and make a few fixes
2021-04-12 15:52:18 +09:00
1c553b5d48
Checker -> BeatmapVerifier
2021-04-12 15:29:05 +09:00
14bd5bdc77
Merge branch 'master' into verify-tab
2021-04-12 15:14:37 +09:00
3289bb0379
Merge Check and BeatmapCheck
...
We're probably not going to need GeneralChecks or BeatmapsetChecks.
The verify tab is only available to a single difficulty at a time, and we already have access to the rest of the set through `IBeatmap`.
2021-04-10 14:56:30 +02:00
bc4f3351f3
Replace checks with realistic ones
2021-04-10 13:03:16 +02:00
b30e41b805
Fix comment; mode -> ruleset
2021-04-10 13:02:36 +02:00
d1007ff26a
Move components to more appropriate spot
2021-04-10 13:02:22 +02:00
b24ce66a0d
Add check/issue classes
2021-04-07 14:35:33 +02:00
9a02f3868c
return a string instead
2021-03-29 17:29:05 +08:00
b8b7eb4c4b
refactor logic to its own component and handle hit object to string conversion to its ruleset-specific composers
2021-03-26 15:25:20 +08:00
e9730d4782
Move default sample addition to inside PlacementBlueprint
...
This isn't actually required to fix the behaviour but it does feel like
a better place to put this logic.
2021-02-11 17:16:18 +09:00
04fa32bc34
Rename and add xmldoc for smooth seeking method
2021-01-15 16:14:21 +09:00
3ad2eeaff5
Fix outdated xmldoc
2020-11-30 18:35:30 +09:00
9811c46e35
Rename application method to better describe what it actually does
2020-11-26 19:16:18 +09:00
c9a41f9dae
Make all objects in selection candidates for spatial snapping
...
Closes #10898 .
2020-11-24 17:35:54 +09:00
3957697c48
Add pooling support to the editor
2020-11-13 17:08:20 +09:00
