Commit Graph

9126 Commits

Author SHA1 Message Date
2dafa041a7 Account for offset being applied to editor clock time in TestSceneEditorClock 2022-08-29 16:42:50 +09:00
d4a37725c4 Adjust test 2022-08-29 15:59:57 +09:00
a215d009fe Update Remove/RemoveRange/RemoveAll calls in line with framework changes 2022-08-29 15:57:40 +09:00
423f6f90f2 Remove async calls from ScoreManager 2022-08-29 15:34:08 +09:00
e8ae6840ea Add test coverage of selection being retained 2022-08-29 15:23:34 +09:00
892f43da43 Add test coverage of ruleset being marked unavailable if methods are throwing 2022-08-29 14:28:55 +09:00
5ff4e6a4fe Add test coverage for outdated ruleset 2022-08-29 14:26:12 +09:00
c0b13c7e1f Refactor ScoreProcessor ComputeScore() methods 2022-08-29 13:51:10 +09:00
d4a52baa56 Added visual test for UprightAspectMaintainingContainer 2022-08-29 00:07:42 +01:00
2a12194ff9 Test colours 2022-08-28 02:59:38 +03:00
90334a2b91 Add test scene 2022-08-27 20:12:45 +03:00
289b6f1a58 Merge pull request #19924 from peppy/fix-playlist-overlay-test-failures
Fix intermittent test failures in `TestScenePlaylistOverlay`
2022-08-26 23:36:16 +09:00
1fd1672d89 Merge branch 'master' into mod-validation-tests 2022-08-26 15:00:07 +03:00
6dc859973b Merge branch 'master' into fix-playlist-overlay-test-failures 2022-08-26 20:25:53 +09:00
90ff0864c0 Merge branch 'master' into no-gameplay-clock-editor-offset 2022-08-26 20:25:21 +09:00
91e044542d Merge pull request #19828 from peppy/no-gameplay-clock-gameplay-offset
Introduce `FramedBeatmapClock` (and use in gameplay flow)
2022-08-26 20:21:34 +09:00
5ef8e26ebe Fix check not accounting for mods not existing in certain rulesets
Also check all instances, rather than first.
2022-08-26 19:59:26 +09:00
580754833f Merge branch 'master' into mod-validation-tests 2022-08-26 19:48:42 +09:00
9c9238d6e8 Fix TimelineTestScene's beatmap getting overwritten by EditorClockTestScene 2022-08-26 18:38:52 +09:00
4b72e55770 Fix various test scenes not adding EditorClock to the draw hierarchy 2022-08-26 18:08:43 +09:00
9050f54681 Split out test assertion methods to read better 2022-08-26 16:56:03 +09:00
a8c699610a Fix lead in tests not waiting for player to start running
The tests are only meant to ensure that gameplay eventually starts.

The case where failures can occur is where the master clock is behind
the player clock (due to being in lead-in time). Because the test is
running in real-time, it can take arbitrary amounts of time to catch up.

If it took too long, the test would fail.
2022-08-25 18:00:14 +09:00
ddb434f47a Rename asserts to method names to make it easier to track in logs 2022-08-25 17:30:13 +09:00
a5c61d9a52 Improve understandability of TestMostInSyncUserIsAudioSource 2022-08-25 16:47:33 +09:00
3a17c6df08 Merge branch 'master' into no-gameplay-clock-gameplay-offset 2022-08-25 16:24:55 +09:00
eb57ea76ab Merge branch 'master' into legacy-combo-increase 2022-08-25 09:46:12 +03:00
1032b2a68c Fix some BeatmapCarousel tests not correctly reinitialising local data per run
Closes https://github.com/ppy/osu/issues/19949.
2022-08-25 14:03:26 +09:00
73f41439ae Remove redundant qualifiers 2022-08-25 13:34:58 +09:00
5cddc7ed1f Code cleanup (CPS) 2022-08-24 17:13:23 +02:00
c9ff39f8c3 Add HitResult.LegacyComboIncrease 2022-08-24 19:46:41 +09:00
5129716612 Merge branch 'master' into kps 2022-08-24 18:18:45 +09:00
ddccf4defe Remove dollar sign 2022-08-24 17:17:59 +09:00
27b57947e4 Rename PlayerArea.GameplayClock to SpectatorPlayerClock for clarity 2022-08-24 17:13:14 +09:00
5f01f461b3 Ensure elapsed time is always non-zero when advancing SpectatorPlayerClock 2022-08-24 17:13:14 +09:00
5079e0d83d Merge branch 'master' into no-gameplay-clock-gameplay-offset 2022-08-24 16:52:10 +09:00
adea29c106 Fix test failures 2022-08-24 03:37:33 -04:00
d33d705684 Make WaitingOnFrames non-bindable 2022-08-24 16:03:38 +09:00
c7d4c739aa Add a basic NaN control point test for LegacyBeatmapDecoder 2022-08-24 02:53:55 -04:00
995e6664b6 Rename spectator clock sync classes 2022-08-24 15:13:08 +09:00
31f657fe01 Remove ISpectatorPlayerClock interface
Too many levels of redirection.

One interface with one implementation is not useful, IMO.
2022-08-24 15:12:57 +09:00
46d000b8ce Fix test regressions on windows due to Reset never being called
I'm not sure this is great. Without calling `Reset`, the correct initial
time may not be set (ever). In practice this doesn't happen anywhere in
the gameplay flow, but something worth noting.

This change is required now that `Reset` isn't called in the
constructor. It couldn't be called in the constructor because it would
cause the audio track to reset its position too early.

What an ordeal.
2022-08-24 11:50:20 +09:00
ec61a94dc9 Merge branch 'master' into no-gameplay-clock-gameplay-offset 2022-08-23 17:36:06 +09:00
9a579871c0 Remove pointless initial import 2022-08-23 17:33:53 +09:00
a62deae3cc Use local realm rather than fetching from dependencies 2022-08-23 17:33:53 +09:00
690e048864 Ensure all initial imports are completed before running playlist overlay tests steps 2022-08-23 17:33:53 +09:00
553897f2f0 Remove AddClock method to CreateManagedClock 2022-08-23 13:52:43 +09:00
a81672f3dc Use an infinite tick distance instead of directly disabling tick generation for SliderEventGenerator 2022-08-22 23:31:24 -04:00
9f08c474ca Treat NaN slider velocity timing points as 1.0x but without slider ticks 2022-08-22 21:58:38 -04:00
e8d4bc4497 Allow NaN during beatmap parsing if desired 2022-08-22 21:04:26 -04:00
5d3d8681d4 Invert creation of clocks in multi spectator 2022-08-22 19:14:06 +09:00