Commit Graph

2184 Commits

Author SHA1 Message Date
a922ea9b01 Fix selection by directly comparing control points
Previously, all control points would get replaced, which led to
performance issues that was worked around in this PR. By comparing
control points, we're able to get good performance without requiring the
workaround.
2022-06-20 15:29:29 +09:00
468e5fcbed Merge branch 'master' into editor-controlpoint-undo-redo 2022-06-20 13:47:01 +09:00
3ab8158b92 Do not try to set ruleset from beatmap if it's a dummy 2022-06-19 20:08:39 +02:00
93b3ede2a0 Always use beatmap ruleset in editor gameplay test mode
Fixes cases where opening a convertible beatmap (so any osu! beatmap)
with the game-global ruleset being set to anything but osu! would result
in opening the editor gameplay test mode with the game-global ruleset
rather than the beatmap's.
2022-06-19 19:30:40 +02:00
a2e17941e5 Merge branch 'master' into timing-offset-adjust-seek-only-at-start 2022-06-19 01:27:44 +03:00
3902dc64f0 Fix adjusting offset via button seeking to timing point's offset unexpectedly
This was added with the intention of tracking the offset when already at
the start (the most common case when you're using the tap timing
wizard), but was also seeking when the user may be much further beyond
or before it.

Addresses https://github.com/ppy/osu/discussions/18741#discussioncomment-2975051.
2022-06-19 01:35:45 +09:00
a5e5172b91 Fix BlueprintContainer eating input from skin editor buttons 2022-06-18 18:28:36 +03:00
f6a3047596 Merge branch 'master' into editor-metadata-name-unification 2022-06-18 10:22:52 +02:00
204348f327 Fix metronome playing mistimed beat sounds on editor clock resume 2022-06-18 04:49:44 +03:00
8a1d11fefb Cancel previous metronome sound playback on pause 2022-06-18 04:07:21 +03:00
1f78a4fadd New audio feedback for metronome 2022-06-17 16:56:09 +09:00
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
6ff6a3f5b3 Rename and document chooserPath 2022-06-16 21:51:31 +02:00
db02cb81c5 Fix file chooser path not opening home directory initially 2022-06-16 20:48:17 +03:00
47d0ecf5e8 Merge branch 'master' into editor-metadata-name-unification 2022-06-16 18:53:23 +03:00
6aee689586 Fix previous file lookup not using metadata properties 2022-06-16 18:50:38 +03:00
f1081db953 Fix background/track implicitly renamed on initial load 2022-06-16 18:48:32 +03:00
2c35b1404b Use FileInfo as current bindable type 2022-06-15 19:29:09 +03:00
1ff070f5ff Decouple LabelledFileChooser from LabelledTextBoxWithPopover 2022-06-15 17:45:31 +03:00
7571ab6c63 Merge branch 'master' into new-dialog-sfx 2022-06-15 19:47:00 +09:00
c27e5d1216 Fix editor still playing back sound when exiting with confirmation 2022-06-15 18:44:02 +09:00
713cff3403 Don't play editor exit sound when changing difficulties 2022-06-15 17:49:09 +09:00
fd4529aa7c Play editor exit sound if no confirmation buttons were shown during exit process 2022-06-15 17:37:54 +09:00
6136e4e27a Don't play exit sound if screen is in a non-resumable state when exiting 2022-06-15 17:37:25 +09:00
87bf53485a Merge pull request #18649 from frenzibyte/selection-context-outside-bounds
Fix context menus not appearing when clicking outside of editor playfield's bounds
2022-06-15 17:08:09 +09:00
6a8cf514e0 Update background/track file chooser to not display filename 2022-06-15 09:52:13 +03:00
5e3ccf7087 Don't play 'back' sample when exiting Editor 2022-06-15 15:41:28 +09:00
f3f0960335 Use unified filename for background and track during editor import 2022-06-15 09:02:48 +03:00
d3feb07bc1 Split zoom updating to named method with value as optional 2022-06-15 07:57:16 +03:00
268a7e1334 Fix ZoomableScrollContainer attempting to update zoom with overlapping range 2022-06-15 05:43:41 +03:00
cc7943dfb1 Merge pull request #18687 from peppy/editor-repeat-behaviour-change-collapsing
Fix timing adjustment repeat buttons firing one change per repeat invocation
2022-06-14 20:24:13 +09:00
c30644328c Fix timing adjustment repeat buttons firing one change per repeat invocation 2022-06-14 19:21:02 +09:00
aeca138930 Fix ctrl-z in editor also seeking to start in addition to undo 2022-06-14 18:48:57 +09:00
fa4930c586 Remove no longer necessary ReceivePositionalInputAt overrides in timeline components 2022-06-14 00:19:47 +03:00
c49b8e4a5c Allow BlueprintContainer and SelectionHandler to receive input outside bounds 2022-06-14 00:19:15 +03:00
9fc04924eb Revert "Provide context menu items at BlueprintContainer for out-of-bounds support"
This reverts commit 85fc218edf.
2022-06-14 00:02:02 +03:00
f680f4d26b Apply refactorings from review 2022-06-13 17:36:32 +09:00
c178e5d592 Add explanatory comment 2022-06-13 16:58:43 +09:00
a8286bdf04 Fix assertion failures 2022-06-13 16:56:08 +09:00
285e5abb41 Fix incorrect fallback value 2022-06-13 16:55:46 +09:00
5a18547342 Compare by char
Co-authored-by: Berkan Diler <berkan.diler1@ingka.ikea.com>
2022-06-13 15:58:11 +09:00
776e7c0c71 Work around performance issues 2022-06-13 15:45:08 +09:00
7e7716f942 Support undo/redo for control points 2022-06-13 15:45:08 +09:00
85fc218edf Provide context menu items at BlueprintContainer for out-of-bounds support 2022-06-11 20:53:53 +03:00
cd0e0fe70f Fix skin editor not accounting for aspect ratios in base-game sizing logic 2022-06-06 18:02:42 +09:00
b897e1464f Merge pull request #18462 from frenzibyte/fix-timeline-zooming
Fix timeline objects disappearing prematurely on wide-screens
2022-06-05 11:49:44 +09:00
fcf51a6f51 Merge pull request #18530 from peppy/add-cloen-button
Change text on timing group add button when it is going to clone instead
2022-06-03 22:23:04 +09:00
debd1a59b0 Merge pull request #18539 from frenzibyte/repeating-button-behaviour
Share repeat implementation in `TimingAdjustButton` for timeline zoom buttons
2022-06-03 18:18:23 +09:00
1c738e22ae Merge pull request #18523 from peppy/tap-button
Add tap for BPM button
2022-06-03 18:11:10 +09:00
cd3edc869c Remove unnecessary nesting of IconButton and update design a touch 2022-06-03 17:00:00 +09:00