e984dc4a19
Merge pull request #20042 from peppy/fix-composer-test-scenes
...
Test editor `ComposeScreen` tests not adding beatmap to hierarchy
2022-08-31 15:59:48 +09:00
e9463f3c19
Test editor ComposeScreen tests not adding beatmap to hierarchy
...
Makes it hard to test anything because `EditorBeatmap`'s `Update` method
updates whether a beatmap has timing or not (enabling the placement
controls).
Also adds a basic timing point to allow for better testing.
2022-08-31 14:07:56 +09:00
7ce1cf7560
Add test coverage of skip button failure with equal time
2022-08-31 13:22:51 +09:00
b8fda1a16f
Apply NRT to notification classes
...
and tidy things up a bit.
2022-08-30 15:57:10 +09:00
8b3742188f
Fix test by also clearing out maximum statistics
2022-08-30 15:42:36 +09:00
5202c15a0e
Populate MaximumStatistics for test scores
2022-08-30 15:11:39 +09:00
0491addbbd
Merge pull request #19974 from peppy/no-gameplay-clock-editor-offset
...
Fix editor not applying offsets
2022-08-29 21:10:29 +09:00
82b9e1f0eb
Merge pull request #20011 from smoogipoo/scoring-refactor
...
Refactor scoring to remove async methods / simplify
2022-08-29 19:55:27 +09:00
e3e204001e
Merge pull request #19907 from peppy/ruleset-api-versioning
...
Add ruleset API versioning
2022-08-29 18:50:01 +09:00
f2378d3fde
Merge branch 'master' into carousel-maintain-selection-over-update
2022-08-29 11:23:22 +03:00
9b830d063f
Merge pull request #20010 from smoogipoo/scoreprocessor-no-rewrite-statistics
...
Don't include misses in failed score statistics
2022-08-29 17:07:13 +09:00
2dafa041a7
Account for offset being applied to editor clock time in TestSceneEditorClock
2022-08-29 16:42:50 +09:00
d4a37725c4
Adjust test
2022-08-29 15:59:57 +09:00
423f6f90f2
Remove async calls from ScoreManager
2022-08-29 15:34:08 +09:00
e8ae6840ea
Add test coverage of selection being retained
2022-08-29 15:23:34 +09:00
892f43da43
Add test coverage of ruleset being marked unavailable if methods are throwing
2022-08-29 14:28:55 +09:00
5ff4e6a4fe
Add test coverage for outdated ruleset
2022-08-29 14:26:12 +09:00
c0b13c7e1f
Refactor ScoreProcessor ComputeScore() methods
2022-08-29 13:51:10 +09:00
289b6f1a58
Merge pull request #19924 from peppy/fix-playlist-overlay-test-failures
...
Fix intermittent test failures in `TestScenePlaylistOverlay`
2022-08-26 23:36:16 +09:00
1fd1672d89
Merge branch 'master' into mod-validation-tests
2022-08-26 15:00:07 +03:00
6dc859973b
Merge branch 'master' into fix-playlist-overlay-test-failures
2022-08-26 20:25:53 +09:00
90ff0864c0
Merge branch 'master' into no-gameplay-clock-editor-offset
2022-08-26 20:25:21 +09:00
91e044542d
Merge pull request #19828 from peppy/no-gameplay-clock-gameplay-offset
...
Introduce `FramedBeatmapClock` (and use in gameplay flow)
2022-08-26 20:21:34 +09:00
5ef8e26ebe
Fix check not accounting for mods not existing in certain rulesets
...
Also check all instances, rather than first.
2022-08-26 19:59:26 +09:00
580754833f
Merge branch 'master' into mod-validation-tests
2022-08-26 19:48:42 +09:00
9c9238d6e8
Fix TimelineTestScene's beatmap getting overwritten by EditorClockTestScene
2022-08-26 18:38:52 +09:00
4b72e55770
Fix various test scenes not adding EditorClock to the draw hierarchy
2022-08-26 18:08:43 +09:00
9050f54681
Split out test assertion methods to read better
2022-08-26 16:56:03 +09:00
a8c699610a
Fix lead in tests not waiting for player to start running
...
The tests are only meant to ensure that gameplay eventually starts.
The case where failures can occur is where the master clock is behind
the player clock (due to being in lead-in time). Because the test is
running in real-time, it can take arbitrary amounts of time to catch up.
If it took too long, the test would fail.
2022-08-25 18:00:14 +09:00
ddb434f47a
Rename asserts to method names to make it easier to track in logs
2022-08-25 17:30:13 +09:00
a5c61d9a52
Improve understandability of TestMostInSyncUserIsAudioSource
2022-08-25 16:47:33 +09:00
3a17c6df08
Merge branch 'master' into no-gameplay-clock-gameplay-offset
2022-08-25 16:24:55 +09:00
eb57ea76ab
Merge branch 'master' into legacy-combo-increase
2022-08-25 09:46:12 +03:00
1032b2a68c
Fix some BeatmapCarousel tests not correctly reinitialising local data per run
...
Closes https://github.com/ppy/osu/issues/19949 .
2022-08-25 14:03:26 +09:00
73f41439ae
Remove redundant qualifiers
2022-08-25 13:34:58 +09:00
c9ff39f8c3
Add HitResult.LegacyComboIncrease
2022-08-24 19:46:41 +09:00
ddccf4defe
Remove dollar sign
2022-08-24 17:17:59 +09:00
27b57947e4
Rename PlayerArea.GameplayClock to SpectatorPlayerClock for clarity
2022-08-24 17:13:14 +09:00
5f01f461b3
Ensure elapsed time is always non-zero when advancing SpectatorPlayerClock
2022-08-24 17:13:14 +09:00
5079e0d83d
Merge branch 'master' into no-gameplay-clock-gameplay-offset
2022-08-24 16:52:10 +09:00
d33d705684
Make WaitingOnFrames non-bindable
2022-08-24 16:03:38 +09:00
995e6664b6
Rename spectator clock sync classes
2022-08-24 15:13:08 +09:00
31f657fe01
Remove ISpectatorPlayerClock interface
...
Too many levels of redirection.
One interface with one implementation is not useful, IMO.
2022-08-24 15:12:57 +09:00
46d000b8ce
Fix test regressions on windows due to Reset never being called
...
I'm not sure this is great. Without calling `Reset`, the correct initial
time may not be set (ever). In practice this doesn't happen anywhere in
the gameplay flow, but something worth noting.
This change is required now that `Reset` isn't called in the
constructor. It couldn't be called in the constructor because it would
cause the audio track to reset its position too early.
What an ordeal.
2022-08-24 11:50:20 +09:00
ec61a94dc9
Merge branch 'master' into no-gameplay-clock-gameplay-offset
2022-08-23 17:36:06 +09:00
9a579871c0
Remove pointless initial import
2022-08-23 17:33:53 +09:00
a62deae3cc
Use local realm rather than fetching from dependencies
2022-08-23 17:33:53 +09:00
690e048864
Ensure all initial imports are completed before running playlist overlay tests steps
2022-08-23 17:33:53 +09:00
553897f2f0
Remove AddClock method to CreateManagedClock
2022-08-23 13:52:43 +09:00
5d3d8681d4
Invert creation of clocks in multi spectator
2022-08-22 19:14:06 +09:00
