Commit Graph

60323 Commits

Author SHA1 Message Date
4ca80cf6be Merge pull request #23404 from peppy/show-sv-in-inspector
Show slider velocity in hit object inspector
2023-05-05 20:19:50 +02:00
3b37a421e6 Merge pull request #23401 from peppy/fix-break-overlay-glow-cutoff
Fix break overlay arrows' glow getting cut off at lower resolutions
2023-05-05 20:12:34 +02:00
c62dafa407 Merge pull request #23406 from peppy/blocked-namespaces
Prefer block scoped namespaces
2023-05-05 20:06:23 +02:00
71864fbb93 remove meanless comment 2023-05-05 21:29:06 +09:00
4393e53b43 ExportToStream should be public 2023-05-05 21:28:43 +09:00
490df8073c Fix one incorrect namespace syntax file 2023-05-05 21:15:26 +09:00
747f912af5 Fix incorrect cancellation logic 2023-05-05 21:08:01 +09:00
5d78561aa3 Remove weird catch logic 2023-05-05 21:05:57 +09:00
2a3e03695c Simplify ExportAsync, remove weird dedupe logic and unnecessary return success code 2023-05-05 21:05:52 +09:00
4ccfebc02b Simplify ExportToStreamAsync implementation 2023-05-05 21:01:10 +09:00
fc2d2de34c Fix notification text not including export filename 2023-05-05 16:53:27 +09:00
9cafb20fcb Move file missing logging to a better location, and log actual filenames to logs 2023-05-05 16:53:16 +09:00
4ec98b0578 Improve xmldoc and fix silly progress text in LegacyArchiveExporter 2023-05-05 16:45:45 +09:00
f2dd457b3d Remove unnecessary local variable 2023-05-05 16:31:48 +09:00
6a4933a31c Remove need for TestRealmLive nonsense 2023-05-05 16:30:43 +09:00
0158102467 Rename class back to original name so I can read the diff 2023-05-05 16:19:10 +09:00
3d55a0291f Prefer block scoped namespaces 2023-05-05 16:06:02 +09:00
b7a287869a Add display of beatmap slider velocity when adjusting 2023-05-05 15:57:38 +09:00
cc70d89bf9 Move editor inspector classes out of ruleset namespace 2023-05-05 15:57:38 +09:00
4663057060 Split out EditorInspector implementation for reuse 2023-05-05 15:54:15 +09:00
76b2f0e6dd Show slider velocity in hit object inspector 2023-05-05 15:15:18 +09:00
560f71ef53 Adjust BlurredIcon expansion ratio to fix glow getting cut off at lower resolutions
Closes https://github.com/ppy/osu/issues/23210.

Ballparked the fix to work down to the lowest resolution we support. The
previous number (`2.5f`) was also likely ballparked so the fix seems in
line with expectations.

I don't want to put too much thought into this because the design of
this screen is likely going to change in the mean time anyway.
2023-05-05 14:29:04 +09:00
8391e2a538 Move reporting code out of DrawableChatUsername into more correct locations 2023-05-05 14:03:42 +09:00
698baa78bf Merge pull request #22711 from Terochi/keep-shared-settings-ruleset-change
Keep shared mod settings when changing ruleset
2023-05-05 13:29:55 +09:00
dcd2abae6d Add test coverage for mod equality with multiple settings 2023-05-04 20:46:27 +02:00
6368e1cc53 Merge pull request #22801 from cdwcgt/edit-mods-preset
Add ability to edit mod presets
2023-05-04 19:43:42 +02:00
a1106d0a4e Be explicit in test 2023-05-04 19:14:20 +02:00
99e8b2ce70 Make getMod() method generally better 2023-05-04 19:12:22 +02:00
aa7885ab97 Use better test step names 2023-05-04 19:11:51 +02:00
485b7282dc Clarify type check 2023-05-04 19:06:07 +02:00
bdd96caaa9 Merge branch 'master' into edit-mods-preset 2023-05-04 18:59:47 +02:00
e43fc23606 Fix typos in test 2023-05-04 18:50:21 +02:00
1f1342b099 Reword xmldoc 2023-05-04 18:33:49 +02:00
88e77ad390 Rename Settings{-> Map} 2023-05-04 18:30:41 +02:00
26337dbcd8 Do not rely on unspecified Dictionary.Values ordering 2023-05-04 18:29:01 +02:00
0d2396c557 Rename method to better indicate directionality 2023-05-04 18:15:12 +02:00
2cb6642b0d use AddUntilStep or not wait 2023-05-04 13:18:25 +09:00
95b541ab39 Update framework 2023-05-04 11:27:18 +09:00
0034124d79 Remove unnecessary content clear 2023-05-04 11:25:10 +09:00
26b8c5b852 Fix mod list display not updating after clicking "use current"
This is not a regression from my changes. It was broken before them.
2023-05-04 11:23:51 +09:00
49fb5da1a2 Stop passing preset panel to popover 2023-05-04 11:19:09 +09:00
b12d139317 Remove dead code 2023-05-04 11:16:52 +09:00
99d2616c34 Move drawable construction to load for simplicity 2023-05-04 11:14:51 +09:00
be995f1359 Add localisation support for new button string 2023-05-04 11:11:19 +09:00
b7abab6d8a More variable improvements 2023-05-04 11:10:05 +09:00
0a584f0652 Simplify check logic and improve variable naming 2023-05-04 11:07:09 +09:00
2bd07cc0d9 Merge pull request #23344 from Terochi/skin-editor-change-handler-improvement
Implement better logic for `ApplyStateChange` in skin editor
2023-05-03 20:36:15 +02:00
59ece64d25 Merge branch 'master' into skin-editor-change-handler-improvement 2023-05-03 19:42:42 +02:00
1d4d31e35c Trim comments
Leaving only the ones that add anything useful and do not restate the
code verbatim.
2023-05-03 19:22:52 +02:00
27fabd99fb Rename variables for legibility
Having `typedComponents` and `typeComponents` next to each other is
asking for trouble.
2023-05-03 19:21:16 +02:00