Commit Graph

38708 Commits

Author SHA1 Message Date
438f3e6349 move fallback text to PlaceholderText 2021-04-02 17:57:21 +02:00
a5a19319cc Fix code style 2021-04-02 21:15:28 +08:00
0c35128ead Merge pull request #11849 from Syriiin/diffcalc/fix/clockrate-adjusted-decay
Fix clockrate adjusted difficulty calculations bug in strain decay
2021-04-02 21:41:58 +09:00
cd53074941 Schedule spectator callbacks 2021-04-02 21:27:20 +09:00
1ff77754fd Use OnlineViewContainer 2021-04-02 20:14:31 +08:00
345779b19a Merge branch 'master' into diffcalc/fix/clockrate-adjusted-decay 2021-04-02 20:58:29 +09:00
d2950105fb Add comment explaining use of lock 2021-04-02 20:31:34 +09:00
dac8e5fdf4 Merge pull request #12265 from amberkowalski/classic-slidertail
Add classic mod setting to always play slider tail samples
2021-04-02 19:45:21 +09:00
143b8c422c Merge pull request #12259 from frenzibyte/fix-ruleset-file-loading
Guard against same ruleset file with filenames of loaded assembly location instead
2021-04-02 19:21:33 +09:00
9c3d15171c Reword xmldoc slightly 2021-04-02 18:00:28 +09:00
5ac36a2462 Switch AlwaysPlaySample to SamplePlaysOnlyOnHit in DrawableSliderTail for conformity 2021-04-02 03:56:23 -05:00
48e9985782 Make "AlwaysPlayTailSample" a mod setting rather than a hardcoded constant. 2021-04-02 03:10:28 -05:00
45d16fb916 Rename event parameter for clarity 2021-04-02 16:56:47 +09:00
5063cd957f Force hit sample to play when Classic mod is enabled 2021-04-02 02:54:35 -05:00
c564f6b8ec Merge pull request #12262 from smoogipoo/add-score-export
Add dropdown option to export score
2021-04-02 15:28:53 +09:00
6d4d574a65 Fix exported replay filenames not having full metadata 2021-04-02 14:10:25 +09:00
e1aa927827 Add dropdown option to export score 2021-04-02 13:20:15 +09:00
5b1dc7d2b4 Remove unused using directive 2021-04-02 02:45:26 +03:00
fcd56dba44 Guard against same ruleset file with loaded assembly filenames instead 2021-04-02 02:12:25 +03:00
133c529b2d Merge pull request #12255 from ppy/dependabot/nuget/Microsoft.NET.Test.Sdk-16.9.4
Bump Microsoft.NET.Test.Sdk from 16.9.1 to 16.9.4
2021-04-02 04:11:14 +09:00
8621a6b4fe Add margin to large segment test
Test ran fine on my end, but apparently not on the CI. This should make results a bit more consistent, hopefully.
2021-04-01 20:34:04 +02:00
6a286c5e21 Bump Microsoft.NET.Test.Sdk from 16.9.1 to 16.9.4
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.9.1 to 16.9.4.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.9.1...v16.9.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-04-01 17:16:02 +00:00
b8479a979f Remove unused blueprint variable 2021-04-01 18:06:12 +02:00
7e47922fb7 Merge branch 'master' into circular-arc-freeze 2021-04-01 17:09:45 +02:00
c3c7c18549 Fix tests 2021-04-01 23:48:26 +09:00
9bc2a486e0 Make SoloSpectator use the new SpectatorScreen class 2021-04-01 22:10:17 +09:00
9e95441aa6 Rename Spectator -> SoloSpectator 2021-04-01 22:08:52 +09:00
af478fb2eb Add abstract spectator screen class 2021-04-01 22:02:32 +09:00
25afae5671 Fix broken test case
Seems this technically works, but only because of the edge case of being entirely linear, which the framework catches.

This fixes that.
2021-03-31 20:48:17 +02:00
7b684339ed Undo public -> internal for PathControlPoint.Changed
No longer used.
2021-03-31 20:32:49 +02:00
5022a78e80 Check current point instead of start point
Since each control point will call this when the path updates, the previous would correct the start segment 3 times instead of just once.

This fixes that.
2021-03-31 20:25:46 +02:00
75b8f2535f Move updatePathTypes to PathControlPointPiece
Here we produce a local bound copy of the path version, and bind it to update the path type.

This way, if the path version updates (i.e. any control point changes type or position), we check that all control points have a well-defined path.

Additionally, if the control point piece is disposed of, the GB should also swoop up the subscription because of the local bound copy.
2021-03-31 20:09:56 +02:00
1718084dbc Update/remove determinant tests
We now only change the path type based on the bounding box.

If the control points are too linear, the framework now handles the fallback to Bezier.
2021-03-31 20:08:39 +02:00
f6f1ef6986 Merge pull request #12220 from peppy/editor-fix-speed-multiplier-precision
Fix legacy control point precision having an adverse effect on the editor
2021-03-31 18:00:11 +09:00
f8c1dfe57f Merge branch 'master' into editor-fix-speed-multiplier-precision 2021-03-31 17:17:25 +09:00
ef1f133fb1 Merge pull request #12238 from peppy/fix-mass-drag-drop-imports
Group large drag drop imports into a single operation
2021-03-31 16:15:26 +09:00
f46fae9ec6 Merge pull request #12235 from smoogipoo/fix-never-ending-mania
Fix mania beatmaps sometimes never ending
2021-03-31 15:48:05 +09:00
ffc28256d0 Merge pull request #12237 from peppy/fix-retry-count
Fix retry count not updating correctly
2021-03-31 14:59:12 +09:00
30cae46cbd Group large drag drop imports into a single operation 2021-03-31 14:57:28 +09:00
0c53b4eb93 Fix wrong counting and add test 2021-03-31 14:09:39 +09:00
e0c61f4dc5 Fix retry count not updating correctly
Regressed with changes to player reference retention logic. Could add a
test but the logic is so local now it seems quite redundant.
2021-03-31 13:57:58 +09:00
43e48406ca Miss all ticks when hold note is hit 2021-03-31 12:21:14 +09:00
f78d628878 Improve assertions 2021-03-31 12:21:07 +09:00
ded91b32a4 Add failing test 2021-03-31 12:11:43 +09:00
e848444d74 Merge pull request #12227 from peppy/fix-accuracy-display
Fix accuracy displaying incorrectly in online contexts
2021-03-30 23:35:23 +09:00
fb0079fb9f Fix accuracy displaying incorrectly in online contexts
Closes #12221.
2021-03-30 22:42:32 +09:00
8bd03c2e2a Merge pull request #12218 from peppy/tablet-rotation-configuration
Add tablet rotation configuration
2021-03-30 21:04:12 +09:00
633e6130bf Update framework 2021-03-30 19:46:22 +09:00
de394f3d14 Merge branch 'master' into tablet-rotation-configuration 2021-03-30 19:46:19 +09:00
a2f50af424 Fix fall-through scroll redirection 2021-03-30 19:42:40 +09:00