Commit Graph

24911 Commits

Author SHA1 Message Date
fd8c5d7706 Improve notification overlay test robustness
Stress testing one of the notification overlay tests by running it 10000
times on repeat has shown that it is susceptible to intermittent
failures due to races between delays and asserts checking the number of
currently progressing notifications and the actual progress update,
which contains a random generation factor.

Replace step sequences checking for notification completion by waiting
and asserting with explicit until steps that don't terminate unless
there are zero progressing notifications.
2019-12-26 23:01:31 +01:00
3d7c7a1ced Fix profile title wasn't in lowercase 2019-12-26 22:39:13 +03:00
193e41f878 Add origin adjustment for hitobject lifetime
Visual inspection of taiko gameplay has shown that hitobjects appeared
on screen only when the origin of the hitobject came into the bounds
of the screen, instead of appearing when any visible part of the
hitobject came into the screen bounds.

This behaviour was due to lifetime calculation being based on the origin
of the hitobject and not taking into account the actual object
dimensions. Adjust the lifetime start of the hitobject by subtracting
the time needed to show the part of the hitobject that should already
be visible on screen when the origin comes into frame.
2019-12-26 20:37:29 +01:00
005ec4b373 Demonstrate bug in scrolling container scene
Modify TestSceneScrollingHitObjects to showcase the effect of origin
choice on object lifetime for all four scrolling directions.
2019-12-26 20:37:06 +01:00
e360aa4588 Fix TabControl wasn't on top of everything 2019-12-26 22:16:20 +03:00
a1c91af095 Update layout of every overlay using OverlayHeader 2019-12-26 22:09:06 +03:00
647c83e6c8 Add ability to not create content for headers
Rather than creating an empty container
2019-12-26 21:21:15 +03:00
ca3e8db79f Merge dependency 2019-12-26 21:03:39 +03:00
2d32fe08ff Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay_headers_update 2019-12-26 21:02:14 +03:00
cac011edc1 Merge branch 'master' into hp-drain 2019-12-26 23:51:12 +09:00
32843ffef5 Merge branch 'master' into fix-hold-note-input 2019-12-26 23:50:53 +09:00
033bb15500 Fix early-escape not continuing to results screen (#7362)
Fix early-escape not continuing to results screen
2019-12-26 23:50:21 +09:00
3d5561b02e Separate health and score processing components (#7358)
Separate health and score processing components
2019-12-26 23:48:55 +09:00
64381bf4b1 rm unnecessary usings 2019-12-26 22:08:46 +08:00
75d1e4cc76 rm TestLegacySkin 2019-12-26 22:06:29 +08:00
8ebfe5cfd8 add tests 2019-12-26 21:15:49 +08:00
92dd1ade17 Attempt to implement mania-specific sprites 2019-12-26 21:03:21 +08:00
a4d4efc312 Fix missing comments 2019-12-26 19:33:59 +09:00
8d79934d39 Fix nub position getting offset by size changes (#7359)
Fix nub position getting offset by size changes
2019-12-26 19:18:52 +09:00
00a36c388c Fix tests 2019-12-26 19:18:39 +09:00
a041f32072 Use cleaner solution via cancellation of older schedule 2019-12-26 19:05:32 +09:00
74d875a2e0 Give empty archives a hash based on archive name to avoid duplicate imports 2019-12-26 18:44:50 +09:00
f005784070 Merge pull request #7360 from huoyaoyuan/mod-typo
Fix name typo of OsuModObjectScaleTween
2019-12-26 18:29:10 +09:00
8903f286ef Fix escape not continuing to results screen 2019-12-26 18:27:48 +09:00
d45556eb6a Remove whitespace 2019-12-26 17:57:16 +09:00
35f64d9aae More comments 2019-12-26 17:54:31 +09:00
7ee0370d23 Add some tests 2019-12-26 17:48:46 +09:00
f5dbd57d55 Refactor drain calculation for resiliency 2019-12-26 17:36:40 +09:00
662ec2d812 Refactor gameplay-time drain limitation 2019-12-26 15:46:07 +09:00
429272b864 Clean up + document taiko health processor 2019-12-26 15:28:30 +09:00
9a013acb26 Fix name typo of OsuModObjectScaleTween 2019-12-26 14:25:41 +08:00
96a4f9ae53 Fix nub position getting offset by size changes 2019-12-26 15:14:19 +09:00
e0c1072ab2 Add xmldocs 2019-12-26 15:01:19 +09:00
eba6371526 Re-implement taiko's accumulating health processor 2019-12-26 15:01:19 +09:00
3b07c3913d Add perfect and ok values, move to base Judgement 2019-12-26 15:00:59 +09:00
0454c5022d Fix some maps potentially starting with 0 health 2019-12-26 15:00:59 +09:00
90a0569660 Tweak drain values 2019-12-26 15:00:58 +09:00
522847987b Implement break/gameplay start times 2019-12-26 15:00:58 +09:00
b348abcd07 Only drain health in non-break times 2019-12-26 14:59:49 +09:00
977fb3d1bf Make processors and break overlay frame-stable 2019-12-26 14:59:49 +09:00
85c44b5a5a Disable list additions during gameplay 2019-12-26 14:59:49 +09:00
bd74d086fb Remove adjustment factor 2019-12-26 14:59:49 +09:00
70d2d8a2fa Add adjustable target percentage 2019-12-26 14:59:49 +09:00
a4b1c79e18 Initial implementation of HP drain 2019-12-26 14:59:49 +09:00
985277da79 Add time elapsation to judgement simulation 2019-12-26 14:59:49 +09:00
90cb9d9162 Simplify scoreprocesor/healthprocessor implementations 2019-12-26 14:59:49 +09:00
7414a6aadd Merge remote-tracking branch 'huoyaoyuan/master' into health-processor
# Conflicts:
#	osu.Game.Rulesets.Catch/CatchRuleset.cs
#	osu.Game.Rulesets.Mania/ManiaRuleset.cs
#	osu.Game.Rulesets.Taiko/TaikoRuleset.cs
2019-12-26 14:56:54 +09:00
f603dd82bc Fix difficulty adjust mod not correctly reading settings while leaderboard visible 2019-12-26 14:52:08 +09:00
5a11fe9a84 Merge pull request #7347 from peppy/fix-sample-lookup
Fix sample lookup not working correctly for custom rulesets
2019-12-26 12:40:55 +09:00
bb4d02a1f8 Fix incorrect icon offset 2019-12-25 22:09:14 +03:00