Commit Graph

123 Commits

Author SHA1 Message Date
26a33bfa4e Merge branch 'master' into fix-resume-from-player-audio 2019-10-11 19:21:14 +09:00
11acd177f1 Add import test with files to be filtered out
Add a test case reproducing the conditions encountered "in the wild"
wherein a skin import would be performed incorrectly due to a __MACOSX
resource fork directory present next to a directory with the actual skin
files in the archive.
2019-10-10 23:54:17 +02:00
c8ffc134d4 Use nameof when instantiating headless game hosts
As a purely cosmetic code improvement, substitute string literals
in constructor calls of HeadlessGameHost in ImportBeatmapTest for nameof
operator usages.
2019-10-10 22:36:43 +02:00
8df2e359c4 Fix tests on CI 2019-10-10 17:42:15 +09:00
6268bbcfc8 Merge branch 'master' into beatmap-parsing-fallback-v2 2019-10-03 15:12:21 +08:00
a06cb54732 Merge branch 'master' into beatmap-parsing-fallback-v2 2019-09-20 15:28:08 +09:00
f306fe27d8 Add test to cover corruption case 2019-09-20 15:05:48 +09:00
ddff9882cf Fix importing archives which are nested in a single folder within a zip 2019-09-19 19:11:04 +09:00
86588778b1 Implement fallback decoder registration
After the preparatory introduction of LineBufferedReader, it is now
possible to introduce registration of fallback decoders that won't drop
input supplied in the first line of the file.

A fallback decoder is used when the magic in the first line of the file
does not match any of the other known decoders. In such a case,
the fallback decoder is constructed and provided a LineBufferedReader
instance. The process of matching magic only peeks the first non-empty
line, so it is available for re-reading in Decode() using ReadLine().

There can be only one fallback decoder per type; a second attempt of
registering a fallback will result in an exception to avoid bugs.

To address the issue of parsing failing on badly or non-headered files,
set the legacy decoders for Beatmaps and Storyboards as the fallbacks.

Due to non-trivial logic, several new, passing unit tests with possible
edge cases also included.
2019-09-15 01:28:07 +02:00
9e1cb90dd8 Remove existing argument for ItemAdded event
For all usages, it looks like this was unnecessary.
2019-06-26 11:40:41 +09:00
12aa264657 Consolidate tests and check for file reference counts 2019-06-10 18:35:23 +09:00
28b2a516e3 Ensure exception is only thrown once on rollback 2019-06-10 18:13:33 +09:00
dcdb806120 Catch newly thrown exception in test 2019-06-10 17:26:56 +09:00
5b75060b94 Add test for rollback logic correctly dereferencing files 2019-06-10 16:45:45 +09:00
f090e292c9 Move ArchiveModelManager import process to async flow 2019-06-10 13:42:22 +09:00
00191ca940 Actually set the beatmap difficulty 2019-03-12 15:24:35 +09:00
059397ac50 Remove unnecessary early return for maching beatmap IDs 2019-03-12 14:40:13 +09:00
d0ae75af6e Add tests and fix scenario where all matching are contained by duplicate candidate 2019-03-11 18:13:33 +09:00
80737b9ef8 Remove "silent" parameter; consolidate import logic 2019-02-25 18:24:06 +09:00
628b3e1119 Move osu-resources to nuget 2019-01-28 18:33:39 +09:00
8617aaa2a7 Update licence header (and remove year) 2019-01-24 17:43:03 +09:00
c45c34d400 Make beatmap importing possible elsewhere in tests 2018-12-25 19:17:21 +09:00
a8ad7d4670 Add silent import parameter 2018-11-30 18:27:13 +09:00
a88b69ec43 Notify of existing imports 2018-11-28 20:19:35 +09:00
6c100caba7 Use existing instance of beatmap rather than adding more resources 2018-06-17 19:00:58 +09:00
aeeb03ff9c simpler temporary path generation 2018-06-06 18:36:43 +09:00
b84441ab87 Fix TestImportOverIPC 2018-06-04 22:25:18 +09:00
203691b1c7 Add import rollback test 2018-05-29 16:23:38 +09:00
cc081cad5a Simplify test osz instantiation 2018-05-29 16:23:38 +09:00
015fd9d0e7 Fix loading test method returning oldest import rather than newest 2018-05-29 16:23:38 +09:00
66b3b295e7 Use IBeatmap wherever possible 2018-04-19 20:44:38 +09:00
32a74f95a5 Normalize all the line endings 2018-04-13 18:26:38 +09:00
c21e820a45 One more level of nesting (we can do this better in the future) 2018-03-25 02:43:45 +09:00
e0d28564d0 Move import logic to shared implementation 2018-02-15 14:22:39 +09:00
9ed05543d7 Fix post-test conditionals from being inverse of what we want to test 2018-02-12 15:39:00 +09:00
264a0f59e2 Fix duplicate test name 2018-02-12 12:22:13 +09:00
721bb7e4dd Add proper handling for OnlineBeatmapSetID conflicts
Not yet working
2018-02-09 21:31:33 +09:00
541068235d Test import twice in a row 2018-02-09 18:23:06 +09:00
623ba652ed Share more code between tests 2018-02-09 18:20:18 +09:00
981fa379b7 Count() -> Count 2018-02-09 18:02:28 +09:00
a771ca4077 Add try-finally to ensure host is exited 2018-02-09 18:02:06 +09:00
8140ffea15 Add test for deleting then reimporting 2018-02-09 17:59:27 +09:00
a166932468 Add deletion test 2018-02-09 17:51:29 +09:00
d8da68c55f Disable test again (accidentally re-enabled) 2018-02-08 17:22:23 +09:00
789e25069f Fix non-visual tests not cleaning up previous executions 2018-02-08 17:07:59 +09:00
4f5bfdb888 Remove explicit .Exit on IPC test 2018-02-08 14:03:37 +09:00
74016a1482 Make sure the import tests exit their hosts 2018-02-07 15:57:16 +09:00
3c11978cfa Use local functions 2018-01-15 21:42:17 +03:00
37d393bca0 Update licence headers 2018-01-05 20:21:19 +09:00
0316ec3098 Remove no-longer-necessary Thread.Sleep 2017-10-24 10:08:00 +09:00