70420e6238
Merge pull request #19440 from peppy/bypass-local-metadata-cache
...
Fix beatmap updater potentially using outdated local metadata
2022-07-29 17:33:53 +09:00
9d457535c6
Add confirmation dialog when about to discard a playlist
...
The confirmation will only show if items have been added to the
playlist.
Closes https://github.com/ppy/osu/issues/19444 .
2022-07-29 17:11:37 +09:00
eb92c35335
Merge pull request #19442 from smoogipoo/fix-beginplaying-misordering
...
Move spectator begin/end playing to SubmittingPlayer
2022-07-29 16:09:50 +09:00
cb52b696ed
Merge branch 'master' into bypass-local-metadata-cache
2022-07-29 16:05:54 +09:00
2ff6ff06d3
Use tuple to better explain new bool
parameter
2022-07-29 16:05:41 +09:00
aaa6f963bd
Fix potential test failures due to Setup/SetUpSteps ordering
2022-07-29 15:27:39 +09:00
fd09155990
Revert blocking call when sending spectator frames
...
There are a lot of these requests, and we don't really care about
waiting on them to finish sending. This may have negatively affected
send performance for users with very high latency.
Reverts part of 0533249d11
.
Addresses concerns in https://github.com/ppy/osu/discussions/19429#discussioncomment-3276400 .
2022-07-29 12:24:54 +09:00
3005ff1b9f
Merge branch 'master' into pie-chart-progress
2022-07-28 22:19:27 +09:00
a59d7f6710
Merge branch 'master' into collections-track-beatmap-updates
2022-07-28 22:05:34 +09:00
aa03df905f
Merge pull request #19441 from peppy/test-working-beatmap-unfuck
...
Reduce calls to `LoadTrack` by implicitly running on test/dummy classes
2022-07-28 22:05:25 +09:00
11e0022fad
Merge branch 'master' into realm-collections
2022-07-28 21:00:08 +09:00
ce694123eb
Move spectator begin/end playing to SubmittingPlayer
2022-07-28 20:44:04 +09:00
4b140e1f5a
Adjust metrics
2022-07-28 18:50:46 +09:00
86c2b7e449
Apply nullability to DefaultSongProgress
and clean up more stuff
2022-07-28 18:37:17 +09:00
ea027eda46
Move initial show to base implementation and add transition for legacy version
2022-07-28 18:29:49 +09:00
bfa026879c
Remove pointless null check
2022-07-28 18:28:03 +09:00
d5e5761892
Fix DefaultSongProgress
graph not resetting if time is in intro
2022-07-28 18:25:24 +09:00
7108553883
Tidy up various things everywhere
2022-07-28 18:25:14 +09:00
a21aee4e9c
Reduce calls to LoadTrack
by implicitly running on test/dummy classes
2022-07-28 18:11:40 +09:00
628a30193f
Remove incorrect TrackLoaded
override from TestWorkingBeatmap
2022-07-28 17:49:17 +09:00
1da9830145
Merge pull request #19435 from peppy/remove-beatmap-manager-ruleset-store
...
Remove unused `RulesetStore` from `BeatmapManager` constructor
2022-07-28 17:46:12 +09:00
8cb4fb35e0
Rename parameter to read better (and still use local cache if no online API is available)
2022-07-28 17:08:59 +09:00
c35da62224
Add flow for bypassing local cache lookups when refreshing beatmap metadata
2022-07-28 16:33:51 +09:00
17a3fd30fb
Move scheduler from OnlineLookupQueue
to BeatmapUpdater
2022-07-28 16:32:22 +09:00
0d36907cad
apply code quality fixes
2022-07-28 15:30:45 +08:00
bca3994d91
set FirstHitTime
and LastHitTime
once
2022-07-28 15:25:12 +08:00
2b9d46d803
Remove unused RulesetStore
from BeatmapManager
constructor
2022-07-28 16:19:05 +09:00
db62d4be3a
apply suggestions
...
- refactor `SongProgress`
- make`UpdateProgress` more readable
- enable NRT on new classes
- refactor `TestSceneSongProgress` to use `GameplayClockContainer`
2022-07-28 15:15:41 +08:00
c1aaf27c54
Link to correct model in xmldoc
2022-07-28 16:02:19 +09:00
525e4a2019
Fix crash in DrawableRoomPlaylistItem
context menu creation due to incorrect enumeration casting
2022-07-28 15:51:18 +09:00
452d82f292
Add more comprehensive xmldoc for beatmap model classes
2022-07-28 15:41:28 +09:00
070f56c30c
Add collection transfer logic to beatmap import-as-update flow
2022-07-28 15:03:23 +09:00
2209afd0e8
Mark Live
methods as InstantHandleAttribute
2022-07-28 15:03:08 +09:00
ca68574473
Make NotificationOverlay
dependency optional in CollectionSettings
2022-07-28 14:35:27 +09:00
392cb352cc
Force alphabetical ordering for now
2022-07-28 14:07:42 +09:00
da06467891
Add missing realm subscription cleanup
2022-07-28 13:57:21 +09:00
ad482b8afc
Tidy up naming of collection dropdowns
2022-07-28 13:57:21 +09:00
226eefcc5c
Add note about hash storage
2022-07-28 13:57:21 +09:00
1669208a54
Add migration of existing collections database
2022-07-28 13:57:21 +09:00
34a2d1a6e1
Fix ManageCollectionsDialog
and remove weird placeholder logic
2022-07-28 13:57:21 +09:00
67c7f324ee
Simplify CollectionFilterDropdown
filter flow weirdness
2022-07-28 13:57:21 +09:00
aa65b73f19
Merge branch 'master' into add-notif-externalbutton
2022-07-28 12:17:36 +09:00
f44a4c8652
Reorder file content to match expectations
2022-07-28 12:13:47 +09:00
f01c397220
Apply nullability
2022-07-28 12:12:46 +09:00
f097064eea
Adjust to reviews
2022-07-27 21:52:38 -04:00
ac39d3a142
"Copied URL" -> "URL copied"
2022-07-27 21:52:28 -04:00
9088caa377
move LegacyComboCounter
to osu.Game.Skinning
2022-07-28 08:36:26 +08:00
45c11f2b7b
account for gameplay start time
2022-07-28 08:01:38 +08:00
804bb33aed
Hook up remaining data flows
2022-07-27 19:35:09 +09:00
438067a18b
Convert realm data propagation to more correctly use Live<T>
...
wip
2022-07-27 19:35:09 +09:00