Commit Graph

24231 Commits

Author SHA1 Message Date
bbf2ec369b Remove SkinReloadableDrawable inheritance from DHO 2021-04-21 17:34:57 +09:00
deeb9e3765 Update framework 2021-04-21 17:27:00 +09:00
cf55383fff Merge pull request #12486 from ekrctb/unmanaged-hit-object-entry
Associate DrawableHitObject with HitObjectLifetimeEntry rather than HitObject
2021-04-21 17:08:21 +09:00
31c5fb350f Merge branch 'master' into gcc-abstraction 2021-04-21 16:33:36 +09:00
fb848f7544 Rename to MasterGameplayClock 2021-04-21 16:33:14 +09:00
ab2a8b5c89 Fix initial rotation not being set 2021-04-21 16:12:09 +09:00
eb20865c02 Show tablet preview with physical tablet counter-rotated for supplied user area selection
Closes https://github.com/ppy/osu/issues/12399.

Rotation animation is intentionally delayed slightly to give a better sense of what is going on (or maybe just look cool).
2021-04-21 15:55:15 +09:00
1a715b2926 Append "classic" mod to legacy scores 2021-04-21 09:16:28 +03:00
e90d791754 Add base "classic" mod 2021-04-21 09:14:19 +03:00
3fbeadf318 Deprecate old overload of Apply 2021-04-21 14:32:37 +09:00
73d3da1687 Fix wrong InitialLifetimeOffset is used for a non-pooled DHO.
HitObjectLifetimeEntry's InitialLifetimeOffset is different from DrawableHitObject's InitialLifetimeOffset.
2021-04-21 11:32:01 +09:00
44ff08cce4 Revert "Fix wrong InitialLifetimeOffset is used for a non-pooled DHO."
This reverts commit 67fcfd9d
2021-04-21 10:02:50 +09:00
67fcfd9dbc Fix wrong InitialLifetimeOffset is used for a non-pooled DHO.
HitObjectLifetimeEntry's InitialLifetimeOffset is different from DrawableHitObject's InitialLifetimeOffset.
2021-04-21 09:48:16 +09:00
e80c3c317a Rename UnmanagedHitObjectEntry -> SyntheticHitObjectEntry
"Unmanaged" was confusing because its lifetime is still managed by the HitObjectContainer.
2021-04-21 09:23:23 +09:00
a2afa38a3f Merge branch 'master' into fix-mod-customisation-input-blocking-padding 2021-04-20 19:41:25 +02:00
26430e3cb5 Merge pull request #12492 from Naxesss/bg-audio-quality-checks
Add background and audio checks
2021-04-21 00:10:32 +09:00
7fc450c620 Fix mod settings blocking input outside its visible area
Closes #12502.
2021-04-20 23:42:56 +09:00
4cc3321d54 Fix potential doubling of events 2021-04-20 21:20:08 +09:00
a9e4a0ed50 Fix potentially starting play when finished
The UserFinishedPlaying event may trigger before the event is subscribed
to by SpectatorScreen. For such cases, an extra check is done to make
sure the user is _actually_ playing.
2021-04-20 21:19:08 +09:00
156a518068 Merge branch 'master' into fix-initial-spectator-state-callback 2021-04-20 21:16:05 +09:00
e9dfa2860a Add xmldoc note about path being relative 2021-04-20 13:44:06 +02:00
d7a81471c8 Add xmldoc to GetPathForFile 2021-04-20 13:40:38 +02:00
3e1b6b3b34 Simplify verifier run call args
Uses the resolved working beatmap instead of resolving it every time.

Also uses the EditorBeatmap itself as playable beatmap, as it is of type `IBeatmap` already, and `.PlayableBeatmap` forwards everything anyway.
2021-04-20 13:34:12 +02:00
ec080fcb32 Move seekOffset back to MasterGameplayClockContainer 2021-04-20 18:25:46 +09:00
a683e5ec34 Seek using local method 2021-04-20 17:40:11 +09:00
97fb90d9f4 Move clock processing to base.Seek() 2021-04-20 17:35:59 +09:00
80473a356e Merge branch 'fix-pre-seek-sample-lifetime' into gcc-abstraction 2021-04-20 17:27:01 +09:00
d28eb399a4 Fix storyboard sample lifetimes not set if seeked past 2021-04-20 17:14:48 +09:00
281c2041b2 Add failing test 2021-04-20 16:51:00 +09:00
c6ee4e900e Ensure a non-null hitobject entry has a non-null Result 2021-04-20 15:18:36 +09:00
3d6d26039a Remove unused usings 2021-04-20 14:09:54 +09:00
88ded95e75 Ensure clock is set in GCC.Start() 2021-04-20 13:56:13 +09:00
8dd9134e3d Move source clock adjustment application to Start() 2021-04-20 13:09:49 +09:00
a92ae8ce76 Fix Reset() potentially not resetting to the intended start position 2021-04-20 13:01:42 +09:00
8a8b9084ef Make single-argument overloead of DHO.Apply public 2021-04-20 10:11:36 +09:00
496df411a7 Remove now unused import 2021-04-20 02:39:11 +02:00
0e6b66f457 Merge branch 'master' into bg-audio-quality-checks 2021-04-20 02:36:13 +02:00
1478bcfa8e Improve xmldoc consistency 2021-04-20 02:30:27 +02:00
67e4fe4284 Add xmldoc to GetStream 2021-04-20 02:28:38 +02:00
1bc63a4c61 Now, DHO.lifetimeEntry can be non-null even it is not fully applied 2021-04-20 09:22:16 +09:00
4510e795e1 Fix category of audio quality check 2021-04-20 02:13:26 +02:00
c1b4aaaa03 Add doc comment 2021-04-20 08:38:02 +09:00
c633f15565 Add audio quality check 2021-04-20 01:36:03 +02:00
f168247254 Add Track as a property to IWorkingBeatmap
This is implemented by `WorkingBeatmap` already, and is much better to use than loading the track every time we need it.
2021-04-20 01:35:41 +02:00
40ae856dfc Show 2 decimals for background filesize 2021-04-20 01:34:05 +02:00
14c626ffcb Use the playable beatmap for file presence checks 2021-04-20 01:33:19 +02:00
8656176ab8 Add the playable beatmap as check argument
This is different from the working beatmap's `.Beatmap` property in that it is mutated by the ruleset/editor.

So hit objects, for example, are actually of type `Slider` and such instead of the legacy `ConvertSlider`.

This should be preferred over `workingBeatmap.Beatmap`.
2021-04-20 01:31:51 +02:00
0825fc57a9 Move foreground colour helper into OsuColour 2021-04-19 18:24:48 +02:00
97573fb11d Merge branch 'master' into combo-colours-display 2021-04-19 18:21:57 +02:00
510e54ff54 Update framework 2021-04-19 23:41:21 +09:00