Commit Graph

36431 Commits

Author SHA1 Message Date
fb52ac8c69 Share remove from playlist button design with adjacent download button 2021-02-02 16:57:08 +09:00
bdc05af4b7 Make playlist settings area taller to better match screen aspect ratio 2021-02-02 16:30:45 +09:00
43052991f8 Remove unused using statement 2021-02-02 16:18:55 +09:00
3002fef05e Remove empty parenthesis 2021-02-02 16:11:13 +09:00
54c0bdf7d3 Fix PlaylistLoungeTestScene appearing very narrow 2021-02-02 16:04:42 +09:00
a76314a876 Use Update instead of UpdateAfterChildren (no need for the latter) 2021-02-02 15:57:17 +09:00
b3105fb292 Add coverage of local echo messages performing automatic scrolling 2021-02-02 15:46:42 +09:00
3670bd40c2 Add test coverage of user scroll overriding 2021-02-02 15:44:11 +09:00
bb0753f68d Use a better method of cancelling user scroll 2021-02-02 15:44:03 +09:00
398ab9c2c2 Use UserTrackingScrollContainer instead 2021-02-02 15:29:38 +09:00
ed63b571d2 Add "new" override for ScrollToEnd To UserTrackingScrollContainer 2021-02-02 15:16:28 +09:00
44ed705388 Merge pull request #11647 from ppy/dependabot/nuget/Sentry-3.0.1
Bump Sentry from 2.1.8 to 3.0.1
2021-02-02 14:43:06 +09:00
1c645601d4 Fix typo in xmldoc 2021-02-02 14:14:31 +09:00
80d88024d6 Add basic test coverage of CheckValidForGameplay function 2021-02-02 14:13:50 +09:00
0d5353008c Update sentry sdk usage 2021-02-02 13:34:37 +09:00
dcb1626e4d Remove no longer necessary field 2021-02-01 22:38:42 +03:00
216b0d89a7 Bump Sentry from 2.1.8 to 3.0.1
Bumps [Sentry](https://github.com/getsentry/sentry-dotnet) from 2.1.8 to 3.0.1.
- [Release notes](https://github.com/getsentry/sentry-dotnet/releases)
- [Changelog](https://github.com/getsentry/sentry-dotnet/blob/main/CHANGELOG.md)
- [Commits](https://github.com/getsentry/sentry-dotnet/compare/2.1.8...3.0.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-02-01 19:16:51 +00:00
344dc5d6a9 Merge pull request #11644 from ppy/dependabot/nuget/DiscordRichPresence-1.0.175
Bump DiscordRichPresence from 1.0.169 to 1.0.175
2021-02-02 04:15:30 +09:00
5c28c030c8 Unconditionally set "autoscroll" state 2021-02-01 22:08:57 +03:00
15fcabb128 Add documentation to auto-scroll leniency
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-02-01 22:04:44 +03:00
6ec4cf20d3 Merge pull request #11646 from ppy/dependabot/nuget/ppy.osu.Framework.NativeLibs-2021.115.0 2021-02-02 03:20:00 +09:00
57213e6308 Bump DiscordRichPresence from 1.0.169 to 1.0.175
Bumps [DiscordRichPresence](https://github.com/Lachee/discord-rpc-csharp) from 1.0.169 to 1.0.175.
- [Release notes](https://github.com/Lachee/discord-rpc-csharp/releases)
- [Commits](https://github.com/Lachee/discord-rpc-csharp/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-02-01 18:09:07 +00:00
0560676236 Bump ppy.osu.Framework.NativeLibs from 2020.923.0 to 2021.115.0
Bumps [ppy.osu.Framework.NativeLibs](https://github.com/ppy/osu-framework) from 2020.923.0 to 2021.115.0.
- [Release notes](https://github.com/ppy/osu-framework/releases)
- [Commits](https://github.com/ppy/osu-framework/compare/2020.923.0...2021.115.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-02-01 18:09:05 +00:00
9d7bec25da Merge pull request #11651 from ppy/dependabot/nuget/SharpCompress-0.27.1
Bump SharpCompress from 0.26.0 to 0.27.1
2021-02-02 03:07:52 +09:00
286726feb0 Bump SharpCompress from 0.26.0 to 0.27.1
Bumps [SharpCompress](https://github.com/adamhathcock/sharpcompress) from 0.26.0 to 0.27.1.
- [Release notes](https://github.com/adamhathcock/sharpcompress/releases)
- [Commits](https://github.com/adamhathcock/sharpcompress/compare/0.26...0.27.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-02-01 17:44:30 +00:00
c70dd2edfc Merge pull request #11569 from peppy/fix-editor-new-beatmap-crash
Fix a potential crash when exiting the editor before a new beatmap is added to the database
2021-02-01 21:01:51 +09:00
425dc8a210 Ensure mods are always in a valid state at a game level 2021-02-01 20:20:19 +09:00
ead8262257 Add function to check for (and return) invalid mods 2021-02-01 20:20:10 +09:00
b9832c1b2d Add ModUtils class for validating mod usages 2021-02-01 19:37:24 +09:00
328bd191d4 Merge pull request #11561 from Mysfit/fix-storyboard-samples
Fix storyboard samples continuing to play when the beatmap is paused or intro is skipped
2021-02-01 17:48:08 +09:00
49e62c3a4b Apply documentation changes
Co-authored-by: Dean Herbert <pe@ppy.sh>
2021-02-01 11:02:08 +03:00
05982f42ab Add more comprehensive commenting and simplify base call logic
We can call the base method regardless for better safety. Worst case
it's just going to run `Stop()` twice anyway.
2021-02-01 16:43:54 +09:00
25614c7923 Merge pull request #11636 from bdach/fix-time-ramp-calculation
Fix incorrect speed change calculation in time ramp mods
2021-02-01 16:32:44 +09:00
0dd1208579 Merge pull request #11626 from peppy/fix-spinner-spm-negative
Ensure spinners only handle input during their hittable time
2021-02-01 16:27:22 +09:00
e806e5bcd1 Improve robustness of chat auto-scrolling logic
Fix auto-scrolling state changing by old messages removal logic
2021-01-31 23:45:49 +03:00
39d46d21e6 Add failing test case 2021-01-31 23:44:51 +03:00
a0de1cbfd0 Handle no-duration single-object edge case 2021-01-31 21:09:41 +01:00
547b3d8bed Fix speed change calculation in time ramp mods 2021-01-31 20:34:56 +01:00
81b052b866 Add failing test cases 2021-01-31 20:34:22 +01:00
adc57dd94b Merge pull request #11635 from bdach/storyboard-loop-type-decoding
Fix invalid numeric values for storyboard animation type parsing incorrectly
2021-02-01 00:50:22 +09:00
b9a49d5589 Coerce undefined animation loop types to Forever 2021-01-31 15:43:58 +01:00
d7e5a21213 Add failing test case 2021-01-31 15:43:58 +01:00
5f320cd426 Move lease check inside schedule
Theoretically safer due to avoiding a potential data race (change in
`leasedInProgress` between the time of the check and start of schedule
execution).
2021-01-30 21:03:09 +01:00
96f56d1c94 Return tracker lease via UnbindAll()
Improves reliability by being fail-safe in case of multiple returns,
which can happen if the operation tracker is part of a screen being
exited (as is the case with its current primary usage in multiplayer).
2021-01-30 21:00:13 +01:00
0aaa62efc2 Add failing test case 2021-01-30 20:55:56 +01:00
fec3bd898e Merge pull request #11500 from peppy/fix-skin-dropdown-update-crash 2021-01-30 13:34:00 +01:00
6a1387191a Merge branch 'master' into fix-skin-dropdown-update-crash 2021-01-30 13:01:52 +01:00
ae08ef2543 Reset SPM counter state on DHO application 2021-01-29 20:32:45 +01:00
44e88f09e5 Merge pull request #11625 from peppy/fix-beatmap-cache-lookup-null-failure
Fix SQLite exception thrown is a beatmap lookup is attempted without an OnlineBeatmapID present
2021-01-29 18:58:00 +01:00
d521bfc251 Don't directly update HandleUserInput (as it is used by mods) 2021-01-30 02:35:11 +09:00