7b9ed924be
Rename snapping methods
...
Further separates them from `IBeatSnapProvider`'s `SnapTime`, and groups them together more, to prevent confusion between the two interfaces.
Also changes the xmldoc of the reference time to that of `IBeatSnapProvider` for consistency.
2021-04-26 16:07:30 +02:00
049e42fa85
Move snapping responsibility to IBeatmap
...
Seems `EditorBeatmap` already implements a different kind of `SnapTime` from `IBeatSnapProvider`, so method names here aren't great.
This is very similar to what https://github.com/ppy/osu/pull/12558 is doing, so may need to do some duplicate resolution later, especially surrounding `ClosestBeatSnapDivisor`.
Worth noting that this change makes 1/7, 1/5, etc unsupported for now, as we now rely on `BindableBeatDivisor.VALID_DIVISORS`.
2021-04-26 05:07:24 +02:00
e9dfa2860a
Add xmldoc note about path being relative
2021-04-20 13:44:06 +02:00
d7a81471c8
Add xmldoc to GetPathForFile
2021-04-20 13:40:38 +02:00
0e6b66f457
Merge branch 'master' into bg-audio-quality-checks
2021-04-20 02:36:13 +02:00
1478bcfa8e
Improve xmldoc consistency
2021-04-20 02:30:27 +02:00
67e4fe4284
Add xmldoc to GetStream
2021-04-20 02:28:38 +02:00
f168247254
Add Track
as a property to IWorkingBeatmap
...
This is implemented by `WorkingBeatmap` already, and is much better to use than loading the track every time we need it.
2021-04-20 01:35:41 +02:00
d5829fe638
Merge branch 'master' into playlist-unicode
2021-04-19 19:24:04 +02:00
a10a8680d0
Add new display for timing row attributes
2021-04-19 16:23:06 +09:00
38a7c590c4
Make versionString private
2021-04-18 20:57:25 +08:00
646403b826
Fix CI errors
2021-04-18 10:54:42 +08:00
cfaaf2e83e
Add ToRomanisableString()
2021-04-18 09:52:25 +08:00
bf8789528a
Add GetStream
to IWorkingBeatmap
2021-04-18 01:13:57 +02:00
b36da2664c
Add GetPathForFile
to BeatmapSetInfo
...
This is used in several places, and so should probably have a function rather than remaining as duplicated code.
Also applies this together with the previous commit to `BeatmapManagerWorkingBeatmap`.
2021-04-17 17:49:10 +02:00
400f8b3938
Add GetStream
to IWorkingBeatmap
...
This is necessary to obtain the filesize of the audio and background files.
2021-04-17 17:47:13 +02:00
be08b9d1ef
Combine logic of Difficulty and Timing pieces where feasible
2021-04-14 20:55:34 +09:00
a8df2388eb
Update design for TimingControlPoint
2021-04-14 20:11:47 +09:00
b5954a55ad
Remove empty <returns> xmldoc
2021-04-12 17:46:14 +09:00
1dbc7e821e
Merge branch 'master' into add-slider-whistle
2021-04-09 17:11:48 +09:00
9b0ce2999f
Fix legacy encoder
2021-04-09 15:28:42 +09:00
8293b06c0a
Remove obsolete code
2021-04-09 13:56:58 +09:00
dd902441b0
Add tests for consecutive perfect-curve segments
2021-04-06 13:32:17 +02:00
d81f270e21
Always encode perfect curves as explicit segments
2021-04-06 13:29:31 +02:00
a2544100d4
Fix floating point error in slider path encoding
2021-04-06 14:10:59 +09:00
d0510222ae
Fix legacy beatmap encoding
2021-04-05 19:59:54 +09:00
dde255980b
Fix formatting
2021-04-03 12:45:42 +08:00
bd7da9eb39
Make beatmap title use unicode
2021-04-03 12:43:17 +08:00
6d4d574a65
Fix exported replay filenames not having full metadata
2021-04-02 14:10:25 +09:00
4f8edcd336
Don't strip comments from metadata during parsin
2021-03-25 13:35:54 +09:00
a16c0641b2
Revert EF Core to version 2.2
...
This reverts commit f3faad74d5
, reversing
changes made to 712e7bc7bf
.
Several issues arose after migrating to 5.0, including, but possibly not
limited to, performance regressions in song select, as well as failures
when attempting to save beatmaps after metadata changes in the editor.
2021-03-21 11:05:15 +01:00
0195d654ca
Increase the precision of speed multiplier to match osu-stable
2021-03-19 17:09:49 +09:00
53ae24db9b
Merge pull request #12058 from peppy/fix-whitespace-in-ini
...
Fix skin parser not stripping whitespace before parsing
2021-03-18 18:46:28 +09:00
5b0d75ee56
Only trim trailing spaces to avoid breakage in storyboard parsing
2021-03-18 16:30:30 +09:00
bb3c3f302a
Fix skin parser not stripping whitespace before parsing
2021-03-18 15:36:11 +09:00
eda891223c
Start the editor with empty artist/creator/difficulty name fields
2021-03-17 16:47:12 +09:00
f3faad74d5
Merge pull request #12003 from UselessToucan/ef_core_5
2021-03-15 15:05:32 +09:00
6d4c1ba2ae
Fix a couple of new inspections introduced in Rider EAPs
2021-03-15 13:35:08 +09:00
0a1e325fc7
Extract requerying of navigational properties from DbContext
2021-03-14 19:34:53 +03:00
47b80d2474
Workaround InvalidOperation exceptions
2021-03-11 20:51:54 +03:00
b1cd01ceb8
Apply ConfigureAwait changes to game side
2021-03-08 14:36:35 +09:00
103dd4a6ce
Remove WorkingBeatmap's finalizer
2021-03-02 16:14:43 +09:00
46ea0f44eb
Merge branch 'master' into beatmap-difficulty-cache-nullable
2021-02-25 22:52:15 +09:00
5fa9bf61b6
Update xmldoc
2021-02-25 16:22:40 +09:00
03771ce8ec
Allow determining a BeatmapDifficultyCache's bindable return's completion state via nullability
2021-02-25 16:19:01 +09:00
dff1d80f39
Update HasFlag usages to HasFlagFast
2021-02-25 15:38:56 +09:00
dfedea9ea2
Move preview point logic to a specific method in WorkingBeatmap
2021-02-18 14:55:44 +09:00
e7308193e7
Add xmldoc explaining how PreviewTime is intended to work
2021-02-18 13:03:29 +09:00
a080a9bdbc
Merge pull request #11603 from Game4all/handle-stable-imports-custom-songs-folder
...
Handle beatmap import from a stable installation with a custom Songs directory
2021-02-12 21:42:36 +09:00
a1be3c8bfd
Fix header background being invisible in multiplayer/playlists
2021-02-12 15:27:37 +09:00