e3a41f6118
Rename variable to make more sense
...
It needs to be explicitly stated that the users in this list are related
to the *joined* room. Especially since it's sharing its variable name
with `SpectatorStreamingClient` where it has the opposite meaning (is a
list of *globally* playing players).
2020-12-29 14:27:35 +09:00
9155671557
Merge pull request #11341 from peppy/fix-leaderboard-user-handling
...
Fix incorrect null handling in GameplayLeaderboard
2020-12-28 22:44:55 +09:00
2e88036f39
Merge pull request #11342 from bdach/fix-beatmap-not-reverting
...
Fix user changes in multi song select not reverting on exit without confirmation
2020-12-28 21:56:07 +09:00
a376a23ed7
Merge branch 'master' into fix-leaderboard-user-handling
2020-12-28 13:43:53 +01:00
92d74a9343
Fix potential nullref in test scene
2020-12-28 20:48:14 +09:00
fb21b7c016
Add failing test cases
2020-12-28 12:35:16 +01:00
6254907ef9
Move multiplayer leaderboard test to correct namespace
2020-12-28 20:31:08 +09:00
8f0413472c
Add test coverage of null users in scoreboard
2020-12-28 20:30:08 +09:00
20ae84a466
Merge branch 'master' into fix-user-lookup-failure-crashes
2020-12-28 12:15:06 +01:00
046a76cb1d
Allow null users to still be displayed in the participant list
...
The fix here is correcting the access of `user.Country`. The deicision
to have null users display is because this is the best we can do (if
osu-web could not resolve the user). We still want the users in the
lobby to be aware of this user's presence, rather than hiding them from
view.
osu-stable does a similar thing, showing these users as `[Loading]`. I
decided to go with blank names instead because having *any* text there
causes confusion. We can iterate on this in future design updates.
2020-12-28 15:03:44 +09:00
69fab7de77
Merge pull request #11307 from bdach/fix-account-creation-overlay-after-logout
...
Fix account creation overlay not showing up the first time after a log-out
2020-12-28 11:52:48 +09:00
1b7c72f03b
Merge branch 'master' into changelog-refactor
2020-12-28 11:00:14 +09:00
966a2151e3
Ensure the previous leaderboard is removed
2020-12-26 17:55:24 +09:00
2599e95335
Add test coverage
2020-12-26 12:11:19 +09:00
ff57562956
Fix multiplayer leaderboard not unsubscribing from quit users
2020-12-26 11:35:31 +09:00
09b0a57290
Schedule all of setup to avoid headless test fail
2020-12-25 21:06:03 +01:00
c32fc05f69
Improve test scene coverage of corner cases
2020-12-25 21:06:03 +01:00
3ac618778f
Handle all changelog entry types correctly
2020-12-25 21:06:03 +01:00
dacf6d5a34
Decouple changelog test scene from web
2020-12-25 21:06:03 +01:00
4c43a67b68
Rename I{Multiplayer -> OnlinePlay}SubScreen
2020-12-25 18:07:34 +01:00
83fb7c7a1a
Re-namespace all files in OnlinePlay directory
2020-12-25 16:50:09 +01:00
9de1a67e03
Move PlaylistsResultsScreen to correct namespace
2020-12-25 23:47:32 +09:00
836d1491d0
PlaylistsMultiplayer -> Playlists
2020-12-25 23:47:18 +09:00
e421b6d34e
Update some missed variables
2020-12-25 23:36:09 +09:00
3a6a3a067b
Rewrite test to cover failure case
2020-12-25 15:12:37 +01:00
da8365f9d0
Fix other missed cases of changing inheritance
2020-12-25 14:34:47 +01:00
13c38c9b55
Fix tests failing due to wrong inheritance
2020-12-25 14:18:21 +01:00
5d4b73baa5
RealtimeMultiplayer -> Multiplayer
2020-12-25 14:10:59 +09:00
12e4bbdc5b
Reorganise test scenes into playlists specific namespace
2020-12-25 13:20:37 +09:00
a1384942b1
Timeshift -> Playlists at a code level
2020-12-25 13:11:21 +09:00
4e21bd0108
Merge pull request #11286 from peppy/rename-timeshift
...
Rename "timeshift" to "playlists"
2020-12-25 00:45:06 +09:00
6ec045f235
Distinguish primary multi screen titles in header
2020-12-24 16:18:35 +01:00
fa14438671
Merge pull request #11285 from peppy/resort-leaderboard-less
...
Re-sort the leaderboard order a maximum of once a second
2020-12-25 00:05:13 +09:00
3d28a0ccef
Merge pull request #11271 from peppy/dev-server
...
Prefer connecting to dev server when running in DEBUG
2020-12-24 23:01:19 +09:00
d0e8347968
Change asserts into until steps
2020-12-24 22:28:25 +09:00
66a23c22e5
Fix various tests failing due to dependence on specific online data
2020-12-24 21:28:24 +09:00
eb795a2127
Move all endpoint information to a configuration class
2020-12-24 17:58:38 +09:00
c35454081c
Add sound when players change ready state
2020-12-24 17:17:45 +09:00
47020c8887
Add failing test cases
2020-12-23 21:00:47 +01:00
9843da59f4
Fix intermittent test fail due to duplicate user
...
`TestSceneRealtimeReadyButton` was manually adding `API.LocalUser`,
which wasn't actually needed. The base `RealtimeMultiplayerTestScene` by
default creates a new room as `API.LocalUser`, therefore automatically
adding that user to the room - and as such there is no need to add them
manually unless the `joinRoom` ctor param is specified as `false`.
2020-12-23 20:29:17 +01:00
08d87ccb1e
Merge branch 'master' into present-recommended
2020-12-22 23:36:13 +01:00
4a677ecc19
Make random state choice in test more robust
...
`RNG.Next(int, int)` is max-exclusive, so the random state choice would
actually never pick `MultiplayerUserState.Results` on its own. The only
reason why that state ever did show up was by a freak accident of sorts
(the logic in `TestRealtimeMultiplayerClient` would automatically
convert every `FinishedPlay` state to `Results`, up until seeing the
first player that was in the `Playing` state).
2020-12-22 21:49:42 +01:00
23bf9c372c
Fix naming conflict with test scenes
2020-12-22 18:26:39 +09:00
ce806dd880
Replace the ready mark display with a state display, showing all participant states
2020-12-22 18:25:45 +09:00
17d924c755
Move timeshift settings overlay to correct namespace
2020-12-22 15:52:47 +09:00
8201fa8e34
Split out common implementation and private classes in MatchSettingsOverlay
2020-12-22 15:51:24 +09:00
c6be969e33
Remove unnecessary resolved recommender in test
2020-12-22 14:42:12 +09:00
d229fbba6e
Merge branch 'master' into present-recommended
2020-12-22 13:52:29 +09:00
f21b4a269f
Reduce wait length
2020-12-21 18:42:55 +09:00
56bd3d8a82
Add realtime multiplayer test scene
2020-12-21 18:42:31 +09:00
