143e145670
Update implementation of AdjustableAudioComponents
2021-02-18 15:44:23 +09:00
9b5995f2f1
Update with removal of looping parameter
2021-02-12 19:05:17 +09:00
0c3aef8645
Fix potential race in looping sample
...
As mentioned via GitHub comments. Very unlikely for this to happen unless: the sample takes a short amount of time to load, is very short itself, and the update thread stalls until the sample fully completes.
2021-02-12 17:42:35 +09:00
d3f0c0730d
Merge branch 'master' into non-concurrent-sample-playback
2021-02-12 17:22:15 +09:00
3307e8357f
DrawableStoryboardSample event method override for SamplePlaybackDisabledChanged
2021-01-26 00:36:32 -05:00
b692abd3c2
Simplify condition from two to one operand
2021-01-22 20:35:34 +01:00
e0f8f6a23f
introduce overrideable bool instead of copying event logic entirely
2021-01-22 12:09:40 -05:00
5b1bdfbdc5
Use callback method override
2021-01-21 20:06:24 -05:00
b53ad50cd4
Remove redundant variable
2021-01-21 18:00:37 -05:00
07ec0c0e0b
Updated DrawableStoryboardSample to use GetBoundCopy()
2021-01-21 17:46:47 -05:00
b220939650
Fix storyboard samples continuing to play when the beatmap is paused or the intro is skipped.
2021-01-21 17:10:11 -05:00
8ffbcc9860
Fix test failures and general discrepancies
2021-01-20 14:05:35 +09:00
bdb9d4f7d0
Restart sound on play
2021-01-20 13:59:30 +09:00
58269f9314
Update with framework changes
2021-01-20 13:35:43 +09:00
de9d075f94
Initial sample + samplechannel rework
2021-01-19 17:11:40 +09:00
ced7a36788
Update namespaces
2021-01-18 21:24:10 +09:00
707d5346c9
Merge branch 'master' into fix-spinner-spinning-weirdness
2021-01-18 18:26:44 +09:00
94fee8c31d
Avoid doing a config lookup if initial conditional fails
2021-01-18 16:13:58 +09:00
1364de1166
Merge branch 'master' into beatmap-colour-setting
2021-01-18 16:07:46 +09:00
3c1a86d11d
Trim braces for consistency
2021-01-15 22:04:45 +01:00
8a6857f151
Add support for playing a SkinnableSample without restarting it
2021-01-15 17:16:12 +09:00
ebbc32adfa
Change conditional used to decide legacy judgement animation to match stable
...
In stable, the type of legacy judgement to show is based on the presence
of particle textures in the skin. We were using the skin version
instead, which turns out to be incorrect and not what some user skins
expect.
Closes #11078 .
2021-01-15 14:51:27 +09:00
0c01a3a685
Found a better solution than TValue type checking for additional beatmap colour settings. Added unit tests for Catch Beatmap Skin settings.
2021-01-14 23:30:24 -05:00
99e43c77c2
Simplified colour config checks in SkinProvidingContainer.cs
2021-01-14 16:53:55 -05:00
562634dfd2
Improve naming around the config lookup with fallback private method.
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com >
2021-01-13 16:49:14 -05:00
8b95817f7a
Moved SkinProvidingContainer bindable fetching to common method. Replaced redundant test boolean declarations with inline values.
2021-01-13 16:05:46 -05:00
1248d39d7e
Reverted change to AllowConfigurationLookup and added a separate AllowColourLookup bool with config case based on lookup type in SkinProvidingContainer GetConfig call.
2021-01-13 13:07:07 -05:00
7bfb5954a8
Fix whitespace formatting.
2021-01-13 00:25:54 -05:00
5f10bcce02
Added beatmap colour settings checkbox and associated tests.
2021-01-13 00:09:22 -05:00
13ef097a53
Annotate potentially null parameters in protected ctor of LegacySkin
2020-12-22 12:08:40 +09:00
10c2745682
Add region specifications around implicit interface implementations
2020-12-22 12:01:09 +09:00
a5bcf1dc20
Expose resources to skin via interface (and share common pieces with beatmap)
2020-12-21 15:18:52 +09:00
c002184768
Clamp osu!mania's HitPosition offset to match osu-stable implementation
...
Closes #11184 .
2020-12-16 18:08:19 +09:00
ca11eeefdf
Merge branch 'master' into mania-legacyskin-scoreposition
2020-12-14 11:25:34 +09:00
3741c2339a
simplify implementation and adjust the default values
2020-12-13 22:43:36 +06:00
2108844319
apply ScorePosition to the judgement container
2020-12-13 22:01:08 +06:00
b3d8347315
add support for ScorePosition into LegacyManiaSkin
2020-12-10 20:11:08 +06:00
f6d15b9757
Invert back-to-front logic
2020-12-06 18:59:38 +01:00
fcd9483ffa
Merge branch 'master' into fix-multiple-playback-on-skin-change
2020-12-06 18:21:24 +01:00
a0f92628ac
Merge branch 'master' into fix-sample-expire
2020-12-04 13:49:08 +09:00
6c46046c24
Fix DHO expires while hit sound is playing
2020-12-03 12:32:49 +09:00
2c57deea2b
Trim double full-stop in xmldoc
2020-11-30 19:43:20 +01:00
c29ad8edf8
Better API for dealing with the contained drawable samples
2020-11-30 19:26:25 +09:00
f5e8d1d14d
Lose old reference immediately on updateSample()
2020-11-30 19:19:24 +09:00
afb8eb636d
Apply simple PR reviews
2020-11-30 18:40:22 +09:00
4bbeb9ebd4
Merge branch 'master' into hit-sample-pooling
2020-11-30 18:31:58 +09:00
1c31a4a6b6
Expose animation start time as mutable in interface
2020-11-22 13:11:22 +01:00
a3b1d14f17
Apply similar fix to PoolableSkinnableSound
2020-11-22 14:44:39 +09:00
240c1b0aef
Add support for changing animation start time after load
2020-11-21 20:06:30 +01:00
8080fe942c
Fix samples being played more than once on skin change
2020-11-20 20:38:26 +09:00
