Commit Graph

244 Commits

Author SHA1 Message Date
a633501687 Change FilterTerms to use LocalisableString 2022-05-16 14:09:37 +09:00
81be69e72e Update search textbox implementation to use BasicSearchTextBox instead 2022-05-03 06:18:42 +07:00
401cf2a955 Allow pausing game-wide audio via hotkey as long as LocalUserPlaying is not set
`Player` seems to handle this correctly locally already, which is to say
if the user attempts to toggle the pause state incorrectly, it will
still recover.

The logic stoppic this operation was only in the key binding handler,
which meant it was already possible from the now playing overlay this
whole time, so I *think* this should be quite safe.
2022-02-24 16:00:14 +09:00
c242a63b11 Fix playlist overlay null reference when attempting an empty selection
As reported at https://github.com/ppy/osu/discussions/16829.
2022-02-09 10:16:45 +09:00
b3f2392358 Resolve compilation error due to removed method 2022-01-26 19:04:18 +09:00
9532454e2a Remove ILive remnants 2022-01-26 15:12:07 +09:00
dda513dd08 Change PlaylistOverlay to use ILive 2022-01-26 12:19:59 +09:00
64914c45a4 Remove unnecessary realm query helper method 2022-01-26 11:53:50 +09:00
1a776a9587 Completely remove subscription from MusicController 2022-01-25 16:53:02 +09:00
2a786f9ec0 Load text only after it comes on screen (and tidy up selection handling logic) 2022-01-25 16:51:21 +09:00
ace2bd2208 Apply some initial optimisations to PlaylistItem 2022-01-25 16:51:21 +09:00
8a4f3a7ce0 Reimplement subscription logic in PlaylistOverlay directly 2022-01-25 16:51:21 +09:00
8ce5324c8b Merge pull request #15772 from peppy/remove-model-list-inits
Initialise `BeatmapSet.Beatmaps` list at construction time
2021-11-24 16:41:19 +09:00
a7853fc9cc Fix cases of known-non-null 2021-11-24 14:26:25 +09:00
729f681938 Update cases where equality can be used instead of primary key equality 2021-11-24 12:49:57 +09:00
3de8125eac Update UI cases where repeat should not be handled 2021-11-18 13:13:36 +09:00
68e2699043 Fix oversight in playlist matching logic 2021-11-16 12:35:18 +09:00
a4c11e8813 Use extension method to compare online IDs 2021-11-15 14:34:50 +09:00
494d582830 Fix PlaylistItem attempting to read from OsuColour dependency too early 2021-11-02 23:19:45 +01:00
d218e7d935 Remove manual romanisation handling in PlaylistItem 2021-11-02 21:42:02 +01:00
98367fc482 Update usages of GetLocalised{-> Bindable}String 2021-11-02 21:42:01 +01:00
6f863ca204 Adjust game-side text flow containers to part-based model 2021-10-29 06:34:08 +02:00
2c979d6420 Merge branch 'master' into localise-toasts 2021-10-20 15:04:07 +09:00
80da153697 Recolour a few other existing dropdowns with same hover & selection colours 2021-10-19 22:47:18 +02:00
ef03787fe0 Split dropdown accent colour into hover and selection colours 2021-10-19 22:09:51 +02:00
4fc84e71cd Localise more toast related strings 2021-10-11 01:02:26 -07:00
7b37b15976 Localise some music action toasts 2021-10-10 19:36:50 -07:00
d3b9660148 Move common interface implementations to extension methods 2021-10-05 14:41:14 +09:00
f9d5abff8a Update with keybinding changes 2021-09-16 18:26:12 +09:00
e82eaffaed Flip order back to original for romanisable strings 2021-02-25 14:14:07 +09:00
8a97e2e28d Update LocalisedString usages to RomanisedString 2021-02-22 19:01:42 +09:00
1fd4b04767 Just set music shortcut text locally 2020-11-23 20:43:46 -08:00
52f5473cc0 Set global action as a parameter in toast 2020-11-23 15:13:58 -08:00
2071cba944 Add music bindings to on screen display 2020-11-13 13:16:36 -08:00
61e62929ee Apply changes in line with framework event logic update 2020-10-01 13:06:01 +09:00
b047fbb8ee Use bindable value for search text 2020-09-11 17:46:07 +09:00
6327f12fe4 Disable manage collections item in now playing overlay 2020-09-11 16:58:18 +09:00
fcc8683629 Hook up now playing overlay to collections 2020-09-11 16:46:11 +09:00
186507a88e Merge branch 'fix-music-controller-regressed' into fix-toggle-pause-state 2020-09-08 18:37:52 +09:00
ad5d6117c7 Remove unnecessary RunTask calls 2020-09-08 18:26:13 +09:00
14bf2ab936 Fix grammar in xmldoc 2020-09-08 18:21:26 +09:00
a46be45a71 Fix OSD occasionally display incorrect play/pause state 2020-09-08 18:12:03 +09:00
b1110e5e3a Rename class to match derived class 2020-09-08 18:10:14 +09:00
33b76015d8 Fix MusicActionHandler unnecessarily depending on OnScreenDisplay's existance 2020-09-06 01:54:32 +03:00
001509df55 Move music global action handling to an own component
Due to requiring components that are added at an OsuGame-level
2020-09-04 10:24:54 +03:00
f65991f31f Revert some usages based on review feedback 2020-08-26 23:28:58 +09:00
5002d69f69 Update inspections 2020-08-07 20:51:56 +09:00
0f7fde5d2c Revert unnecessary change 2020-08-06 16:24:14 +09:00
6e42b8219c Move track to MusicController, compiles 2020-08-06 16:24:14 +09:00
0e2ccac33b Add spaces to comments 2020-05-04 18:36:24 -07:00