Commit Graph

3026 Commits

Author SHA1 Message Date
5a591713ae Fix legacy combo counter not fully hiding for rulesets that implement their own 2021-12-26 16:49:20 +01:00
a43cc20ae2 Apply changes to GameplayCompleted from reviews 2021-12-24 21:58:20 +09:00
727335dcad Improve reliability of exiting gameplay 2021-12-24 14:23:09 +09:00
98f044881e Merge branch 'master' into refactor-diffcalc 2021-12-22 12:31:28 +09:00
cca02a8016 Create PerformanceAttributes 2021-12-21 13:08:31 +03:00
88d4e95ad8 Rename BeatmapCard{ => Normal} 2021-12-21 08:26:21 +01:00
edcbd4de6d Fix incorrect event unbind logic 2021-12-21 13:05:26 +09:00
52db7b36fc Move Schedule call to base implementation of error meter for extra safety 2021-12-21 12:55:21 +09:00
28d6ff5d9c Fix potential wrong thread mutation in ColourHitErrorMeter 2021-12-21 12:36:04 +09:00
ef4ab74565 Also only expose Expanded state of BeatmapCard as read-only 2021-12-15 16:26:19 +09:00
7e576ae9d3 Add note about how the background colour is restored 2021-12-14 13:25:19 +09:00
cac684c044 Improve appearance of player-wide background after failing with low background dim 2021-12-13 14:53:11 +09:00
f7c5a3f506 Use similar method of consuming OnlineID as done in beatmap classes 2021-12-10 18:34:31 +09:00
dbb08f7d46 Use OnlineID for set operations 2021-12-10 16:11:48 +09:00
bf1418bafc Use OnlineID instead of legacy IDs for equality and lookups 2021-12-10 16:11:48 +09:00
35a208a478 Merge pull request #15999 from peppy/restore-user-volume-muted-notification
Fix the unmute notification potentially overwriting user's volume levels unnecessarily
2021-12-10 02:58:59 +09:00
a3b53ac2f6 Change comparison to match in all locations 2021-12-09 18:58:47 +09:00
65a09692da Merge pull request #16001 from peppy/fix-own-rank-results-panel-in-multiplayer
Fix the local user's rank not showing on multiplayer/playlist results screen
2021-12-08 16:34:36 +09:00
872e0884c0 Fix the local user's rank not showing on multiplayer/playlist results screen
Applying the simple solution for now. Not sure how this will evolve over
time, but seems sane enough.
2021-12-08 15:22:10 +09:00
6ec3f41839 Fix LegacyComboCounter not handling non-default anchor/origin specifications correctly 2021-12-08 15:07:15 +09:00
0775053a18 Fix the unmute notification potentially overwriting user's volume levels unnecessarily
I've also changed the cutoffs to 5% rather than zero, as this seems like
a saner method of showing this dialog. With levels 5% or less, the game
is basically inaudible.

Arguably, the cutoff can be increased to 10%.
2021-12-08 13:38:43 +09:00
af35652b8b Disable beatmap card expansion on solo spectator screen 2021-12-05 20:07:58 +01:00
38702beabf Merge branch 'master' into i-ruleset-store 2021-12-04 15:05:39 +01:00
4145a16d5b Merge pull request #15920 from peppy/clean-up-unused-resolves
Clean up unused resolved properties
2021-12-03 20:08:48 +09:00
1eed2436e6 Clean up unused resolved properties 2021-12-03 18:49:49 +09:00
2acf46154a Remove many unused resolutions of RulesetStore 2021-12-03 18:16:29 +09:00
6b73672403 Stop Player from blocking volume adjust when Alt it held
Similar case to what we already have in `OsuScrollContainer`, so there
is precedent for handling this locally in this fashion.
2021-12-03 17:18:07 +09:00
a188d6662f Use beatmap card in solo spectator screen 2021-11-25 22:31:02 +01:00
716543b5b3 Move beatmap download logic out of BeatmapManager 2021-11-25 17:29:41 +09:00
bbd3ea5b77 Update all actual usages of RulesetInfo.ID to use OnlineID instead 2021-11-24 15:50:26 +09:00
6100bf66a6 Clean up cancellation handling in WorkingBeatmap
After the recent changes introducing cancellation support to
`WorkingBeatmap`, it turned out that if the cancellation support was
used, `GetPlayableBeatmap()` would raise timeout exceptions rather than
the expected `OperationCanceledException`.

To that end, split off a separate overload for the typical usage, that
catches `OperationCanceledException` and converts them to beatmap load
timeout exceptions, and use normal `OperationCanceledException`s in the
overload that requires a cancellation token to work.
2021-11-20 17:23:55 +01:00
6ebe54b183 Merge pull request #15494 from Tollii/beatmap-cancellation-token
Add support for cancellation tokens for beatmap difficulty calculation
2021-11-19 10:54:32 +09:00
66c307e0ee Remove usage of key repeat helper method 2021-11-18 13:13:36 +09:00
3de8125eac Update UI cases where repeat should not be handled 2021-11-18 13:13:36 +09:00
8b134914cf Merge branch 'master' into beatmap-cancellation-token 2021-11-17 21:52:30 +01:00
7c2e79f911 Update all simple cases of switching to IWorkingBeatmap 2021-11-17 20:56:57 +09:00
0715d40ea0 Merge branch 'master' into beatmap-cancellation-token 2021-11-17 11:16:10 +09:00
13f3e2eea9 Add back default timeout to GetPlayableBeatmap 2021-11-17 11:06:31 +09:00
6cca657a2d Standardise naming of CancellationToken parameters 2021-11-16 14:45:51 +09:00
53c0682a08 Merge branch 'master' into beatmap-cancellation-token 2021-11-16 14:43:13 +09:00
369b4ba789 Update DifficultyCalculator to take an IRulesetInfo 2021-11-15 19:16:48 +09:00
a4aa008793 Fix frequency ramping a second time incorrectly after fail 2021-11-14 14:41:17 +09:00
b47c0b63f4 Tweak loader transition when testing gameplay in editor 2021-11-13 13:39:18 +01:00
d2d66766d4 Merge branch 'master' into songselect-audio-improvements 2021-11-12 19:40:04 +09:00
338e5a78b8 Adjust easing of logo to better match the sound
I'm sure we can come up with something better, but giving it a bit more
speed definitely feels closer to what the sound is portraying.
2021-11-12 19:30:35 +09:00
692e846acd Rename BeatmapSetInfo.OnlineBeatmapSetID to OnlineID to match interface 2021-11-12 17:52:44 +09:00
6a098a8634 Rename BeatmapInfo.OnlineBeatmapID to OnlineID to match interface 2021-11-12 17:46:24 +09:00
759450502f Merge branch 'master' into pp-counter-fixed-width 2021-11-12 08:05:56 +01:00
113c95f3f5 Only apply high-pass temporarily 2021-11-12 14:22:43 +09:00
b9f9c27770 Standardise spacing and padding between UR and PP counters 2021-11-12 13:59:22 +09:00