Commit Graph

37786 Commits

Author SHA1 Message Date
8fdab5a7de Revert legacy spinner presence changes and bonus counter component
No longer necessary, after inlining legacy coordinates logic to `LegacySpinner` and limiting precisely-positioned legacy components there
2021-03-13 05:57:47 +03:00
020a03e01e Use sensible "score per tick" constant 2021-03-13 05:56:28 +03:00
c4048c9831 Merge branch 'master' into legacy-spinner-bonus 2021-03-13 05:54:34 +03:00
62f2a823f6 Hide toolbar forever when the user hides it 2021-03-12 15:48:50 -08:00
6c0734a09f Handle global action in toolbar instead of osugame 2021-03-12 15:48:49 -08:00
d0644221ff Add test showing toolbar behavior change 2021-03-12 15:48:49 -08:00
9b5e35565b Merge pull request #11975 from frenzibyte/legacy-spinner-placements
Adjust legacy spinner components placements to match osu!stable
2021-03-12 23:12:43 +09:00
e3813ab828 Merge branch 'master' into legacy-spinner-placements 2021-03-12 19:47:34 +09:00
86164c027a Update the method we use to reset input settings 2021-03-12 18:44:10 +09:00
3458dcc33a Use whitelist to avoid exposing settings to user that shouldn't be 2021-03-12 18:40:38 +09:00
03230edcb1 Update bindings settings to handle the new structure and show all handlers 2021-03-12 18:38:16 +09:00
8635abbc4a Add the ability to not get controls for disabled bindables 2021-03-12 18:37:55 +09:00
3c21c83cc8 Rename KeyboardSection to BindingSection 2021-03-12 18:36:28 +09:00
6eadae8aaf Remove remnants of OsuTK 2021-03-12 18:35:42 +09:00
4374e7da81 Convert bindable names to human readable sentences 2021-03-12 18:34:22 +09:00
a33ffd56b8 Allow CreateSettingsControls to work with all bindables in target class 2021-03-12 18:34:22 +09:00
b9b095ee75 Local framework 2021-03-12 18:34:22 +09:00
6e7bb87977 Merge pull request #12005 from peppy/fix-settings-reset-button-tooltips
Switch RestoreDefaultsValueButton to use HasPendingTasks to avoid tooltip always showing
2021-03-12 16:06:38 +09:00
e7707eee94 Switch RestoreDefaultsValueButton to use HasPendingTasks to avoid tooltip always showing 2021-03-12 15:23:11 +09:00
a60ff80c04 Use expression body in ModsJson get accessor 2021-03-12 00:02:29 +03:00
5a4b0174b1 Ignore MultipleCollectionIncludeWarning 2021-03-11 22:40:35 +03:00
d2f943395d Hotfix importing scores from stable 2021-03-11 22:12:47 +03:00
c6c616f244 Actualize tests 2021-03-11 21:02:40 +03:00
47b80d2474 Workaround InvalidOperation exceptions 2021-03-11 20:51:54 +03:00
f1302d1600 Update Microsoft.EntityFrameworkCore 2021-03-11 19:23:56 +03:00
d8db29de35 Merge pull request #11990 from peppy/fix-storyboard-alpha-start-time-woes
Fix storyboard commands occurring before the earliest point of visibility delaying gameplay
2021-03-12 00:07:23 +09:00
023af75cc3 Merge branch 'master' into fix-storyboard-alpha-start-time-woes 2021-03-11 22:09:56 +09:00
99ef5077c2 Merge pull request #11992 from peppy/fix-spm-during-fade-out
Fix SPM counter immediately disappearing/decreasing after spinner has already been completed
2021-03-11 22:04:35 +09:00
ea9b48d17d Remove unused using 2021-03-11 21:21:48 +09:00
b5bdf235ca Slightly improve comments more 2021-03-11 21:21:44 +09:00
8bc494b224 Adjust explanatory comments 2021-03-11 20:57:00 +09:00
1591d593e2 Move spin start time to inside result and switch to standard state handling 2021-03-11 12:58:15 +09:00
efb4a366d4 Fix xmldoc explaining incorrect behaviour
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-03-11 12:15:59 +09:00
3f34981664 Fix incorrect spinner top offset calculation with clarification 2021-03-11 05:40:20 +03:00
f6baf49ad6 Merge pull request #11989 from peppy/fix-ios-builds
Fix iOS release build crashes
2021-03-09 18:34:32 +09:00
4e8bcc9265 Fix SPM counter decreasing after spinner has already been completed 2021-03-09 16:54:46 +09:00
5a6864eb78 Fix SPM counter immediately disappearing on completion of spinners 2021-03-09 16:54:46 +09:00
8aaba32431 Fix storyboard commands occurring before the earliest point of visibility delaying gameplay
In osu-stable, storyboard intros start from the first command, but in
the case of storyboard drawables which have an initial hidden state, all
commands before the time at which they become visible (ie. the first
command where `Alpha` increases to a non-zero value) are ignored.

This brings lazer in line with that behaviour. It also removes several
unnecessary LINQ calls.

Note that the alpha check being done in its own pass is important, as
it must be the "minimum present alpha across all command groups,
including loops". This is what makes the implementation slightly
complex.

Closes #11981.
2021-03-09 15:55:12 +09:00
a5b3ac7ef8 Add failing test covering alpha commands proceeding non-alpha (but ignored) commands 2021-03-09 15:54:11 +09:00
296afd2d17 Merge pull request #11971 from bdach/taiko-judgement-pooling
Enable pooling for taiko judgements
2021-03-09 15:17:24 +09:00
0549395869 Inline "legacy coordinates container" and add "spinner Y centre" const 2021-03-09 08:55:32 +03:00
dc9028d24a Update framework 2021-03-09 14:27:29 +09:00
bb79da1aac Correct playfield shift counteract comment
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-03-09 00:34:00 +03:00
9b5d11f2a5 Merge pull request #11958 from bdach/ruleset-filter-v3
Allow rulesets to specify custom song select filtering criteria
2021-03-08 23:23:24 +09:00
d90cf532ea Merge pull request #11986 from peppy/configure-await-false
Use ConfigureAwait(false) for all async calls
2021-03-08 22:58:10 +09:00
ff2327ffac Merge branch 'master' into configure-await-false 2021-03-08 22:24:29 +09:00
f15ee813c2 Merge pull request #11985 from peppy/ios-signalr-workaround
Fix multiplayer/spectator not working on iOS
2021-03-08 16:32:51 +09:00
02194a93cb Apply missing additions to android project 2021-03-08 15:22:03 +09:00
6cb0db9c33 Apply override rules to iOS/Android test projects 2021-03-08 14:54:49 +09:00
d2bc48e576 Exclude tests from ConfigureAwait rule 2021-03-08 14:36:35 +09:00