Commit Graph

11096 Commits

Author SHA1 Message Date
3d42973764 Allow scrolling via drag while dragging a hold note handle 2020-02-05 18:35:31 +09:00
cef45afbc8 Add a simple hover state 2020-02-05 18:35:31 +09:00
d56accaef1 Disallow negative / zero repeat counts (and fix off-by-one) 2020-02-05 18:35:31 +09:00
d04cc0123d Initial implementation of timeline blueprint dragbars 2020-02-05 18:35:31 +09:00
96986bf5fc Remove beat divisor from ctor and use DI instead 2020-02-05 17:48:21 +09:00
63c595ed97 Make EditorBeatmap a component and move UpdateHitObject to it 2020-02-05 17:48:21 +09:00
27c24fb08a Merge pull request #7721 from recapitalverb/display-accuracy
Add {ScoreInfo,UserStatistics}.Accuracy
2020-02-04 16:16:33 +09:00
0e3c1ed0f7 Merge branch 'master' into fix-key-counter-visible-on-reshowing-hud 2020-02-04 14:06:23 +09:00
79bb476f4c Merge branch 'master' into display-accuracy 2020-02-04 11:39:47 +07:00
3600b0daf0 Merge branch 'master' into fix-mod-select-overflowing 2020-02-04 11:57:54 +09:00
22e3150f68 Fix comment and remove magic numbers 2020-02-03 17:21:06 -08:00
4cd4055e7c Rename to AlwaysVisible and add XMLDoc 2020-02-03 20:00:43 +03:00
51ed289c59 Revert namings and behaviour changes 2020-02-03 19:59:58 +03:00
9898a926b2 Use ScoreInfo.DisplayAccuracy everywhere 2020-02-03 22:11:36 +07:00
351cb8ac1a Rename Visible to HasReplayLoaded and change default value
Doesn't make sense to be true by default
2020-02-03 15:47:52 +03:00
443063263e Merge remote-tracking branch 'upstream/master' into fix-key-counter-visible-on-reshowing-hud 2020-02-03 15:18:25 +03:00
c6e7603e5e Merge branch 'master' into safe-screen-lease 2020-02-03 18:18:13 +09:00
93952d438f Merge pull request #7677 from peppy/decouple-mod-select-bindable
Decouple ModSelectOverlay from global SelectedMods
2020-02-03 16:27:47 +09:00
591c7b6250 Merge pull request #7682 from peppy/fix-timeline-tick-overrun
Fix too many ticks being displayed on beatmaps with multiple timing sections
2020-02-03 16:16:23 +09:00
9183c78319 Fix crash on exiting song select with ctrl-enter autoplay 2020-02-03 16:04:32 +09:00
4cdf4b223c Rename to alwaysShow and add XMLDoc 2020-02-02 18:47:12 +03:00
28e340c486 Inherit Container and fade the key flow instead of individual children 2020-02-02 18:46:27 +03:00
aa1daa0ad5 Merge pull request #7703 from bdach/beatmap-stats-precision
Apply precision when determining bar colour in difficulty statistics
2020-02-02 22:31:52 +09:00
6a11c3a8f9 Expose ConfigVisibility bindable for testing purposes 2020-02-02 14:48:07 +03:00
abccf05155 Update visibility of each key counter instead of this container
For isolating changing visibility of the key counter display based on config and internal values from just fading the container.
2020-02-02 14:47:14 +03:00
434c0d92e4 Use Bindable{Float,Double}s everywhere
To avoid further floating-point comparison bugs, remove all usages of
Bindable<{float,double}>, replacing them with their
Bindable<Float,Double> counterparts.
2020-02-01 22:50:29 +01:00
e894acf53c Make star filter range bindables BindableDoubles
Due to using Bindable<double>s previously, song select's filter control
would not apply tolerance when checking IsDefault, therefore wrongly
hiding maps with star ratings above 10.1.
2020-02-01 22:48:46 +01:00
609ee26030 Fix mod select overlay not showing up in test 2020-02-01 11:41:41 -08:00
2d42a83bb9 Fix mod select overlay overflowing toolbar at max ui scale 2020-02-01 11:24:29 -08:00
0bfadfbbf1 Apply precision when comparing adjusted values
In some cases, applying the Difficulty Adjust mod without actually
changing any of the settings previously caused the bar in song select
beatmap details to appear red/blue instead of staying white.

This was caused by not accounting for floating-point imprecisions when
determining bar colour in AdvancedStats. To resolve, first check
equality with tolerance, and only then apply blue/red colours if that
equality check does not hold.
2020-02-01 16:16:15 +01:00
a74d22d9e5 Extract beatmap stats test to separate scene 2020-02-01 15:50:33 +01:00
ed368e44ea Merge branch 'master' into safe-screen-lease 2020-02-01 02:11:18 +09:00
c5422743e2 Merge branch 'master' into decouple-mod-select-bindable 2020-02-01 02:06:23 +09:00
90caa61245 Reverse comparison for readability
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2020-02-01 02:05:26 +09:00
a66cdee5e9 Fix missed issues 2020-01-31 21:36:19 +09:00
19f516e710 Ensure OsuScreen level leases are taken out synchronously 2020-01-31 19:10:44 +09:00
a547d2ed5c Don't least at Player just yet 2020-01-31 18:37:16 +09:00
2f61d3f5ad Fix song select remaining issue locally 2020-01-31 17:35:53 +09:00
5f48affcba Centralise screen exit logic to ScreenTestScene 2020-01-31 14:19:29 +09:00
2952fc8cc4 remove unused using 2020-01-31 09:05:13 +08:00
b916366536 fix formatting 2020-01-31 08:17:39 +08:00
2274d70dac apply suggestions 2020-01-31 06:41:50 +08:00
f51cfa2220 Fix too many ticks being displayed on beatmaps with multiple timing sections
Closes https://github.com/ppy/osu/issues/7681.
2020-01-31 00:24:00 +09:00
7bf2e9b369 Decouple ModSelectOverlay from global SelectedMods 2020-01-30 17:38:15 +09:00
09f6c57b0f Merge branch 'master' into fix-import-different-ruleset 2020-01-30 15:08:25 +09:00
c18b1b302c Merge branch 'master' into editor-match-accessibility 2020-01-30 13:49:56 +09:00
0d3ccae1c2 Merge branch 'master' of https://github.com/ppy/osu into linkify-metadata 2020-01-30 12:31:17 +08:00
c5995acfff linkify metadata 2020-01-30 12:30:25 +08:00
c158570249 Fix typo in comment
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2020-01-30 11:31:34 +09:00
f72de235cc Remove unnecessary length specifications 2020-01-30 11:00:14 +09:00