Commit Graph

23 Commits

Author SHA1 Message Date
f381bc9115 Add explanatory comment 2022-08-17 19:03:48 +09:00
b33e0f5e1c update comment and deltaTime check 2022-08-16 11:03:18 +08:00
4fdbf3ff24 individualStrain should be the hardest individualStrain column for notes in a chord 2022-07-14 15:07:58 +08:00
2b42dfb9cb apply individualStrain decay only when a note appears in that column 2022-06-28 20:32:35 +08:00
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
26985ca8af Store hitobject history in the hitobject 2022-05-22 16:26:22 +01:00
6cca56ab77 Move release_threshold to const 2022-04-23 10:46:12 +08:00
8b55d3855a Use isOverlapping bool to determine holdAddition 2022-04-22 13:27:59 +08:00
56bbfa58e5 Add missing absolute value of closestEndTime 2022-04-22 13:01:41 +08:00
97b4a2a105 Use better initial value for closestEndTime 2022-04-22 12:59:00 +08:00
574007c07a Optimise holdAddition calculation 2022-04-22 02:02:23 +08:00
e7a149af6c Use curve for holdAddition validity cutoff 2022-04-21 23:05:20 +08:00
a0a83fb51f Use closest endTime for holdAddition validity 2022-04-21 23:03:28 +08:00
6944151486 Apply batch fixing of built-in types using var 2021-10-27 13:04:41 +09:00
176b3e7533 changed decay system to allow for customizing the currentStrain 2021-08-16 22:14:29 +00:00
85d2b1232a Refactor to abstract out strain logic into StrainSkill class
While it is the case for the existing official Skills, Skill implementations shouldn't be required to conform to a strain based approach.
There are other valid approaches to calculating skill difficulty that can be supported by abstracting the strain logic into its own StrainSkill class.
2021-04-03 20:52:39 +11:00
5b2dcea8a8 Refactor to encapsulate strain logic into Skill class
As strains are an implementation detail of the current Skill calculations, it makes sense that strain related logic should be encapsulated within the Skill class.
2021-04-03 20:47:43 +11:00
8438fce764 Merge branch 'master' into diffcalc/fix/clockrate-adjusted-decay 2021-03-26 11:47:38 +09:00
66643a97b0 Add a list of mods to Skill class
Although this isn't necessary for existing official rulesets and calculators, custom calculators can have use cases for accessing mods in difficulty calculation.
For example, accounting for the effects of visual mods.
2021-02-20 20:37:44 +11:00
442347df8e Fix clockrate adjusted difficulty calculations bug in strain decay
When starting a new section, the starting strain value was calculated using the unadjusted timing value, meaning decay curves were essentially being stretched or squashed according to the clockrate.

This caused incorrect strain peaks for any section where the peak occurs at the start of the section (none of the objects in the section added enough strain after decay to exceed the starting strain).

This bug caused star ratings with clockrates above 1 to be lower than they should and below 1 to be higher than they should.
2021-02-20 20:23:49 +11:00
5017c92fe8 Combine mania skills 2020-10-09 21:47:34 +09:00
ddb2cfc46d Use GetEndTime in Taiko and Mania 2019-12-14 18:16:13 +08:00
68725dc005 Implement new difficulty calculator for Rulesets.Mania 2019-02-18 15:00:20 +09:00