24c27e62f6
Remove nullable disable annotation in the issue and issue template-related class.
2022-10-30 16:25:15 +08:00
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
19800f5f7f
Move IBeatmap
arg into context
2021-05-13 11:24:22 +02:00
b7bc42e0d3
Rename "playableBeatmap" check arg to "beatmap"
...
The working beatmap is now in the context, so it's easier to distinguish beatmap type, hence no need for this prefix.
2021-05-12 02:34:16 +02:00
c13b93e6f1
Replace IWorkingBeatmap
arg with BeatmapVerifierContext
in checks
...
This simplifies passing of contextual information by enabling addition without needing to refactor lots of classes.
See next commit for example.
2021-05-12 02:29:18 +02:00
75adec57eb
Remove negligible default hidden TODO
2021-05-12 01:31:16 +02:00
8656176ab8
Add the playable beatmap as check argument
...
This is different from the working beatmap's `.Beatmap` property in that it is mutated by the ruleset/editor.
So hit objects, for example, are actually of type `Slider` and such instead of the legacy `ConvertSlider`.
This should be preferred over `workingBeatmap.Beatmap`.
2021-04-20 01:31:51 +02:00
56bf49c85c
Take IWorkingBeatmap
instead of WorkingBeatmap
...
This makes testing much easier, and allows for checking of any class deriving from that interface, including `WorkingBeatmap`.
2021-04-18 01:21:20 +02:00
448574e7e6
Use WorkingBeatmap
instead of IBeatmap
...
This lets us access things like the background, track, etc. which are necessary for quality and filesize checks.
Also improves the structure of the `CheckBackgroundTest` class in the process.
2021-04-17 17:33:53 +02:00
cb4f64133e
Add xmldoc to interfaces
2021-04-13 23:30:20 +09:00
6d3f9fa9ce
Use is
class instead of Equals
with template index
...
Ensures ordering of `PossibleTemplates` does not affect tests.
2021-04-13 02:29:25 +02:00
d8088777ea
Add Equals
method to IssueTemplate
...
This will be useful in tests.
2021-04-13 01:21:34 +02:00
6d50d01186
Make IssueTemplate.Check
readonly
2021-04-12 16:23:05 +02:00
caaaba5950
Rename Check
-> ICheck
2021-04-12 16:20:53 +02:00
008dbc7dd6
Reverse IssueType
ordering
...
Reversed both in the enum and where it's displayed, so ends up the same in the end.
2021-04-12 15:49:13 +02:00
7c4f6d2b62
Rework template usage
...
Includes moving the origin check back to templates, constructing nested template classes in each check, and making parameterized template usage.
2021-04-12 15:47:26 +02:00
65ebdd8f7a
Move check origin from IssueTemplate
to Issue
...
As a result we can also make check an interface, and need to provide the check itself when constructing an issue.
2021-04-12 10:08:08 +02:00
8bf85d737c
Change Metadata into a get property
2021-04-12 15:52:29 +09:00
78bbc8f5c8
Tidy some remaining code
2021-04-12 15:52:18 +09:00
8c31e96cdf
Change some methods to get properties
2021-04-12 15:52:18 +09:00
f78239c7f2
Move enums out of nesting
2021-04-12 15:52:18 +09:00
3551322f1d
Fix formatting of colour getter
2021-04-12 15:52:18 +09:00
257acf9cd8
Colour constants to private
2021-04-12 15:52:18 +09:00
136627b9ac
Wrap xmldoc less and make a few fixes
2021-04-12 15:52:18 +09:00
3289bb0379
Merge Check
and BeatmapCheck
...
We're probably not going to need GeneralChecks or BeatmapsetChecks.
The verify tab is only available to a single difficulty at a time, and we already have access to the rest of the set through `IBeatmap`.
2021-04-10 14:56:30 +02:00
d1007ff26a
Move components to more appropriate spot
2021-04-10 13:02:22 +02:00