Commit Graph

7760 Commits

Author SHA1 Message Date
9b45591c2f Add failing test coverage of saving failed replay causing progression to results 2023-03-29 14:00:11 +09:00
d31b37e87e Merge branch 'master' into fix-ubo-not-bound 2023-03-26 16:14:11 +09:00
e1906a90eb Use image@2x from tournament banner api 2023-03-25 13:08:46 -07:00
ad5bdf6511 Merge branch 'master' into fix-ubo-not-bound 2023-03-22 16:46:39 +09:00
9ff9cd3b7f Merge branch 'master' into skin-editor-cyclic-selection 2023-03-21 19:49:55 +01:00
fb51221c2b Add test coverage of cyclic selection triggering when more than one item is selected 2023-03-21 21:31:10 +09:00
678e8ed736 Update UBO usages inline with framework changes 2023-03-16 14:06:35 +03:00
556964eae0 Merge branch 'master' into BitmapUpdatesOnScore 2023-03-16 12:16:42 +03:00
1cf870d956 Add test coverage and fix fail case where a drag selection ends incorrectly with cyclic selection 2023-03-15 15:16:48 +09:00
3c4e2d8700 Add tests covering drag selection 2023-03-14 21:04:51 +09:00
969c0e9c9d Merge branch 'master' into veldrid-renderer 2023-03-14 17:35:38 +09:00
d2fcdf6e0e Add test coverage of cyclic selection in skin editor 2023-03-07 15:11:47 +09:00
ec15e2b9cc Merge branch 'master' into dont-filter-results-on-sort-mode 2023-03-06 17:57:47 +01:00
9d4bb2ecf7 Add failing test coverage for clearing sidebar contents 2023-03-04 14:08:50 +01:00
2f25fb4083 Move NonSkinnableScreenPlaceholder to outer scope 2023-03-04 13:22:43 +01:00
3dd3b5e77a Add failing test case 2023-03-04 13:17:54 +01:00
a14dede036 Ensure TestBeatmapCarousel.Items only returns actually visible items (and in correct order)
Turns out that items could be in an order that isn't the same as how
things look on the carousel, so this change ensures that for testing
purposes they are sorted by Y position.

Also uses the `CarouselItem.Visible` flag to ensure that we don't have
to wait for drawable fade transitions after a filter operation.
2023-03-03 17:18:34 +09:00
7a092ea995 Add better coverage and more comments explaining the structure of test setup 2023-03-03 17:18:14 +09:00
82293c0c86 Don't filter away results with missing data when using "Date Submitted" or "Date Ranked" sort modes
From a user's perspective, changing a sort / order mode shouldn't filter
away results, but we were doing this.

In terms of UX expectations, in stable this kind of scenario would
results in a group being added to the end of son select with "Not
ranked" or "Unknown". I think we should aim to match this eventually.
2023-03-03 16:36:18 +09:00
bd11d5d29a Merge pull request #22743 from Joehuu/scroll-back-to-previous
Add ability to scroll back to previous position after scrolling to top via button on overlays
2023-03-01 22:55:47 +09:00
92edb0f868 Merge branch 'master' into skin-editor-depth-changing 2023-02-27 19:24:53 +01:00
fa710ae1b0 Rename ScrollToTopButton to ScrollBackButton 2023-02-26 14:39:34 -08:00
d98d330da2 Add expected behavior test for scroll back to previous position 2023-02-26 14:30:46 -08:00
dd9748a25c Adjust DrawNodes to use UBOs 2023-02-25 01:42:55 +09:00
d679703fa2 Merge pull request #22659 from peppy/fix-taiko-drum-nested-sample-detection
Fix `GameplaySampleTriggerSource` not considering nested objects when determining the best sample to play
2023-02-22 18:56:59 +01:00
a8c692a215 Merge pull request #22635 from peppy/use-overlays-container-more
Use `Overlays` container rather than `KeyBindingInputManager` for flashlight
2023-02-22 18:30:21 +09:00
32a9c066df Add test coverage of bring-to-front / send-to-back operations 2023-02-22 18:17:20 +09:00
90ca635a17 Fix weird nullability in TestSceneSkinEditor 2023-02-22 18:17:20 +09:00
f61fbcf3fc Update assertion to also check GameplayClockContainer's current time 2023-02-22 15:26:09 +09:00
a511e64fa5 Seek using GameplayClockContainer 2023-02-22 14:41:20 +09:00
d59d153654 Fix test compile failures from Audio hoisting 2023-02-21 21:03:00 +01:00
3d2fcb0cca Merge branch 'master' into fix-taiko-drum-nested-sample-detection 2023-02-21 20:53:06 +01:00
ec1bf7b0b2 Merge branch 'master' into skin-editor-clipboard 2023-02-21 19:35:58 +01:00
9321ec29dc Update slider sample source asserts to match expected behaviour
As pointed out in review, if the current time is after the end of the
slider, the correct hit object to use for sample retrieval is the object
itself, not any nested object.
2023-02-21 14:04:38 +09:00
e686b4393e Add wait steps to ensure frame-stable clock has caught up before checking state 2023-02-21 14:04:19 +09:00
5ba6059911 Merge branch 'master' into fix-taiko-drum-nested-sample-detection 2023-02-21 13:58:15 +09:00
3183f5cee2 Merge branch 'master' into revert-result-in-playfield 2023-02-19 16:33:10 +01:00
704dddf14b Merge branch 'master' into skin-editor-clipboard 2023-02-17 22:59:18 +01:00
6afa65bd3d Merge branch 'master' into skinnable-clean-up-documentation 2023-02-17 20:59:18 +01:00
3ee046000e Merge branch 'master' into revert-result-in-playfield 2023-02-16 21:54:29 +01:00
2fdf1fd876 Merge branch 'master' into fix-taiko-drum-nested-sample-detection 2023-02-16 19:43:02 +01:00
5bdc5dfadd Add one more assert to keep coverage from previous implementation 2023-02-16 19:02:51 +01:00
b59ec551f6 Add test coverage of GameplaySampleTriggerSource not considering nested objects 2023-02-16 18:21:33 +09:00
979c079f8b Refactor GameplaySampleTriggerSource test to not be realtime dependent 2023-02-16 17:58:44 +09:00
9d02a2ef0e Apply NRT to GamepleSampleTriggerSource tests 2023-02-16 17:58:44 +09:00
2fbaf88a3c Add clipboard dependency to SkinEditor specific tests
This is usually provided by the `SkinEditorOverlay`, which is not always
present in tests.
2023-02-16 15:24:38 +09:00
a92e42bb84 Rename SkinnableTargetContainer to SkinComponentsContainer
Also use full `SkinComponentsContainerLookup` instead of the sub-type.
This will potentially be useful once we bring in per-ruleset targets.
2023-02-15 18:37:41 +09:00
b1cf6d83d8 Move extension methods closer to serialisation classes 2023-02-15 18:37:41 +09:00
856efd9fd9 Rename SkinnableDrawableInfo to SerialisedDrawableInfo 2023-02-15 18:23:19 +09:00
9e651a7ca2 Rename SkinnableInfo to SkinnableDrawableInfo 2023-02-15 18:23:17 +09:00