Commit Graph

1009 Commits

Author SHA1 Message Date
1af230c48c Merge branch 'master' into refactor-combo-colour-retrieval 2021-07-20 10:08:25 +03:00
c18b8ca86c Add missing ToArray() call 2021-07-07 14:08:29 +09:00
ca791c2afa Remove unused using statement 2021-07-07 13:53:00 +09:00
35d4b12a4f Remove single local usage of AllSources 2021-07-07 13:52:52 +09:00
eb8b14a931 Reorder methods to make more sense 2021-07-07 13:51:51 +09:00
523546d8b6 Use List to guarantee lookup order 2021-07-06 22:51:56 +09:00
d75d67577a Fix regressed tests 2021-07-06 17:37:34 +09:00
cd4885e450 Add xmldoc and remove any question of how the intitial flow is being run 2021-07-06 17:18:45 +09:00
032c285ede Move private downwards 2021-07-06 17:07:29 +09:00
1232925f93 Make source manipulation methods protected 2021-07-06 17:06:00 +09:00
b4240d3ca4 Simplify lookups to avoid a second dictionary fetch 2021-07-06 17:04:59 +09:00
ec1224218c Localise source changed flow for better clarity 2021-07-06 16:57:19 +09:00
935fbe7cc6 Remove double fetch/binding of parent source 2021-07-06 16:51:29 +09:00
93ef783339 Remove BindableList usage 2021-07-06 16:40:23 +09:00
e1c646b9b2 Remove redundant arguments 2021-07-05 23:52:39 +08:00
ec71deec51 Remove some mentions of "lazer"
I am aware there are more throughout the codebase but intentionally left
the remaining mentioned for one reason or another. The intention here is
to mainly change user-facing versioning to change the positioning of the
"lazer" term (to be where we would expect "cuttingedge" or "beta" to
be).
2021-07-04 12:41:27 +09:00
6e31c781bb Merge pull request #13382 from ribbanya/clamp-skin-scale
Fix skin elements flipping when scaled below zero
2021-07-02 20:50:47 +09:00
9b0fa6d3fc Make flipping reflect across the axes of the selection box 2021-07-01 15:38:38 -07:00
094cd31361 Merge pull request #13441 from frenzibyte/ruleset-resources-skin
Provide access to ruleset resources during `ISkinSource` lookups
2021-06-30 15:26:37 +09:00
92fcf90768 Merge branch 'master' into import-early-checksum-abort 2021-06-28 19:29:08 +09:00
66fc95c111 Use LastOrDefault instead 2021-06-28 12:43:58 +03:00
7197998a10 Remove resolution to SkinManager and use pattern matching instead 2021-06-28 12:43:13 +03:00
177bfe1234 Merge branch 'master' into ruleset-resources-skin 2021-06-28 11:16:37 +03:00
779a1b322c Add comment explaining insertion of ruleset skin before default skin
Co-authored-by: Dean Herbert <pe@ppy.sh>
2021-06-28 09:38:42 +03:00
f598de4cdb ResourcesSkin -> ResourceStoreBackedSkin 2021-06-28 09:18:29 +03:00
692f24437e Maintain ruleset resources skin across multiple source changes 2021-06-28 09:11:28 +03:00
f777741ca7 Simplify instantiation 2021-06-28 14:51:27 +09:00
e387feb1d6 Add inline comment mentioning why CreateChildDependencies is being used in this instance 2021-06-28 14:39:55 +09:00
fdd6778f36 Merge branch 'master' into fix-initial-ruleset-skin-loading 2021-06-28 14:35:34 +09:00
44f875b802 Bypass optimised existing check in SkinManager (due to custom hashing function) 2021-06-27 16:35:13 +09:00
d1f852d102 Make Populate abstract to avoid unnecessary base call async complexity 2021-06-27 14:29:02 +09:00
e8e9fdd533 Dispose ResourcesSkin before clearing skin sources 2021-06-26 12:34:30 +03:00
e5eea503db Remove finalizer logic from ResourcesSkin 2021-06-26 12:21:49 +03:00
f07008a0a2 Fix RulesetSkinProvidingContainer potentially late in setting up skin sources 2021-06-25 10:05:51 +03:00
a98b5618b8 Convert RulesetResourcesSkin to plain ResourcesSkin and pass non-null resources 2021-06-24 10:07:38 +03:00
d484469906 Handle case where SkinManager sources aren't part of AllSources
In tests.
2021-06-23 10:44:23 +03:00
53fa229880 Add ruleset resources skin before SkinManager.DefaultSkin 2021-06-23 10:09:25 +03:00
2e6800f586 Enable NRT in RulesetResourcesSkin 2021-06-23 09:52:00 +03:00
0db06c727b Dispose resource stores on finalizer 2021-06-23 09:41:45 +03:00
ee84364d7c Resolve conflict issues 2021-06-22 20:38:24 +03:00
896c1dc202 Merge branch 'master' into ruleset-resources-skin 2021-06-22 20:36:49 +03:00
4cb9c6a842 Merge pull request #13423 from frenzibyte/transformers-per-skin
Refactor ruleset skin transforming logic to be per-`ISkin` rather than one `ISkinSource`
2021-06-22 21:24:56 +09:00
71e2815e7e Update and improve code documentation
Co-authored-by: Dean Herbert <pe@ppy.sh>
2021-06-22 12:05:17 +03:00
c1284940e1 Fix potentially providing the same skin instance twice in AllSources 2021-06-22 10:49:37 +03:00
d0cdc07b11 Reuse AllSources when looking up on FindProvider 2021-06-22 10:49:21 +03:00
4b3165084d Move scoped functionality into local function 2021-06-22 16:40:56 +09:00
ffac32a848 Reword xmldoc 2021-06-22 16:40:48 +09:00
14bdcef26b Add missing newline 2021-06-22 16:20:09 +09:00
0ad189e357 Expose skin sources via ISkinSource and revert to consuming based on hierarchy 2021-06-22 16:19:55 +09:00
1b0aadcc6f Merge branch 'master' into transformers-per-skin 2021-06-22 16:03:15 +09:00