Commit Graph

34436 Commits

Author SHA1 Message Date
dd315ff97b Adds hard-delete for a beatmap diff 2022-07-27 21:21:16 +10:00
3febd6d644 Dialogue touchups 2022-07-27 19:23:55 +10:00
e6fad601cc Adds delete difficulty option to editor 2022-07-27 19:15:43 +10:00
c30e8047ab Merge pull request #19375 from novialriptide/contextmenu-external-beatmap
Add ContextMenu to beatmap external link
2022-07-26 19:06:10 +09:00
b47f674ddb Merge pull request #19400 from peppy/button-select-allow-more
Always allow selecting the top-most button using the select binding
2022-07-26 18:49:42 +09:00
bc60552694 Merge pull request #19402 from peppy/debugger-attached-audio-warning-disable
Don't show audio playback issue notification if debugger is attached
2022-07-26 18:49:33 +09:00
8f7dff5c2c Merge pull request #19378 from peppy/beatmap-update-test
Add separate beatmap update flow to handle edge cases better
2022-07-26 18:49:20 +09:00
e782590b3c Don't show audio playback issue notification if debugger is attached
I've hit this countless times recently when debugging during the startup
procedure.
2022-07-26 18:20:46 +09:00
9173271900 Fix new update pathway not actually being used 2022-07-26 17:58:09 +09:00
1539fa704b Always allow selecting the top-most button using the select binding 2022-07-26 17:46:23 +09:00
6ff44ed2c6 Merge pull request #19399 from frenzibyte/carousel-order-stability
Maintain sort stability by using carousel item ID as a fallback
2022-07-26 17:33:30 +09:00
7f75184a01 Merge branch 'master' into beatmap-update-test 2022-07-26 17:27:36 +09:00
003aec86ae Rearrange sizeaxes 2022-07-26 04:27:22 -04:00
aaf6ec05bb Remove notification upon copy 2022-07-26 04:19:54 -04:00
4c22b55ce3 Fix incorrect handling if an update is processed with no changes 2022-07-26 17:00:28 +09:00
412d42b907 Merge pull request #19393 from peppy/fix-statistics-panel
Avoid potential realm fetch after disposal in `StatisticsPanel`
2022-07-26 16:32:59 +09:00
a4f6f2b9eb Make item ID comparer static 2022-07-26 09:55:37 +03:00
9939866f7d Revert one more missed change 2022-07-26 15:54:10 +09:00
8370ca9765 Add ImportAsUpdate method to IModelImporter to avoid otehr changes 2022-07-26 15:49:04 +09:00
693ac8750c Remove remaining uses of "child" terminology in non-drawable components 2022-07-26 09:43:47 +03:00
d7ef4170be Maintain sort stability by using carousel item ID as fallback 2022-07-26 09:40:41 +03:00
4efe09e7c2 Merge pull request #19377 from frenzibyte/fix-timeline-tests
Fix intermittent timeline zoom test failures
2022-07-26 15:18:35 +09:00
99bdf41717 Avoid potential realm fetch after disposal in StatisticsPanel
As seen at https://github.com/ppy/osu/runs/7513799859?check_suite_focus=true.
2022-07-26 15:12:23 +09:00
1b2158ff04 Remove unused method 2022-07-26 14:15:59 +09:00
ef10145d6f Rename MenuCursorContainer and clean up code 2022-07-26 14:11:52 +09:00
ee0c67e114 Add ability to make cursor show even during touch input
I completely disagree with this from a UX perspective, but it's come up
so often that I figure we should just let users bone themselves.
2022-07-26 14:08:00 +09:00
a8e315abf0 Refactor 2022-07-25 17:16:33 -04:00
46c4e78477 Add notification and another menuitem 2022-07-25 16:59:00 -04:00
d41ac36a69 Fix scenario where import is expected to be empty 2022-07-25 23:59:27 +09:00
8a0c8f5fd8 Fix some realm pieces not being cleaned up 2022-07-25 19:51:19 +09:00
2e14d8730c Move implementation of updating a beatmap to BeatmapImporter 2022-07-25 19:51:19 +09:00
2363a3fb7b Persist DateAdded over beatmap updates 2022-07-25 19:51:19 +09:00
e5ad07454c Ensure previous version prior to update loses online info after marked pending delete 2022-07-25 19:51:19 +09:00
912218e123 Ensure scores are transferred after beatmap update if difficulty hash didn't change 2022-07-25 19:51:19 +09:00
b7f6413bce Fix old version of beatmap potentially not being deleted during update flow
This can happen if the online IDs are not present in the `.osu` files.
Previously this was only working due to the early logic in the import
process (that relies on matching all online IDs perfectly).
2022-07-25 19:51:19 +09:00
6a3e8e31de Centralise calls to reset online info of a BeatmapInfo 2022-07-25 19:51:19 +09:00
1b6ebcfd87 Remove SubmittableScore and replace with SoloScoreInfo extension method 2022-07-25 13:43:43 +03:00
d04df19c7e Remove APIScore and replace its final usage 2022-07-25 13:13:46 +03:00
068063a43a Merge pull request #19371 from peppy/fix-working-cache-invalidation
Fix calls to `GetWorkingBeatmap` invalidating cache too often
2022-07-25 18:29:46 +09:00
1d48cee230 Merge pull request #19373 from peppy/fix-negative-star-rating-display
Fix star ratings which are still being calculated showing as "-1" at song select
2022-07-25 18:20:30 +09:00
6937296192 Merge pull request #19374 from peppy/fps-counter-no-scheduler
Refactor `FPSCounter` to not use scheduled tasks
2022-07-25 18:19:59 +09:00
48bcf57066 Mark SetupZoom and parameterless ZoomableScrollContainer ctor as protected 2022-07-25 12:07:50 +03:00
07c6b44864 Fix Timeline attempting to setup zoom with unloaded track 2022-07-25 12:07:50 +03:00
123930306b Refactor ZoomableScrollContainer to allow setting up zoom range and initial zoom after load 2022-07-25 12:07:50 +03:00
678acabf7e Merge branch 'master' into log-diffcalc-failure 2022-07-25 11:16:31 +03:00
f1534da683 Formatting issues 2022-07-25 04:13:05 -04:00
fcf767e28b Add contextmenu to beatmap external link 2022-07-25 04:07:33 -04:00
2dd99ef1fd Refactor FPSCounter to not use scheduled tasks
While on the surface this looks harmless (ignoring allocations),
`Scheduler` doesn't clear cancelled tasks until they reach their
execution time. This can cause an increase in time spent processing the
scheduler itself.

I don't think a per-frame updating component should use scheduled tasks
in this way in the first place, so I've just rewritten the logic to
avoid that overhead altogether.
2022-07-25 16:26:48 +09:00
4d90e6bbac Flip method to read better 2022-07-25 10:03:06 +03:00
6bf2645b1a Fix StarRatingDisplay not handling negative numbers as "pending" 2022-07-25 15:44:54 +09:00