ab24e87013
Merge branch 'master' into improve-drag-selection
2022-10-12 13:20:17 +09:00
fcb9e2cc00
Refactor blueprint container drag code
2022-10-11 22:39:53 +09:00
f41b79688f
Avoid casting by accepting all Playfields but throwing on a bad choice
2022-10-11 16:54:41 +09:00
6ab29a62d0
Anchor drag box on time (catch, mania)
...
Not done for taiko because I cannot figure out how it should work with the overlapping scroll algorithm.
2022-10-11 14:23:17 +09:00
1a24762f9b
Improve drag box selection logic
...
`AllowDeselectionDuringDrag` is remove.
Instead, selected hit objects are not automatically deselected
when clock is seeked to a later time (the hit object is dead).
Update drag box selection even if mouse is not moved
(in case clock is running or scroll wheel is used).
2022-10-11 14:11:45 +09:00
6164e0896a
Don't reselect already selected items in SelectAll
2022-10-07 10:46:07 +09:00
29cc554632
Ensure blueprint is added for selected hit object
2022-10-06 13:59:54 +09:00
0d448e6cc8
Fix items without blueprints are not deselected
2022-10-06 13:50:56 +09:00
b0213c29e9
Use mid time instead of start time
...
It is closer to the old blueprint-based behavior
2022-10-05 22:19:22 +09:00
6753f6b01a
Move AllowDeselectionDuringDrag down
...
Because it is now ignored in the timeline implementation anyways
2022-10-05 22:14:11 +09:00
3108c42ece
Fix inspect issues
2022-10-05 22:04:43 +09:00
00b3d97f69
Improve timeline selection performance
...
But selecting a large number of hit objects is still very slow
because all DHOs must be added
and also `AddBlueprintFor` has quadratic behaviors
2022-10-05 21:58:05 +09:00
0613388aaa
Make sure all selected items get deleted
2022-10-05 21:58:05 +09:00
0ffde02f79
Use hit object time for timeline selection
2022-10-05 21:51:01 +09:00
8d29e9e76b
Move selection logic from DragBox to BlueprintContainer
2022-10-05 21:51:01 +09:00
58217b6839
Fix weird conditional
2022-09-27 20:09:21 +09:00
a9088d9231
Add assert/log output when too many ticks are being displayed
2022-09-27 17:18:46 +09:00
e227519b09
Don't attempt to render timeline ticks until DrawWidth is above zero
2022-09-27 17:18:46 +09:00
ccae721af2
Ensure ZoomableScrollContainer content isn't shown until zoom is set
2022-09-27 17:07:11 +09:00
9dc0eb7fd0
Remove unused static
2022-09-27 17:04:56 +09:00
c075d3de08
Create a test and a check if initial zoom value of ZoomableScrollContainer is in range
2022-09-17 22:43:40 +02:00
9d94343317
Update osu.Game/Screens/Edit/Compose/Components/Timeline/Timeline.cs
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com >
2022-09-17 19:51:44 +02:00
c8768eb399
Changed == to <= on TimelineZoom check
2022-09-17 19:00:50 +02:00
3c7ea5c8fa
Update
2022-09-17 18:57:09 +02:00
f53507828c
Rename event to be more generic (and add comprehensive xmldoc)
2022-09-13 14:59:30 +09:00
fd48249eef
fix with new event
2022-09-13 02:20:52 +02:00
57954bb8f5
Enable nullability on TimelineHitObjectBlueprint
2022-09-05 14:50:43 +09:00
6a35b233e5
Merge branch 'master' into remove-dispose-updates
2022-09-01 23:03:19 +09:00
cfc7c32aff
Merge pull request #20009 from frenzibyte/fix-back-to-front-comparison
...
Adjust weirdly back-to-front fallback comparison in `HitObjectOrderedSelectionContainer`
2022-08-31 14:14:10 +09:00
a215d009fe
Update Remove/RemoveRange/RemoveAll calls in line with framework changes
2022-08-29 15:57:40 +09:00
3ff2058975
Fix back-to-front fallback comparison in HitObjectOrderedSelectionContainer
2022-08-29 09:23:53 +03:00
cd90536e4b
Remove Track access in Timeline
2022-08-26 18:25:48 +09:00
1b2158ff04
Remove unused method
2022-07-26 14:15:59 +09:00
48bcf57066
Mark SetupZoom and parameterless ZoomableScrollContainer ctor as protected
2022-07-25 12:07:50 +03:00
07c6b44864
Fix Timeline attempting to setup zoom with unloaded track
2022-07-25 12:07:50 +03:00
123930306b
Refactor ZoomableScrollContainer to allow setting up zoom range and initial zoom after load
2022-07-25 12:07:50 +03:00
e1df50c8ff
Fix timeline zoom focus point when using buttons
2022-07-22 17:03:05 +09:00
72916d708c
Merge pull request #19294 from peppy/fix-timeline-feedback-loop
...
Fix timeline `alt`+`scroll` zoom not correctly zooming to current mouse position
2022-07-22 16:05:38 +09:00
6eb42d08ce
Fix timeline zoom receiving feedback from bindable changes
...
This causes the focal point zooming to not work (as the focal point is
lost). There's no need to handle ongoing changes to
`BeatmapInfo.TimelineZoom` because it is not a property which is changed
at runtime.
2022-07-22 15:25:57 +09:00
4cec9a085a
Combine both calls to use same pathway
2022-07-22 14:59:20 +09:00
997fe00cdc
Fix zoom delta math
2022-07-21 17:29:13 -05:00
d69dc457ba
Extract zoom delta method
2022-07-21 17:28:43 -05:00
a4f071fe53
Make zoom sensitivity relative to containers max zoom
2022-07-21 08:26:48 -05:00
31a447fda0
Update parameter discards
2022-06-24 21:26:19 +09:00
f71f6302fd
Remove unnecessary null casts
2022-06-24 14:50:11 +09:00
e0c82d11ab
Convert == usages to ReferenceEquals
2022-06-20 16:56:19 +09:00
a5e5172b91
Fix BlueprintContainer eating input from skin editor buttons
2022-06-18 18:28:36 +03:00
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
87bf53485a
Merge pull request #18649 from frenzibyte/selection-context-outside-bounds
...
Fix context menus not appearing when clicking outside of editor playfield's bounds
2022-06-15 17:08:09 +09:00
d3feb07bc1
Split zoom updating to named method with value as optional
2022-06-15 07:57:16 +03:00
