Commit Graph

360 Commits

Author SHA1 Message Date
fa693bb8a8 Move MusicController adjustment set to inside OsuScreen itself (and result nullable) 2021-09-16 16:08:09 +09:00
318f0941ca Move all the "inherit previous AllowTrackAdjustments" logic into OsuScreen 2021-09-15 21:25:39 +03:00
931e873a7e Merge branch 'master' into inheritable-allow-track-adjust 2021-09-15 22:26:13 +09:00
b9193aae6d Make IOsuScreen.AllowTrackAdjustments nullable
Allows for inheriting value from the previous screen if undefined
2021-09-14 17:37:57 +03:00
f8bdca542d Make restoring state a public call on Editor 2021-09-14 23:36:17 +09:00
35ee889e5b Restore clipboard content after difficulty switch 2021-09-13 21:04:27 +02:00
3fc72271f1 Restore editor clock time after difficulty switch 2021-09-13 20:59:31 +02:00
22fa9a303e Expose test helper for switching between difficulties 2021-09-12 13:55:48 +02:00
2d59008f52 Move screen management logic to EditorLoader 2021-09-06 21:30:50 +02:00
bd7d6dd35d Rename method 2021-09-06 21:27:17 +02:00
d6a47fd99c Sort difficulties by ruleset and star rating in menu 2021-09-05 21:48:11 +02:00
382269b362 Test staying on same difficulty due to unsaved changes 2021-09-05 21:48:10 +02:00
a9403b65b3 Eliminate dependency on OsuGame 2021-09-05 21:48:10 +02:00
c397cc2027 Restructure proof of concept 2021-09-05 21:48:09 +02:00
fe2520c599 Add intermediary screen to avoid going back to menus 2021-09-05 21:48:09 +02:00
7befd030df Minimal working example of switching difficulties 2021-09-05 21:48:09 +02:00
90f0b6874f Highlight current difficulty in switcher 2021-09-05 21:48:08 +02:00
e8fb5d2e66 Add non-functional difficulty switcher to menu 2021-09-05 21:48:08 +02:00
3ad0b529fb Make EditorScreen inherit from VisibilityContainer rather than unsafe transforms 2021-08-25 17:14:52 +03:00
6108451449 Retrieve separated skin instance from working beatmap for editing 2021-08-15 21:18:09 +02:00
89e8296eb1 Reset all types of adjustments in MusicController; Rename AllowRateAdjustments to AllowTrackAdjustments 2021-07-29 15:39:26 +08:00
1bac471b49 Adapt to PlatformAction type change 2021-07-21 16:12:53 +09:00
3c028ce05c Add IDeepCloneable interface and update existing CreateCopy methods to use it 2021-07-19 12:54:17 +09:00
dbfaaecd9c Reword comment to not mention tests driectly 2021-05-20 15:39:29 +09:00
a639132825 Avoid doing any re-fetch on beatmap from test scenes 2021-05-19 17:58:28 +09:00
44e22b31a9 Refactor editor exit sequence to avoid any scenario where a dialog could go stray 2021-05-19 16:51:54 +09:00
b36c991ba1 Fix single case of incorrect usage 2021-05-14 12:04:38 +09:00
fc2a527e9d Revert "Guard against potentially null track if ever"
This reverts commit b1134c3857.
2021-05-07 09:57:08 +03:00
7c4e54a1d4 Unrevert null-colaescing/conditionals removal 2021-05-07 09:54:14 +03:00
b1134c3857 Guard against potentially null track if ever 2021-05-07 08:30:50 +03:00
37f44d2e37 Revert wrong not-null track changes
This reverts commit f9d99a9882.
This reverts commit 71547bece0.
2021-05-07 08:28:44 +03:00
71547bece0 Remove any null-coalescing/conditionals in WorkingBeatmap.Track usages 2021-05-07 07:46:23 +03:00
539643c72b Set loadable beatmap track to clock immediately in BDL
This reverts commit 84da247002.

Use loadable beatmap track for clock directly in BDL
2021-05-07 07:21:56 +03:00
84da247002 Fix editor clock using the wrong beatmap track on creation 2021-05-07 05:32:55 +03:00
9d8f0c854d Setup configuration item for editor hit animations 2021-04-21 18:05:40 +09:00
c6c91cd9a5 Refactor WaveformOpacityMenuItem to not receive whole config 2021-04-21 18:05:26 +09:00
7654df94f6 Merge pull request #12395 from frenzibyte/fix-cinema-ignore-settings
Fix beatmap background displayed if storyboard is hidden on "Cinema" mod
2021-04-14 14:31:03 +09:00
36510309d1 Merge EnableUserDim and IgnoreUserSettings to one bindable 2021-04-13 10:58:56 +03:00
14bd5bdc77 Merge branch 'master' into verify-tab 2021-04-12 15:14:37 +09:00
4df7ff21c7 Fix editor arrow seek snapping not updating after control point changes
The editor clock, which is responsible for performing the seek, was not
aware of changes in control points due to reading from the wrong
beatmap. `loadableBeatmap` is not actually changed by any of the editor
components; `playableBeatmap` and `editorBeatmap` are.

For now this is changed to use `playableBeatmap`. A better follow-up
would be to use `editorBeatmap`, but it would probably be best to move
the beat snap bindable into `EditorBeatmap` first.
2021-04-03 14:02:46 +02:00
690debe507 Merge pull request #12030 from LeNitrous/editor-platform-clipboard-copy 2021-03-29 19:31:16 +09:00
d58ef5310b Add verify tab
Currently empty, but works.
2021-03-28 17:36:22 +02:00
c96321206a fix appveyor complaints 2021-03-26 16:17:24 +08:00
2bea69456e remove implementations 2021-03-26 15:24:33 +08:00
51e0304c54 properly format strings per ruleset 2021-03-17 18:31:09 +08:00
133ff085a5 refactor code 2021-03-17 18:06:40 +08:00
8046b5a818 set text to platform clipboard on copy 2021-03-17 17:35:49 +08:00
3b6a1180b6 Remove non-accessed field 2021-03-17 17:02:11 +09:00
c7740d1181 Fix opening the editor occasionally causing a hard crash due to incorrect threading logic
Setting one of the global screen `Bindable`s (in this case, `Beatmap`)
is not valid from anywhere but the update thread. This changes the order
in which things happen during the editor startup process to ensure
correctness.

Closes #11968.
2021-03-17 15:52:25 +09:00
c70dd2edfc Merge pull request #11569 from peppy/fix-editor-new-beatmap-crash
Fix a potential crash when exiting the editor before a new beatmap is added to the database
2021-02-01 21:01:51 +09:00