Commit Graph

23964 Commits

Author SHA1 Message Date
84e1ff79a0 Merge pull request #12352 from smoogipoo/multiplayer-spectator-leaderboard
Implement the multiplayer spectator leaderboard
2021-04-13 01:51:14 +09:00
19a154ddf1 Rename checkOrigin -> check
More consistent with `Issue.ctor`'s "template".
2021-04-12 17:28:12 +02:00
bb720c23a0 Remove check ctors and locals 2021-04-12 17:12:37 +02:00
62c1812282 Remove redundant parameter naming 2021-04-12 23:37:47 +09:00
36bd235021 Move nested classes to bottom of file 2021-04-12 23:36:10 +09:00
6d50d01186 Make IssueTemplate.Check readonly 2021-04-12 16:23:05 +02:00
caaaba5950 Rename Check -> ICheck 2021-04-12 16:20:53 +02:00
008dbc7dd6 Reverse IssueType ordering
Reversed both in the enum and where it's displayed, so ends up the same in the end.
2021-04-12 15:49:13 +02:00
1c69829ad4 Fix Template.Origin -> Check 2021-04-12 15:47:58 +02:00
7c4f6d2b62 Rework template usage
Includes moving the origin check back to templates, constructing nested template classes in each check, and making parameterized template usage.
2021-04-12 15:47:26 +02:00
c531e38a36 Rework to create a derived tracked user data instead 2021-04-12 22:00:27 +09:00
3fd3f36895 Merge pull request #12378 from smoogipoo/fix-score-serialisation
Fix mods not being serialised correctly in ScoreInfo
2021-04-12 21:54:24 +09:00
27660265b5 Merge branch 'master' into multiplayer-spectator-leaderboard 2021-04-12 21:02:18 +09:00
e9a114a15c Rename property back 2021-04-12 20:50:18 +09:00
8413b0a5d3 Don't map api mods to DB 2021-04-12 20:49:44 +09:00
625484468e Fix DB serialisation 2021-04-12 20:49:37 +09:00
982d8fa8b1 Fix incorrect reference 2021-04-12 20:49:26 +09:00
d2d7f77430 Fix mods not being serialised correctly in ScoreInfo 2021-04-12 20:09:01 +09:00
905cd7c8eb Update resources 2021-04-12 19:22:07 +09:00
cc2acf5e54 Fix ctrl-dragging on an existing selection causing deselection of the hovered object 2021-04-12 19:05:23 +09:00
b5954a55ad Remove empty <returns> xmldoc 2021-04-12 17:46:14 +09:00
a2fc9c398f Rename CreateChecker -> CreateBeatmapVerifier 2021-04-12 10:08:30 +02:00
65ebdd8f7a Move check origin from IssueTemplate to Issue
As a result we can also make check an interface, and need to provide the check itself when constructing an issue.
2021-04-12 10:08:08 +02:00
0eab9daf13 Update existing overlay containers to not block scroll input 2021-04-12 16:41:36 +09:00
42604afcdc Add binding for verify mode (and move enum entry to end) 2021-04-12 16:15:27 +09:00
8bf85d737c Change Metadata into a get property 2021-04-12 15:52:29 +09:00
78bbc8f5c8 Tidy some remaining code 2021-04-12 15:52:18 +09:00
8c31e96cdf Change some methods to get properties 2021-04-12 15:52:18 +09:00
f78239c7f2 Move enums out of nesting 2021-04-12 15:52:18 +09:00
3551322f1d Fix formatting of colour getter 2021-04-12 15:52:18 +09:00
257acf9cd8 Colour constants to private 2021-04-12 15:52:18 +09:00
136627b9ac Wrap xmldoc less and make a few fixes 2021-04-12 15:52:18 +09:00
1c553b5d48 Checker -> BeatmapVerifier 2021-04-12 15:29:05 +09:00
14bd5bdc77 Merge branch 'master' into verify-tab 2021-04-12 15:14:37 +09:00
dd1925aaed Remove temporary input ignore 2021-04-12 14:29:27 +09:00
9be3163592 Merge branch 'master' into multiplayer-spectator-player-grid 2021-04-12 14:14:13 +09:00
995c244cee Remove alt-mousewheel bindings for volume adjustment
With the recent changes to the order of processing key bindings
(`GlobalAction`s are handled first), having the alt-wheel bindings in here causes a
regression as they are handled before `OnScroll` events.

Specifically, this means editor alt-scroll functionality no longer works
with the default bindings.

Removing the bindings fixes this, while also still allowing alt-wheel
adjustment of the volume via `VolumeControlReceptor`:

a2f50af424/osu.Game/Overlays/Volume/VolumeControlReceptor.cs (L21-L26)

In conjunction with the special case in `OsuScrollContainer`:

02d5b1352b/osu.Game/Graphics/Containers/OsuScrollContainer.cs (L103-L105)
2021-04-12 14:00:32 +09:00
fbd5195738 Extract mod setting value handling to utils class 2021-04-12 03:37:03 +03:00
18fb9f5ac9 Merge branch 'master' into mod-using-reference-equality 2021-04-11 19:48:55 +03:00
7d40b01722 Remove old todo 2021-04-10 15:18:15 +02:00
3289bb0379 Merge Check and BeatmapCheck
We're probably not going to need GeneralChecks or BeatmapsetChecks.

The verify tab is only available to a single difficulty at a time, and we already have access to the rest of the set through `IBeatmap`.
2021-04-10 14:56:30 +02:00
747e0f00dc Improve table formatting 2021-04-10 13:10:05 +02:00
3a4f2e3d7e Show table even if no issues 2021-04-10 13:09:16 +02:00
c995eca029 Remove todo
Doesn't really matter in the end, as only one checker will run at a time in this case.
2021-04-10 13:05:24 +02:00
6d3cf78e4a Add issue selection
This mainly helps with keeping track of which issue was clicked, since doing so switches tab.
2021-04-10 13:04:39 +02:00
bc4f3351f3 Replace checks with realistic ones 2021-04-10 13:03:16 +02:00
b30e41b805 Fix comment; mode -> ruleset 2021-04-10 13:02:36 +02:00
d1007ff26a Move components to more appropriate spot 2021-04-10 13:02:22 +02:00
43174b708c Remove visibility settings
Can look into this later, not really important for a first iteration.
2021-04-10 12:58:40 +02:00
b66ef2fdec Update framework 2021-04-10 02:14:28 +09:00