Commit Graph

47578 Commits

Author SHA1 Message Date
f9a2db5ec6 Add accessibility to realm factory via IStorageResourceProvider
We might need to rename this class..
2021-12-14 14:19:49 +09:00
be337b4ace Add failing test coverage of RealmLive failing post storage migration 2021-12-14 13:53:23 +09:00
8e6c7eb030 Use OsuStorage in realm tests to allow for migration
Also changes the realm filename to use `client` to match the ignore
rules in `OsuStorage`. Without doing this, migration will fail in an
indefinite mutex wait when attempting to delete the realm `.note` file.
2021-12-14 13:52:28 +09:00
7e576ae9d3 Add note about how the background colour is restored 2021-12-14 13:25:19 +09:00
357a661379 Fix storyboard sprites sometimes starting too early 2021-12-14 13:13:12 +09:00
51b6b9d857 Merge branch 'master' into chat-mention-fix 2021-12-14 11:49:57 +09:00
750bfae909 Fix TestMultiplayerClient not handling all users bailing from gameplay 2021-12-14 11:35:56 +09:00
2f1dc91211 Add AbortLoad() method to abort gameplay loads 2021-12-14 11:30:42 +09:00
a076eda834 Merge pull request #16062 from smoogipoo/retry-score-submission-timeout
Increase score submission timeout
2021-12-14 11:03:20 +09:00
19f7f4dc02 Merge pull request #16070 from peppy/test-score-refactoring
Move test `ScoreInfo` creation to `TestResources`
2021-12-14 10:03:52 +09:00
419a34e7b4 Merge branch 'master' into test-score-refactoring 2021-12-14 07:30:06 +09:00
01c7ff71c2 Merge pull request #16069 from peppy/clean-up-excess-bindings
Refactor `KeyBindingStore` to clean up any excess bindings for individual actions
2021-12-14 06:48:08 +09:00
7564658b5e Reduce to 30s 2021-12-14 06:40:45 +09:00
6e3558b222 Remove weird test 2021-12-14 06:38:57 +09:00
5618bdafce Merge branch 'master' into rhythm-bonus-performance-fix 2021-12-14 09:40:37 +13:00
c87ff82c1c calculateRhythmBonus performance fix. 2021-12-14 09:25:29 +13:00
9e9341597d Remove unused using statement 2021-12-13 17:59:04 +09:00
309290a3c9 Use new method in more places that can benefit from it 2021-12-13 16:56:43 +09:00
654b47c7ec Move "excess mods" test behaviour to local usages
There were only two of these, so it doesn't make sense to add extra
complexity in the test resources class.
2021-12-13 16:41:30 +09:00
99ac71c1fe Simplify usages where the ruleset being used is osu! ruleset 2021-12-13 16:37:20 +09:00
b0d14526ea Move test ScoreInfo creation to TestResources
The main goal here is to remove the inheritance, since realm doesn't
like that. Unfortunate that we can't use object initialisers in a few of
these places, but no real way around that.
2021-12-13 16:34:50 +09:00
70045494ba Re-simplify code by removing BeatmapManager event instead 2021-12-13 16:09:54 +09:00
7318ff3f98 Refactor KeyBindingStore to clean up any excess bindings for individual actions
While this isn't strictly required (outside of rulesets, potentially),
I think it's best that we keep these counts in a sane state.

Right now, it will remove any excess. Arguably, in the case an entry is
found with too many, we should wipe all entries and re-populate the
defaults. Interested in opinions on that before merging. See
https://github.com/ppy/osu/discussions/15925 for an example where wiping
may be the more appropriate behaviour.
2021-12-13 15:26:51 +09:00
4cac87e933 Add test coverage showing that KeyBindingStore won't remove excess key bindings 2021-12-13 15:26:32 +09:00
cac684c044 Improve appearance of player-wide background after failing with low background dim 2021-12-13 14:53:11 +09:00
c097dc8048 Add note about reasoning behind MultiplayerClient.GetAPIBeatmap call 2021-12-13 13:39:32 +09:00
3ea07b426b Merge branch 'master' into multiplayer-local-beatmap-query 2021-12-13 13:27:34 +09:00
c375c87094 Merge pull request #16065 from frenzibyte/reorder-version-overlay
Display game version overlay behind the overlays layer
2021-12-13 13:25:30 +09:00
7566722877 Merge pull request #16061 from smoogipoo/fix-results-score-position
Fix results sometimes showing incorrect score position
2021-12-13 12:59:10 +09:00
d92f5039cd Reorder version overlay to display behind game-wide overlays 2021-12-13 06:53:18 +03:00
d0fbbf110b Expose ScreenContainer for access in OsuGameDesktop 2021-12-13 06:52:36 +03:00
fd979a52fe Increase score submission request timeout to 60s 2021-12-13 07:15:21 +09:00
2cd2b10ce1 Fix results sometimes showing incorrect score position 2021-12-13 06:54:57 +09:00
bf3abb2455 Merge branch 'master' into multiplayer-local-beatmap-query 2021-12-12 16:37:41 +09:00
a6e77f172d Add some comments 2021-12-12 16:30:37 +09:00
9f792fec49 Fix test failures from async item loading 2021-12-12 16:11:48 +09:00
d6c08fae48 Fix incorrect global beatmap with availability changes 2021-12-11 23:08:21 +09:00
99cd36d2f6 Resolve some test failures due to async population 2021-12-11 22:52:08 +09:00
ece2cddb7f Fix DrawableRoomPlaylistItem lookup interfering with tests 2021-12-11 22:51:20 +09:00
25b274c323 Fix starting gameplay too early after import 2021-12-11 22:47:50 +09:00
1aac978a7b Merge pull request #16029 from peppy/editor-mod-reset
Fix editor not resetting mods when entering
2021-12-11 20:20:11 +09:00
ff0c5121e4 Merge pull request #16025 from peppy/pre-realm-score-tidy
Clean up various issues surrounding `ScoreInfo` in preparation for realm migration
2021-12-11 20:16:43 +09:00
63a017bc8e Use Array.Empty instead 2021-12-11 19:33:37 +09:00
cdb8237a4b Merge branch 'master' into pre-realm-score-tidy 2021-12-11 19:25:39 +09:00
1373d1cde2 Merge pull request #16028 from peppy/update-framework 2021-12-10 18:24:42 +03:00
3a4266bd5e Merge branch 'master' into update-framework 2021-12-10 17:50:33 +03:00
cf30411288 Revert "Remove now redundant inclusion of TouchMoveEvent in OsuInputManager.Handle"
This reverts commit bc1f1f35b5.
2021-12-10 17:13:13 +03:00
bc1f1f35b5 Remove now redundant inclusion of TouchMoveEvent in OsuInputManager.Handle
Now it's handled separately via the `HandleMouseTouchStateChange` override.
2021-12-10 16:44:16 +03:00
6057037e35 Move playlist item beatmap population to MatchSubScreen 2021-12-10 20:08:59 +09:00
02c29ba228 Merge pull request #16027 from peppy/add-threading-asserts
Add update thread asserts to `RoomManager` methods
2021-12-10 19:21:22 +09:00