109abc0e29
Always store standardised score when populating ScoreInfo
2020-11-10 08:41:00 +01:00
7109c3b6cd
Rename variable as suggested
2020-10-07 21:06:24 +02:00
2b6e4e575e
Award max combo portion score if max achievable is 0
2020-10-07 17:04:55 +03:00
74af7cc503
Rework ScoreProcessor
2020-10-07 17:00:00 +03:00
7890319802
Merge branch 'master' into adjust-hit-result-types
2020-10-01 16:19:07 +09:00
cb6b35116a
Merge branch 'master' into scoring-standardisation
2020-10-01 12:28:51 +09:00
9d07dce5e4
Merge pull request #10251 from smoogipoo/additional-hit-results
2020-10-01 12:19:48 +09:00
77651be2ca
Remove padding from HitResult
2020-09-30 21:32:50 +09:00
91262620d3
Remove XMLDocs from Ok/Perfect hit results
2020-09-29 17:17:06 +09:00
bad48d6d44
Merge branch 'master' into scoring-standardisation
2020-09-29 16:33:38 +09:00
31fae045fa
Update judgement processors with new hit results
2020-09-29 16:33:38 +09:00
6264a01ecc
Add guard against using the wrong hit result
2020-09-29 16:33:38 +09:00
07226c79b6
Add xmldocs
2020-09-29 16:33:23 +09:00
cee58e89a3
Pad hit results
2020-09-29 16:32:02 +09:00
1a70002cdd
Split ignore into hit/miss
2020-09-29 14:41:50 +09:00
9a24346a00
Fix HP drain edgecase potentially causing insta-fails
2020-09-25 23:29:40 +09:00
4bcc3ca828
Add AffectsAccuracy extension
2020-09-25 22:16:14 +09:00
1c4baa4e2a
Add bonus hit results and orderings
2020-09-25 20:11:27 +09:00
447fd07b4e
Fix maps with only bonus score having NaN scores
2020-09-11 01:13:55 +09:00
37a659b2af
Refactor/add xmldocs
2020-09-09 17:36:47 +09:00
e271408fca
Move max score calculation inside ScoreProcessor
2020-09-09 16:51:53 +09:00
1e5e5cae0c
Add support for standardised -> classic changes
2020-08-28 21:34:34 +09:00
4d15f0fe52
Implement basic score recalculation
2020-08-28 19:16:46 +09:00
a4ad0bd174
Ensure 0 score from miss judgements, add test
2020-08-18 19:51:26 +09:00
6b2b3f4d4d
Expose accuracy/combo portion adjustments
2020-07-16 14:10:44 +09:00
fda45997db
Merge pull request #9530 from peppy/fix-memory-retention
...
Clean up HitEvents after use to avoid near-permanent memory retention
2020-07-12 01:27:38 +09:00
2bb0283a68
Clean up HitEvents after use to avoid near-permanent memory retention
2020-07-12 00:52:55 +09:00
acfb6eecc6
Fix bonus judgements being required toward HP
2020-07-11 20:17:40 +09:00
2b7fb2b71d
Rename to Position
2020-06-22 19:04:51 +09:00
33fdd7466c
Merge branch 'master' into results-screen-statistics-overlapping-transition
2020-06-22 15:38:48 +09:00
9fbe2fa80a
Add comments, change to clamp
2020-06-21 19:31:00 +09:00
44925b3951
Reduce mania's HP drain by 20%
2020-06-21 18:05:26 +09:00
740b01c049
Add xmldoc
2020-06-19 22:05:58 +09:00
25abdc2903
General cleanups
2020-06-19 21:41:48 +09:00
ad3bc99e7c
Fix hit event position offset not being set
2020-06-19 20:49:05 +09:00
eab00ec9d9
Move hit events to the ScoreProcessor
2020-06-19 19:58:35 +09:00
e98f51923a
Add timing distribution to OsuScoreProcessor
2020-06-02 23:38:24 +09:00
a7f8c5935d
Expose LowestSuccessfulHitResult()
2020-06-02 23:36:56 +09:00
848a3fb6d7
Take hitobject start/end times into account in drain
2020-05-11 19:06:36 +02:00
1d999bb634
Integrate PeriodTracker changes
2020-05-10 18:32:38 +02:00
ee2ff77b89
Merge branch 'master' into fix-draining-in-between-break-sections
2020-05-10 17:57:44 +02:00
6d3a24ff01
Reorder tick hit results
2020-05-04 15:55:42 +09:00
f42be7a6d7
Merge branch 'master' into sorcerer-catch-changes
2020-05-04 15:25:09 +09:00
6f233917b1
Centralize updating HasCompleted bindable logic
2020-04-20 06:40:51 +03:00
fc6c245de5
Replace all judged event logic with HasCompleted bindable
2020-04-19 05:36:04 +03:00
ae210d567d
Add temporary solution for tick hit/miss count
2020-04-16 18:16:08 +09:00
13c81db0cf
Fix incorrect classic score formula
...
Upon closer inspection the classic score formula was subtly wrong. The
version given in the wiki is:
Score = Hit Value + (Hit Value * ((Combo multiplier * Difficulty
multiplier * Mod multiplier) / 25))
The code previously used:
bonusScore + baseScore * ((1 + Math.Max(0, HighestCombo.Value - 1)
* scoreMultiplier) / 25);
which is not equivalent to the version on the wiki. The error is in the 1
factor, as in the above version it is being divided by 25, while it should
be outside the division to keep parity with the previous formula.
The tests attached in the previous commit demonstrate that this change
causes a single hit without combo to increase total score by its exact
numeric value.
2020-04-14 01:09:58 +02:00
7fab07670e
Remove no longer necessary usage of IsBreakTime
2020-04-05 21:35:09 +03:00
e71a9668a5
Disallow draining in non-draining sections
2020-04-05 21:34:53 +03:00
401bf1c928
Remove unnecessary checks on NotNull attributes
2020-02-23 14:30:08 +09:00
