Commit Graph

30995 Commits

Author SHA1 Message Date
df9d99f5aa Merge branch 'master' into extended-statistics-without-replay 2022-02-03 18:59:48 +09:00
c8ce00b26a Trigger a re-layout of HUD components when scoring mode is changed
This is a simple way of fixing the layout of scoring elements
overlapping due to different score display width requirements of
different scoring modes. It will only resolve the case where a user
hasn't customsied the layout of the default skins, but as this is a very
simple / low effort implementation for the most common scenario, I think
it makes sense.

Closes https://github.com/ppy/osu/issues/16067.
2022-02-03 14:50:41 +09:00
a69c7a9de6 Split exceptions back out to give better messaging 2022-02-03 14:09:27 +09:00
62fa915193 Standardise exception messages for local-user-logged-out flows 2022-02-03 13:58:55 +09:00
d9a43b4c4c Fix API requests not completing when offline 2022-02-03 13:16:54 +09:00
aff36d4e16 Refactor populateStatistics to avoid disposing 2022-02-03 11:52:37 +08:00
2731d8e3c2 Merge pull request #16701 from LeNitrous/mod-alternate-osu
Add "Alternate" mod for osu! ruleset
2022-02-03 10:41:23 +09:00
82f9ad63f5 Fix flashlight size multiplier printing with too many decimal digits 2022-02-02 20:41:25 +01:00
074a691635 Set keyboard step to 0.1 for difficulty adjust sliders 2022-02-02 17:43:08 +03:00
19eb9ad8a7 Reorder StatisticsItem constructor to make a touch more sense 2022-02-02 23:02:38 +09:00
3c2a6fe208 Don't prompt for a replay if no item requires hit events 2022-02-02 19:07:14 +08:00
1e19c7046a Use spacing instead of bottom margin 2022-02-02 19:02:29 +08:00
b0023b9809 Also dispose rows 2022-02-02 19:00:46 +08:00
b5fb3b7dae Fix crash when selecting swap mod as freemod 2022-02-02 18:42:22 +09:00
36bfef4f54 Dispose container before replacing 2022-02-02 17:32:16 +08:00
042574660c Rename "Content" to "CreateContent" 2022-02-02 17:29:03 +08:00
90e30bc9e8 Remove useless null checks 2022-02-02 17:26:17 +08:00
5e3d124eef Add scrolling to the extended statistics panel 2022-02-02 17:20:22 +08:00
db0f3b7f5e Merge pull request #16738 from peppy/fix-ruleset-incorrectly-loading
Fix rulesets potentially being marked `Available` even when methods are missing
2022-02-02 18:03:04 +09:00
cb31ce812c Merge branch 'master' into cursor-tap 2022-02-02 16:34:34 +09:00
4758de226b Update resources 2022-02-02 16:27:59 +09:00
0c5da9370a Fix rulesets potentially being marked Available even when methods are missing
Came up when running the game after the recent breaking changes
(https://github.com/ppy/osu/pull/16722), where two template rulesets I
had loaded were erroring on startup but still being marked as available,
allowing them to crash the game on attempting to initiate relpay logic.

These cases are already handled for first-time ruleset loading via the
`GetTypes()` enumeration in `RulesetStore.addRuleset`, but when
consistency checking already present rulesets the only runtime
validation being done was `ruleset.CreateInstance()`, which does not
handle missing types or methods.
2022-02-02 14:52:01 +09:00
6e60e68b80 Change from click to mousedown+mouseup and only play when cursor is visible 2022-02-02 14:44:06 +09:00
3ba5d88914 Update statistics item display logic 2022-02-02 13:41:51 +08:00
c5c4c85006 Lazily create content of StatisticItem 2022-02-02 13:29:18 +08:00
6d962e7925 Merge pull request #16726 from dekrain/leaderboard-score-tooltip
Add basic tooltip for leaderboard scores
2022-02-02 13:56:45 +09:00
d065e32ca1 Fix crash due to MatchLeaderboardScores not having populated rulesets 2022-02-02 13:23:49 +09:00
35b7653290 Revert mod flow changes and add visual test coverage showing an overflow case 2022-02-02 09:13:19 +09:00
75101b1105 Remove unused ruleset ctor params from test beatmap model managers
No longer used since 00e3af3366.
2022-02-01 21:49:41 +01:00
994fb966b6 Remove Host ctor param from SkinModelManager
No longer used since 29d074bdb8.
2022-02-01 21:37:19 +01:00
07d09b3520 Remove unused parameter from createGameplayComponents()
No longer used since 136843c8e4.
2022-02-01 21:35:41 +01:00
a94702b3ae Remove unused parameters in LegacyComboCounter
No longer used since 9bb8a43bce.
2022-02-01 21:35:41 +01:00
1fa2bf5d69 Remove unused parameter from createColourBars()
No longer used since b61aa660c6.
2022-02-01 21:35:40 +01:00
c6a65ccfed Remove unused parameter from createContent()
No longer used since 513e470b52.
2022-02-01 21:35:40 +01:00
16e0cc6a2b Remove IIpcHost param from ScoreManager
No longer used since 3e3b9bc963.
2022-02-01 21:35:40 +01:00
a378e78ced Fix RealmLive unnecessarily passing ID around
Appears to have never been needed. When the `retrieveFromID` method was
created in 81b5717ae7, it didn't use the
`id` parameter for anything either.
2022-02-01 21:35:12 +01:00
3d7af805a3 Fix BeatmapMetadata not using its user param correctly 2022-02-01 21:16:28 +01:00
eee020f8e4 Cleanup tooltip layout
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-02-01 20:26:52 +01:00
0f83f77d2b Add xmldoc for new ResetFromReplayFrame method 2022-02-01 16:52:53 +09:00
f87920cd83 Remove unnecessary GridContainer and list mods verticall to give more space 2022-02-01 16:43:26 +09:00
8eace12fe3 Synchronise (roughly) backgrounds of all custom tooltips 2022-02-01 16:35:25 +09:00
fdb52a8fd7 Remove gap in tooltip display between statistics 2022-02-01 16:35:25 +09:00
855135c51e Fix potential nullref during display due to incorrect equality check 2022-02-01 16:13:27 +09:00
e1b57c4bf6 Fix inspections 2022-02-01 16:07:57 +09:00
d7b939277e Code quality improvements 2022-02-01 07:10:00 +01:00
fd287e06f2 Add missing license header 2022-02-01 06:51:00 +01:00
c2b775c0a3 Minor alignment adjustments 2022-02-01 06:45:59 +01:00
0641264a11 Merge branch 'master' into spectator-consistency-frames 2022-02-01 14:35:30 +09:00
db973fb348 Add basic tooltip for leaderboard scores 2022-02-01 06:28:18 +01:00
c421d8d3cd Merge pull request #16719 from peppy/mania-column-touch
Add basic touch input support for osu!mania
2022-02-01 12:26:29 +09:00