Commit Graph

290 Commits

Author SHA1 Message Date
a02c5710ac Rename base class 2020-03-02 10:06:49 +09:00
089ec4c792 Test scene for mod development 2020-02-29 21:16:28 -08:00
a047456354 Revert changes to make HitObject abstract 2020-02-25 19:07:15 +09:00
ffc7eaa3f2 Fix hitobjects with unknown lifetimes by enforcing non-null judgement
We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
CreateJudgement() must be implemented and return a non-null judgement.

This fixes BananaShower and JuiceStreams in osu!catch.

This also makes HitObject abstract and cleans up convert HitObject implementations.
2020-02-23 13:49:06 +09:00
48781e5685 Bump Microsoft.NET.Test.Sdk from 16.4.0 to 16.5.0
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.4.0 to 16.5.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.4.0...v16.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-10 08:24:12 +00:00
91735ff367 Update MathUtils namespace usages 2020-01-09 13:43:44 +09:00
2688a855a0 Downgrade NUnit to fix discovery issues 2020-01-08 14:14:46 +09:00
f91637e7b6 Bump NUnit3TestAdapter from 3.15.1 to 3.16.0
Bumps [NUnit3TestAdapter](https://github.com/nunit/nunit3-vs-adapter) from 3.15.1 to 3.16.0.
- [Release notes](https://github.com/nunit/nunit3-vs-adapter/releases)
- [Commits](https://github.com/nunit/nunit3-vs-adapter/compare/V3.15.1...V3.16)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-06 07:41:37 +00:00
492a910671 Update missed launch configurations 2019-12-20 19:08:05 +09:00
351e826120 Upgrade project targets to netcoreapp3.1 2019-12-20 17:03:54 +08:00
bc31146560 Mods -> SelectedMods 2019-12-13 21:45:38 +09:00
5861eca80d Make DrawableRuleset take a converted beatmap 2019-12-12 15:58:11 +09:00
709ec1404f Centralise End/StartTime retrieval to extension method 2019-11-25 19:09:14 +09:00
f2084df0bb Bump Microsoft.NET.Test.Sdk from 16.3.0 to 16.4.0
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.3.0 to 16.4.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.3...v16.4.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-11-07 06:19:49 +00:00
e987db37ec Add grouping of ControlPoints 2019-10-25 19:52:02 +09:00
1bf5f9313f Fix failing test 2019-10-21 18:10:00 +09:00
5d6648d9c9 Update 2.2 references 2019-10-10 17:45:38 +09:00
09864d7f0e Add bar line visual check in taiko playfield test
Add a step checking alignment of a centre and a bar line in taiko
playfield. Purely visual test without asserts.
2019-09-24 23:02:39 +02:00
f10b390ca0 Bump Microsoft.NET.Test.Sdk from 16.2.0 to 16.3.0
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.2.0 to 16.3.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.2.0...v16.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-09-19 16:32:39 +00:00
a407e267a2 Fix PF/SD legacy mod conversion
Upon investigating an user report in #6091 that indicated that viewing
replays using the Perfect mod would also display the Sudden Death mod
icon despite Perfect being the more restrictive of the two, it turned
out that the logic of importing legacy scores was missing that corner
case. A similar case of Double Time/Nightcore mutual exclusion was
handled, but PF/SD was missed.

Add analogous handling of PF/SD legacy mods for all four rulesets,
and additionally cover a tiny fraction of all cases with unit tests.
The most problematic cases (NC+HD and PF+SD) are covered in all four
basic rulesets.
2019-09-15 22:55:25 +02:00
f925e781a9 Refactor HitWindows for legibility 2019-09-06 15:24:14 +09:00
0c73c5acf3 Expose full hitobject rather than hit windows 2019-09-02 17:14:40 +09:00
f2bdf94a1d Add HitWindows to JudgementResult to indicate timing errors 2019-09-02 16:28:14 +09:00
5b685c4cd2 Fix swell ticks having non-zero time offsets 2019-09-02 13:25:39 +09:00
2876588193 Bump NUnit3TestAdapter from 3.15.0 to 3.15.1
Bumps [NUnit3TestAdapter](https://github.com/nunit/nunit3-vs-adapter) from 3.15.0 to 3.15.1.
- [Release notes](https://github.com/nunit/nunit3-vs-adapter/releases)
- [Commits](https://github.com/nunit/nunit3-vs-adapter/compare/V3.15...V3.15.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-08-30 13:36:31 +00:00
cd68d030bd Remove unnecessary UpdateState overrides 2019-08-27 05:04:34 +03:00
72a644996c Bump NUnit3TestAdapter from 3.14.0 to 3.15.0
Bumps [NUnit3TestAdapter](https://github.com/nunit/nunit3-vs-adapter) from 3.14.0 to 3.15.0.
- [Release notes](https://github.com/nunit/nunit3-vs-adapter/releases)
- [Commits](https://github.com/nunit/nunit3-vs-adapter/compare/V3.14...V3.15)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-08-23 13:41:27 +00:00
58e98e53d2 Bump NUnit3TestAdapter from 3.13.0 to 3.14.0
Bumps [NUnit3TestAdapter](https://github.com/nunit/nunit3-vs-adapter) from 3.13.0 to 3.14.0.
- [Release notes](https://github.com/nunit/nunit3-vs-adapter/releases)
- [Commits](https://github.com/nunit/nunit3-vs-adapter/compare/V3.13...V3.14)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-08-09 03:58:06 +00:00
379c9e8b7c Use expression body 2019-08-05 10:02:28 +02:00
ed4dda1936 Support beatmap conversion tests with mods 2019-08-01 12:49:01 +09:00
bf41fd5d9d Update package references 2019-07-06 23:29:35 +03:00
60ea3d4e1a Fix skinning support for combobreak 2019-06-30 21:58:30 +09:00
8fecd8dcdc Fix sudden death not being applied on first run 2019-06-21 16:37:06 +09:00
de59e038ac Prevent non-combo affecting judgements from triggering sudden death 2019-06-21 14:29:16 +09:00
f33a5bc54c Centralise and update WorkingBeatmap creation in test cases 2019-05-31 14:40:53 +09:00
a538c94fed Update NuGet packages 2019-05-17 21:40:46 +03:00
459a285cd8 Rename test cases to test scenes inline with the framework change 2019-05-14 22:37:25 +03:00
d7c09e7dbd Merge remote-tracking branch 'origin/master' into fix-new-inspections
# Conflicts:
#	osu.Game.Rulesets.Catch/Judgements/CatchDropletJudgement.cs
#	osu.Game.Rulesets.Catch/Judgements/CatchJudgement.cs
#	osu.Game.Rulesets.Mania/Scoring/ManiaScoreProcessor.cs
#	osu.Game.Rulesets.Osu/Replays/OsuAutoGenerator.cs
#	osu.Game.Rulesets.Osu/UI/Cursor/CursorTrail.cs
#	osu.Game.Tests/Visual/SongSelect/TestCaseBeatmapScoresContainer.cs
#	osu.Game/Graphics/OsuFont.cs
#	osu.Game/Online/API/Requests/Responses/APILegacyScoreInfo.cs
#	osu.Game/Overlays/Profile/Header/BadgeContainer.cs
#	osu.Game/Overlays/Profile/ProfileHeader.cs
#	osu.Game/Screens/Select/PlaySongSelect.cs
#	osu.Game/Skinning/LegacySkinDecoder.cs
2019-05-07 13:20:17 +09:00
0222424aef Make mods IReadOnlyList<Mod> gamewide
Prevents potential multiple evaluations of enumerable.
2019-04-10 17:20:36 +09:00
c584967eb1 Remove mods from workingbeatmap 2019-04-09 12:59:32 +09:00
c39c37a18d Apply more missed cases 2019-04-01 12:44:46 +09:00
d6f17a5ecd Bring nuget packages up to date 2019-03-22 02:41:21 +09:00
baea7230bc Rename RulesetContainer to DrawableRuleset 2019-03-19 23:47:31 +09:00
7e41fbc29b Remove LegacyDifficultyCalculator 2019-02-21 13:12:37 +09:00
f2ad2931c7 Merge remote-tracking branch 'upstream/master' into test-working-beatmap-clock 2019-02-20 11:37:33 +09:00
f8033a3b35 Give TestWorkingBeatmap a reference clock 2019-02-19 12:27:30 +09:00
ddc1ad848e Fix failing test 2019-02-18 15:02:09 +09:00
25d85b6eb4 Implement new difficulty calculator for Rulesets.Taiko 2019-02-18 14:54:21 +09:00
a8faa942a6 Implement new difficulty calculator structure 2019-02-18 14:49:43 +09:00
09e717d219 Add catch difficulty calculator tests 2019-02-15 15:49:51 +09:00