Commit Graph

70 Commits

Author SHA1 Message Date
a3cc0d23b3 Fix typo in xmldoc 2023-02-11 16:26:32 +01:00
6d876fdb9a Automatically select the closest timing point on entering the timing screen 2023-02-10 17:48:56 +09:00
03e623d1d2 Move ControlPointList to own file 2023-02-10 17:37:31 +09:00
7dbf379351 Don't use verbatim string literals 2022-11-29 18:22:07 +00:00
218c04c174 Code quality 2022-11-27 03:23:08 +00:00
3c56b9c93a Add OnRowSelected event to EditorTable 2022-11-27 02:47:54 +00:00
1a914d0df7 Remove #nullable disable from TimingScreen 2022-11-27 02:43:22 +00:00
7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
31a447fda0 Update parameter discards 2022-06-24 21:26:19 +09:00
e0c82d11ab Convert == usages to ReferenceEquals 2022-06-20 16:56:19 +09:00
a922ea9b01 Fix selection by directly comparing control points
Previously, all control points would get replaced, which led to
performance issues that was worked around in this PR. By comparing
control points, we're able to get good performance without requiring the
workaround.
2022-06-20 15:29:29 +09:00
468e5fcbed Merge branch 'master' into editor-controlpoint-undo-redo 2022-06-20 13:47:01 +09:00
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
776e7c0c71 Work around performance issues 2022-06-13 15:45:08 +09:00
fcf51a6f51 Merge pull request #18530 from peppy/add-cloen-button
Change text on timing group add button when it is going to clone instead
2022-06-03 22:23:04 +09:00
dd93fc283b Merge pull request #18531 from peppy/track-groups-better
Improve group tracking logic to avoid switching which point type unnecessarily
2022-06-03 13:04:54 +09:00
87ec2e490d Merge branch 'master' into deselect-control-group 2022-06-03 00:47:06 +02:00
ad3c093a08 Improve group tracking logic to avoid switching which point type unnecessarily 2022-06-02 18:33:09 +09:00
2fa4d46f73 Change text on timing group add button when it is going to clone instead
Also disables the button when it would otherwise have no effect.
2022-06-02 18:28:16 +09:00
0b125ade4c Allow clicking away to deselect the current control point group 2022-06-02 18:18:18 +09:00
5a0f716bf2 Fix timing screen crash when attempting to add group to self
Closes #18527.
2022-06-02 18:14:28 +09:00
6b297bc6ed Merge pull request #18502 from peppy/editor-timing-follow-current-time
Add automatic control point tracking to the timing screen
2022-06-02 07:37:03 +09:00
6b709de2c2 Remove unused using directive 2022-06-01 20:18:02 +02:00
534e8f8fac Only switch to found group if non-null 2022-06-01 20:20:48 +09:00
187acb0718 Simplify linq tracking logic 2022-06-01 17:57:53 +09:00
c55c3325a4 Remove unused using statements 2022-06-01 17:43:40 +09:00
25941f6187 Use DeepClone instead of reflection call
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-06-01 10:47:45 +09:00
8240b645b4 Copy attribute types from currently selected control point to new placements 2022-05-31 21:50:12 +09:00
f99bcb23a0 Automatically make first control point added to beatmap have timing data 2022-05-31 21:50:08 +09:00
cf5da44492 Add automatic control point tracking to the timing screen 2022-05-31 15:00:30 +09:00
17206bbebf Update screen padding and colouring to better match new designs 2022-05-24 18:43:22 +09:00
a346990a8c Remove TriangleButton usage in editor 2022-05-24 18:13:09 +09:00
d2e0e8ad94 Reverse direction of binding to allow for better abstract class definitions 2021-05-12 16:53:58 +09:00
097a347533 Adjust Add different background colour for timing area 2021-04-19 18:25:30 +09:00
f4baff9e04 Make TimingScreen use rounded screen and adjust spacing/padding 2021-04-19 14:35:35 +09:00
0c918410d0 Make "add" button more visible 2021-04-19 13:15:24 +09:00
658c23c925 Give more space to the parameter adjustment area 2021-04-19 13:15:17 +09:00
7fdf876b4c Fix editor timing screen mutating the WorkingBeatmap instead of EditorBeatmap 2021-01-04 16:38:15 +09:00
610ed99ae3 Add null checks to unguarded resolved-as-null fields 2020-11-14 14:52:58 +01:00
487a5ecdba Replace all usage of IBindableList.GetBoundCopy 2020-11-04 15:29:14 +09:00
e1f578c590 Change editor timing screen seek behaviour to only occur on clicking table rows
Previously it would react to any selection changed event, which could in
lude time changes (which is done by removing then adding the
ControlPointGroup).

Closes #10590.
2020-10-27 12:28:12 +09:00
16a599850c Merge branch 'master' into more-timeline-toggles 2020-10-05 17:33:18 +09:00
c1c5b5da8e Push state change on control point group addition / removal 2020-10-02 17:49:38 +09:00
0d03084cdc Move control point display to the base timeline class
We want them to display on all screens with a timeline as they are quite
useful in all cases.
2020-10-01 18:16:12 +09:00
a11c74d600 Update to consume framework fixes 2020-09-30 20:27:02 +09:00
698042268f Show control points in timing screen timeline 2020-09-30 17:00:42 +09:00
5b200a8ca4 Change default zoom of timing screen timeline to most zoomed out 2020-09-30 16:39:27 +09:00
a40c2ea5ee Simplify control point group binding/update logic 2020-09-30 16:02:22 +09:00
158d307126 Avoid destroying editor screens when changing between modes 2020-09-24 17:03:54 +09:00
d45a1521a1 Update BindableList usages 2020-09-01 11:56:23 +09:00