Commit Graph

7315 Commits

Author SHA1 Message Date
f6b9d36acf Remove unused using 2022-01-17 17:06:04 +09:00
12fd279b7d Add test to check full flow of rebinding gameplay key bindings
Addresses a regression found in realm PR that was not covered by tests.
2022-01-17 16:00:17 +09:00
19467e58c1 Remove unused params from BDL methods 2022-01-15 01:06:39 +01:00
9af9155e66 Fix osu.Game.Tests.Android not building 2022-01-14 17:37:58 +01:00
eb5f15a77e Merge pull request #16420 from bdach/slider-paste-parsing-failures-2
Fix pasted sliders having sample points with time at infinity
2022-01-13 23:28:49 +09:00
7147799895 Merge pull request #16273 from Joehuu/fix-remaining-identifier-names
Normalise more identifier names
2022-01-13 17:06:57 +09:00
e1f5acd689 Remove names from user dictionary 2022-01-13 12:40:19 +09:00
b245ffefc1 Merge remote-tracking branch 'upstream/master' into fix-remaining-identifier-names 2022-01-12 15:05:07 -08:00
672c1d36dc Fix intermitten screen navigation tests 2022-01-13 05:52:04 +09:00
07fc772c24 Merge branch 'master' into slider-paste-parsing-failures-2 2022-01-12 19:06:36 +01:00
2212bea17f Fix test failures due to double BeginPlaying calls 2022-01-13 01:34:29 +09:00
970e0cc85a Merge branch 'master' into beatmap-background-with-storyboard-stopping 2022-01-11 21:39:49 +01:00
e91d3dd8b4 Add failing test for incorrect sample control point time after paste 2022-01-11 21:34:22 +01:00
60e42bf45e Add lenience to fix test failures 2022-01-11 23:01:17 +09:00
ef66ec4622 Also fix MessageFormatter tests 2022-01-11 17:55:43 +09:00
3cb5f43f77 Fix incorrect action returned for wiki links in DEBUG mode 2022-01-11 17:46:49 +09:00
269df08fc9 Make ChatLink tests into proper unit test methods 2022-01-11 17:42:02 +09:00
af9fad00c3 Merge branch 'master' into async-deadlock-safety 2022-01-10 16:11:09 +09:00
928023fabb Merge pull request #16362 from bdach/multiplayer-wrong-ruleset
Fix multiplayer starting gameplay using last picked item ruleset rather than actual current item ruleset
2022-01-10 15:10:27 +09:00
c2843249e8 Merge pull request #16359 from peppy/fix-legacy-score-decoer-test
Fix `LegacyScoreDecoderTest` incorrectly comparing unset beatmap IDs
2022-01-10 13:10:58 +09:00
02d8a6359a Update FilterMatchingTest and filter code to use ruleset's OnlineID
The tests were relying on the `RulesetID` being set to 0 in the example
beatmap, even though the ruleset *instance* was set to ID 5.

This explicitly adds that 0 value to show intent, and also removes the
incorrect specification of 5 (which would cause the convert filter tests
to fail).

Also updates the filter code to use `OnlineID`, which is required in
realm changes.
2022-01-10 12:30:34 +09:00
3d14511286 Remove MD5 comparison also 2022-01-10 12:17:32 +09:00
82d6639a3b Decouple rankings table test from online API 2022-01-09 14:42:19 +01:00
446962446e Add test coverage for correct revert of mods when play starts at song select 2022-01-08 14:50:58 +01:00
3dd5705a81 Add test coverage for correct revert of mods after new item is queued 2022-01-08 14:50:58 +01:00
50077f05bd Add test coverage for correct revert of ruleset when play starts at song select 2022-01-08 14:50:57 +01:00
f026973b19 Add failing test for ruleset incorrectly applying from latest picked item 2022-01-08 14:50:54 +01:00
f6f24220c2 Fix LegacyScoreDecoderTest incorrectly comparing unset beatmap IDs
This has been wrong from the outside, but hidden by the fact that the
default values are equal. I've changed to MD5Hash which actually asserts
that the correct beatmap has likely arrived.

Found this in my realm changes, where it fails due to the beatmap ID
being a differing Guid in each case.
2022-01-08 15:28:13 +09:00
881fa2b86b Add basic test scene for scoreboard time 2022-01-07 19:18:16 +01:00
3cd996eb4a Merge branch 'master' into async-deadlock-safety 2022-01-07 17:28:59 +09:00
00177a3ae1 Update usages to new naming 2022-01-06 22:54:43 +09:00
66613cbaa4 Wait for async continuation in score submission test
The previous assert step was optimistically assuming that the async
continuation that writes the value of
`FakeImportingPlayer.ImportedScore` always completes before it, but
that's not necessarily true even if the continuation is instant (it is
still subject to things like task scheduling and TPL thread pool
limits).

To ensure no spurious failures, swap out the assert step for an until
step instead.
2022-01-06 13:09:25 +01:00
84765b99b3 Handle score submission request in submission test scene
Was previously not handled at all, therefore displaying request failures
in the test log output. While that was mostly a red herring and
shouldn't have caused any actual *test* failures, it is still better to
handle this explicitly in a realistic manner.
2022-01-06 12:57:26 +01:00
5ed69338a6 Add omission of pages when there are too many 2022-01-04 19:05:14 +09:00
86f72b71b1 Prepare tests and general structure to support omission of pages 2022-01-04 18:46:44 +09:00
5a11ee7810 Use OverlayColourProvider and fix font weight 2022-01-04 18:14:42 +09:00
d10b8c79b3 Remove pointless test coverage of DrawablePage 2022-01-04 17:53:24 +09:00
ee4f5c0e79 Rename button classes to make more sense 2022-01-04 17:52:40 +09:00
1c899e4402 Fix post-merge issues 2022-01-04 16:46:42 +09:00
69e7ee0f48 Merge branch 'master' into page-selector 2022-01-04 16:44:22 +09:00
f3e889d0f6 Fix incorrect nested result retrieval in ImportBeatmapTest 2022-01-04 11:51:41 +09:00
73b40e6833 Replace usage of .Result with .WaitSafelyForResult 2022-01-04 11:51:41 +09:00
031a40af6a Replace usages of Wait with WaitSafely 2022-01-04 11:51:41 +09:00
f6b1405fa0 Merge branch 'master' into fix-listing-terminal-breakage 2022-01-04 11:49:02 +09:00
7cdba2f7c3 Add test coverage of score submission if player is exited during import 2022-01-03 22:00:47 +01:00
2660f41339 Add failing test case for old cards not expiring correctly 2022-01-03 19:28:14 +01:00
04d8fd3a58 Improve reliability of TestStoryboardSkipOutro
Aims to resolve failures as seen at
https://github.com/peppy/osu/runs/4677353822?check_suite_focus=true.

Have run quite a lot locally with no failures (while removing the skip step 100% fails).
2022-01-01 15:32:39 +09:00
f53a675ca3 Fix TestSceneMultiSpectatorLeaderboard not waiting for user population 2021-12-31 00:48:31 +09:00
c22a07d9fc Bump identifier typo inspection and fix remaining identifier names 2021-12-28 11:26:42 -08:00
7de43e3aba Fix most open compound words in identifiers being closed 2021-12-27 20:26:28 -08:00