Commit Graph

30097 Commits

Author SHA1 Message Date
e38e4c0adc Enable NRT on IWorkingBeatmap 2021-12-22 18:17:00 +09:00
967419c9ac Remove BeatmapSetInfo and Metadata from interface
There were very few accesses to this, and after realm they should all be
done via the `BeatmapInfo`, so let's remove this.
2021-12-22 18:17:00 +09:00
1b0af78831 Simplify WorkingBeatmap in multiple ways
Just a clean-up pass.
2021-12-22 18:17:00 +09:00
b38b300159 Convert BeatmapMetadata access to be via a computed property 2021-12-22 18:17:00 +09:00
f81e32149b Fix ImportCollectionsTest.TestSaveAndReload not cleaning up before/after run 2021-12-22 13:38:20 +09:00
a88800c99a Merge pull request #16198 from smoogipoo/fix-current-item-before-population
Fix delete button showing on current item before beatmap retrieval
2021-12-22 13:15:07 +09:00
7bc5079485 Merge pull request #16201 from bdach/timeline-blueprint-contrast-improvement
Improve contrast of timeline blueprint foreground content for pastel combo colours
2021-12-22 11:33:29 +09:00
7ab1c0c99d Improve contrast of timeline blueprint foreground content for pastel combo colours 2021-12-21 12:54:17 +01:00
ca7303a50a Fix online lookup cache not clearing completed task on early return
The task not being cleared in the early return path would cause
`pendingRequestTask` to become stuck as a completed task, and
`queryValue()` would not recreate it due to the null check there,
therefore stalling all lookups forevermore until a game restart.
2021-12-21 11:13:41 +01:00
ee89d8643e Extract abstract implementation of online lookup cache 2021-12-21 11:12:51 +01:00
df975fb29e Merge pull request #16181 from dekrain/statics-reset-no-sb
Split session statics reset method to prevent unloading seasonal backgrounds
2021-12-21 18:52:04 +09:00
0bda7892f7 Merge pull request #16197 from bdach/beatmap-card/renames
Rename beatmap card-related classes
2021-12-21 18:51:34 +09:00
4ce61d4260 Directly bind to room updates
Currently doesn't really cause any difference, however it may in the
future if we decide the queueing algorithm shouldn't update PlaylistOrder
when an item has been played.
2021-12-21 18:40:29 +09:00
a34d24fb20 Disallow expired items from showing delete button
This isn't possible in practice since expired items are removed from the
queue list, but this helps out in tests.
2021-12-21 18:37:42 +09:00
d7136d6b48 Merge pull request #16196 from peppy/update-framework
Update framework
2021-12-21 18:23:02 +09:00
4ba5a939db Merge pull request #16178 from bdach/lounge-background-screen-correct
Fix lounge screen showing information sourced from wrong playlist item
2021-12-21 17:36:23 +09:00
51b7e920c0 Fix delete button being able to show on current item 2021-12-21 16:57:58 +09:00
979624160f Do not reset last hover sound playback time on inactivity 2021-12-21 08:47:41 +01:00
cd10af633c Remove unused private method 2021-12-21 08:47:26 +01:00
0198d49a3a Update framework 2021-12-21 16:38:03 +09:00
32fbaf47c0 Merge pull request #16192 from peppy/add-room-lost-logging
Add logging of `MultiplayerMatchSubScreen` exiting from room loss
2021-12-21 16:37:08 +09:00
c7b9b176c6 Rename BeatmapCard{Base => } 2021-12-21 08:26:25 +01:00
88d4e95ad8 Rename BeatmapCard{ => Normal} 2021-12-21 08:26:21 +01:00
bd1fb33ad6 Add and use separate extensions for historical and upcoming playlist items 2021-12-21 08:01:04 +01:00
2707b2fbda Merge pull request #16012 from bdach/beatmap-card/extra
Implement "extra" beatmap card size
2021-12-21 15:40:33 +09:00
981158ed88 Rename method and simplify SetDefault calling code 2021-12-21 15:34:32 +09:00
5cea8da80f Merge pull request #16188 from peppy/multiplayer-button-enabled
Centralise all multiplayer button clicking test logic
2021-12-21 15:10:26 +09:00
d08b66a5ff Also add logging to OnlinePlayScreen 2021-12-21 15:07:06 +09:00
ddadf3c4b5 Add logging of MultiplayerMatchSubScreen exiting from room loss 2021-12-21 14:53:24 +09:00
9aff646ff4 Centralise all multiplayer button clicking test logic
This adds the "wait for enabled" check in a way that can be easily
reused, as it keeps getting missed in test implementations.

This particular commit hopefully fixes
https://github.com/ppy/osu/runs/4583845033?check_suite_focus=true.
2021-12-21 13:49:51 +09:00
edcbd4de6d Fix incorrect event unbind logic 2021-12-21 13:05:26 +09:00
52db7b36fc Move Schedule call to base implementation of error meter for extra safety 2021-12-21 12:55:21 +09:00
28d6ff5d9c Fix potential wrong thread mutation in ColourHitErrorMeter 2021-12-21 12:36:04 +09:00
9344897542 Split session statics reset method to prevent unloading seasonal backgrounds while idle 2021-12-20 16:51:51 +01:00
f1a03aced5 Merge branch 'master' into beatmap-card/extra 2021-12-20 15:49:00 +01:00
0975f570ba Return last playlist item if all expired 2021-12-20 13:49:05 +01:00
a5a9922f81 Fix lounge screen content not matching current room playlist item 2021-12-20 13:32:42 +01:00
a59583ee09 Add extension method for returning next playlist item 2021-12-20 13:18:02 +01:00
6907a9a3cc Name some screen stacks for better logging context 2021-12-20 18:24:14 +09:00
1533aefce5 Update framework 2021-12-20 18:22:19 +09:00
9316abc278 Better fix for intermittent multiplayer tests 2021-12-20 13:10:13 +09:00
a6ccbafc77 Fix rank graph showing for unranked users 2021-12-19 13:40:22 +01:00
097402677d Add test for ranked/unranked user display 2021-12-19 13:40:22 +01:00
04cfae9bde Fix "Random Skin" text not showing up correctly 2021-12-18 16:26:15 +09:00
33e930f477 Move scale-on-expand logic to BeatmapCardContent 2021-12-17 13:29:20 +01:00
d6f6039934 Extract base class for beatmap cards 2021-12-17 13:27:11 +01:00
f052b47d87 Extract collapsible button container for card usage 2021-12-17 12:58:05 +01:00
7aab12d4b0 Share extra row dropdown show/cancel show logic 2021-12-17 11:45:05 +01:00
3fa45479b0 Share hype/nomination statistic show logic 2021-12-17 11:45:05 +01:00
81603a0645 Update framework 2021-12-17 19:32:58 +09:00