Commit Graph

7789 Commits

Author SHA1 Message Date
e6872629f3 Merge pull request #22868 from peppy/no-epilepsy-warning-storyboard-disable
Don't show epilepsy warning when storyboards are disabled
2023-04-06 12:32:38 +09:00
ba753a8aac Merge branch 'master' into update-skinnable-sound-before-playing 2023-04-05 22:56:25 +02:00
6df7614b9d Add tests for suppressing epilepsy warning when storyboard disabled 2023-04-05 20:56:50 +02:00
02c6126be7 Ensure storyboards are enabled in existing epilepsy warning tests 2023-04-05 20:53:54 +02:00
432f698697 Merge branch 'master' into gameplay/key-counter-abstraction 2023-04-05 19:45:14 +02:00
8cc425774b Merge branch 'master' into fix-replay-fail-on-exit 2023-04-03 21:23:23 +02:00
b5d9284de2 Merge pull request #23108 from peppy/fix-overlay-toggles-during-disclaimer
Fix attempting to show overlay during game intro playing hide sound effects
2023-04-03 20:48:03 +02:00
6239789188 Fix missing using statements in multiple test scenes 2023-04-03 15:37:10 +09:00
b0c09df259 Merge branch 'master' into gameplay/key-counter-abstraction 2023-04-03 15:33:35 +09:00
43d7386623 Merge pull request #22926 from Joehuu/fix-sort-direction-not-resetting
Fix beatmap listing sort direction not resetting when changing criteria
2023-04-03 15:32:10 +09:00
a097433cb1 Fix overlay toggle keys working during disabled activation modes
Closes #23104.
2023-04-03 15:03:47 +09:00
9b45591c2f Add failing test coverage of saving failed replay causing progression to results 2023-03-29 14:00:11 +09:00
d31b37e87e Merge branch 'master' into fix-ubo-not-bound 2023-03-26 16:14:11 +09:00
e1906a90eb Use image@2x from tournament banner api 2023-03-25 13:08:46 -07:00
ad5bdf6511 Merge branch 'master' into fix-ubo-not-bound 2023-03-22 16:46:39 +09:00
1478a26cc0 Addressed changes 2023-03-21 23:15:49 +01:00
df3ccdff9f Add failing beatmap listing sort direction on criteria change test 2023-03-21 15:08:37 -07:00
9ff9cd3b7f Merge branch 'master' into skin-editor-cyclic-selection 2023-03-21 19:49:55 +01:00
fb51221c2b Add test coverage of cyclic selection triggering when more than one item is selected 2023-03-21 21:31:10 +09:00
678e8ed736 Update UBO usages inline with framework changes 2023-03-16 14:06:35 +03:00
556964eae0 Merge branch 'master' into BitmapUpdatesOnScore 2023-03-16 12:16:42 +03:00
a81408ca06 Add failing test coverage showing that replay will fail on exiting gameplay 2023-03-16 17:12:46 +09:00
159c8833c7 Add test coverage of SkinnableSound not updating in time when not present 2023-03-16 15:41:05 +09:00
5378cdff20 Apply NRT to TestSceneSkinnableSound 2023-03-16 15:10:35 +09:00
5f9b13a775 Rename Add/AddRange methods as they are no longer conflicting with Container 2023-03-15 18:02:41 +09:00
8908648f97 Fix super-dodgy cast of IEnumerable to Drawable 2023-03-15 18:01:22 +09:00
1cf870d956 Add test coverage and fix fail case where a drag selection ends incorrectly with cyclic selection 2023-03-15 15:16:48 +09:00
3c4e2d8700 Add tests covering drag selection 2023-03-14 21:04:51 +09:00
969c0e9c9d Merge branch 'master' into veldrid-renderer 2023-03-14 17:35:38 +09:00
d806b85a30 revert: make counters an IEnumerable again
As suggested by bdach as this would make the last two commits useless

Refs: 5d15426
2023-03-09 10:25:03 +00:00
44297a7d0a refactor: make KCD a CompositeDrawable 2023-03-08 00:47:16 +00:00
28520414aa Move KeyCounter components to HUD namespace 2023-03-07 16:41:39 +09:00
15d65059b5 Tidy up Add method logic 2023-03-07 16:21:57 +09:00
8f6df5ea0f Merge branch 'master' into gameplay/key-counter-abstraction 2023-03-07 16:09:45 +09:00
d2fcdf6e0e Add test coverage of cyclic selection in skin editor 2023-03-07 15:11:47 +09:00
ec15e2b9cc Merge branch 'master' into dont-filter-results-on-sort-mode 2023-03-06 17:57:47 +01:00
9d4bb2ecf7 Add failing test coverage for clearing sidebar contents 2023-03-04 14:08:50 +01:00
2f25fb4083 Move NonSkinnableScreenPlaceholder to outer scope 2023-03-04 13:22:43 +01:00
3dd3b5e77a Add failing test case 2023-03-04 13:17:54 +01:00
a14dede036 Ensure TestBeatmapCarousel.Items only returns actually visible items (and in correct order)
Turns out that items could be in an order that isn't the same as how
things look on the carousel, so this change ensures that for testing
purposes they are sorted by Y position.

Also uses the `CarouselItem.Visible` flag to ensure that we don't have
to wait for drawable fade transitions after a filter operation.
2023-03-03 17:18:34 +09:00
7a092ea995 Add better coverage and more comments explaining the structure of test setup 2023-03-03 17:18:14 +09:00
82293c0c86 Don't filter away results with missing data when using "Date Submitted" or "Date Ranked" sort modes
From a user's perspective, changing a sort / order mode shouldn't filter
away results, but we were doing this.

In terms of UX expectations, in stable this kind of scenario would
results in a group being added to the end of son select with "Not
ranked" or "Unknown". I think we should aim to match this eventually.
2023-03-03 16:36:18 +09:00
bd11d5d29a Merge pull request #22743 from Joehuu/scroll-back-to-previous
Add ability to scroll back to previous position after scrolling to top via button on overlays
2023-03-01 22:55:47 +09:00
92edb0f868 Merge branch 'master' into skin-editor-depth-changing 2023-02-27 19:24:53 +01:00
fa710ae1b0 Rename ScrollToTopButton to ScrollBackButton 2023-02-26 14:39:34 -08:00
d98d330da2 Add expected behavior test for scroll back to previous position 2023-02-26 14:30:46 -08:00
dd9748a25c Adjust DrawNodes to use UBOs 2023-02-25 01:42:55 +09:00
6307b3948a style: use Trigger initialisation 2023-02-22 17:59:39 +00:00
d679703fa2 Merge pull request #22659 from peppy/fix-taiko-drum-nested-sample-detection
Fix `GameplaySampleTriggerSource` not considering nested objects when determining the best sample to play
2023-02-22 18:56:59 +01:00
1beec71037 refactor(KeyCounterDisplay): apply suggestions
I also took the freedom to add type checking, as we can't limit the
usage of `Add()` since it's a Container. The exception thrown also
advises of using the suggested `AddTrigger()` instead.
2023-02-22 14:58:27 +00:00