Commit Graph

2111 Commits

Author SHA1 Message Date
12b7d9e06d Simplify custom filter criteria retrieval 2021-03-06 12:16:01 +01:00
f733d1ec1f Expose and document query parser and helpers 2021-03-03 22:03:01 +01:00
f9148eec20 Refactor filter query parsing helper methods
In preparation for exposition as public.
2021-03-03 21:34:14 +01:00
42c3309d49 Use ruleset criteria in parsing and filtering 2021-03-02 20:11:21 +01:00
c375be6b07 Instantiate ruleset criteria 2021-03-02 20:10:03 +01:00
e46543a4a9 Constrain operator parsing better 2021-03-02 19:56:36 +01:00
26736d990f Enable filter parsing extensibility 2021-03-02 19:42:47 +01:00
d0decc73be Merge branch 'master' into beatmap-difficulty-cache-nullable 2021-02-25 19:40:38 +01:00
a792c3f13c Merge pull request #11900 from peppy/update-bpm-with-mods
Update the displayed BPM at song select with rate adjust mods
2021-02-26 00:25:55 +09:00
01a4815412 Make labels disappear on null beatmap/no hitobjects 2021-02-25 23:36:02 +09:00
46ea0f44eb Merge branch 'master' into beatmap-difficulty-cache-nullable 2021-02-25 22:52:15 +09:00
c1f27ba938 Merge branch 'master' into fix-song-select-star-rating-display-zero-flashing 2021-02-25 22:13:48 +09:00
c3eb44137b Move ValueChanged bind back to load() 2021-02-25 22:09:41 +09:00
649ce20e35 Fix up super weird and super wrong DI 2021-02-25 22:01:53 +09:00
b090a82b35 Merge branch 'master' into update-bpm-with-mods 2021-02-25 21:58:54 +09:00
de417a660d Make BPM update with changes in mod settings 2021-02-25 21:51:32 +09:00
98313a98bf DI mods in parent class and pass them down 2021-02-25 21:48:02 +09:00
2db4b793d7 Also handle most common BPM display 2021-02-25 17:05:00 +09:00
31c52bd585 Update the displayed BPM at song select with rate adjust mods
This only covers constant rate rate adjust mods. Mods like wind up/wind
down will need a more complex implementation which we haven't really
planned yet.
2021-02-25 17:00:44 +09:00
03771ce8ec Allow determining a BeatmapDifficultyCache's bindable return's completion state via nullability 2021-02-25 16:19:01 +09:00
9f3ceb99eb Fix the star rating display at song select flashing to zero when changing mods
Due to the use of bindable flow provided by `BeatmapDifficultyCache` in
this usage, the display would briefly flash to zero while difficulty
calculation was still running (as there is no way for a consumer of the
provided bindable to know whether the returned 0 is an actual 0 SR or a
"pending" calculation).

While I hope to fix this by making the bindable flow return nullable
values, I think this particular use case works better with non-bindable
flow so have switched across to that.
2021-02-25 16:05:13 +09:00
e82eaffaed Flip order back to original for romanisable strings 2021-02-25 14:14:07 +09:00
a362382d38 Add back more correct null checks 2021-02-25 14:06:21 +09:00
8a97e2e28d Update LocalisedString usages to RomanisedString 2021-02-22 19:01:42 +09:00
1fd76ea3fb Apply changes to UI components overriding functions with changing signatures 2021-02-22 19:01:42 +09:00
6240d3964c Merge pull request #11817 from peppy/fix-collection-dropdown-cross-thread-manipulation
Fix potential crash from cross-thread drawable manipulation in CollectionFilterDropdown
2021-02-19 10:06:42 +09:00
46b67dd7bc Merge pull request #11821 from peppy/fix-carousel-border-additive-alplha
Fix carousel items' borders getting blown out when selected and hovered
2021-02-18 17:45:58 +09:00
b713eb2eae Make field readonly 2021-02-18 17:13:48 +09:00
c3a98b6ad1 Fix carousel items' borders getting blown out when selected and hovered
I tried restructuring the hierarchy to avoid needing this added property
(moving the hover layer out of the border container) but this leads to
some subpixel leakage outside the borders which looks even worse.

Closes #6915.
2021-02-18 16:59:44 +09:00
421cdb6650 Consume new method in existing usages (and remove some unnecessary set/unset code) 2021-02-18 15:01:11 +09:00
90dce52042 Fix potential crash from cross-thread drawable manipulation in CollectionFilterDropdown 2021-02-18 14:10:28 +09:00
d3f0c0730d Merge branch 'master' into non-concurrent-sample-playback 2021-02-12 17:22:15 +09:00
cd01591dda Consume new debounce logic in carousel header 2021-02-12 12:22:35 +09:00
98c5b0220c Merge pull request #11725 from smoogipoo/freemods-user-settings
Add local user customisation for freemod mod settings
2021-02-11 16:02:24 +09:00
eaa7b4cb93 Rename second usage variable name to match 2021-02-11 14:54:50 +09:00
6fff7c39da Ensure tracker is disposed 2021-02-10 20:09:45 +09:00
393cd6c74a Add helper class for tracking changes to mod settings 2021-02-10 19:40:07 +09:00
bc7f4a4f88 Use a single sample for CarouselHeader on-hover with randomised pitch instead of multiple samples 2021-02-10 17:53:47 +09:00
69ca440ae5 Merge branch 'master' into more-accurate-most-common-bpm 2021-02-08 18:40:58 +09:00
3e750feaa4 Subclass LocalPlayerModSelectOverlay to correctly deselect incompatible mods on free mod selection 2021-02-05 16:42:35 +09:00
97e3023df9 Renamespace/rename MatchSongSelect -> PlaylistsSongSelect 2021-02-01 20:16:58 +09:00
9c4c47599f Merge branch 'master' into freemods 2021-02-01 19:28:10 +09:00
89a42d60fb General cleanup 2021-02-01 18:50:32 +09:00
426569c2a9 Move common song select implementation for online play 2021-02-01 14:57:39 +09:00
230b347c1e Move ModSelectOverlay.IsValidMod to a property 2021-02-01 12:18:11 +09:00
45e41aaeac Initial implementation of freemod selection overlay 2021-01-27 22:15:53 +09:00
4019cc38e5 Allow footer buttons to be customised 2021-01-27 22:03:51 +09:00
91d34d86f7 Abstractify ModSelectOverlay 2021-01-27 22:02:23 +09:00
a6516e3be5 Merge branch 'master' into scroll-to-20 2021-01-21 14:28:17 +09:00
7c4a072568 Merge branch 'master' into scroll-to-20 2021-01-21 13:48:26 +09:00