a1152fa0db
Merge pull request #22147 from Feodor0090/forbid-negative-snap
...
Forbid negative time snap in editor
2023-01-17 17:35:45 +09:00
a9facc076f
Fix difficulty creation flow failing for some ruleset combinations
...
In current `master`, the difficulty creation flow would retrieve a
"reference beatmap" to copy metadata and timing points from using
`GetPlayableBeatmap()`. But, importantly, it was calling that method
using *the ruleset of the new difficulty* rather than the ruleset of the
existing one. This would make the difficulty creation flow fail if the
beatmap couldn't be converted between rulesets (like taiko to catch).
Fixing to use the reference beatmap's actual ruleset would be trivial,
but there's no real reason to do all of that work anyway when a
`WorkingBeatmap` is available. Because getting a playable beatmap is not
required to copy across metadata and timing points, remove the
`GetPlayableBeatmap()` step entirely to fix the bug.
Closes #22145 .
2023-01-14 19:46:55 +01:00
51e21ee6f0
Make snapped time always positive
2023-01-12 03:38:57 +03:00
5ee0665eac
Merge branch 'master' into pause-imports-during-gameplay
2023-01-09 20:09:17 +03:00
811a562608
Don't use bindables to avoid potential cross-usage contamination
2023-01-10 01:10:20 +09:00
07dae7dc21
Merge branch 'master' into overlay-panels-context-menu
2023-01-09 19:04:56 +09:00
62ffb4fe78
Pause imports during active gameplay
2023-01-09 18:54:11 +09:00
0f6735564e
Move and rename nomination response model to singular
2023-01-07 10:54:48 -08:00
f908b25dab
Merge pull request #22033 from frenzibyte/decrease-difficulty-list-fadeout
...
Decrease transition duration of extended difficulty list during hide
2023-01-06 20:13:30 +08:00
c0cfa66510
Merge pull request #21754 from Feodor0090/waveform-invalidate
...
Reload waveform on track replacement in editor
2023-01-06 19:57:27 +08:00
8da7667b0b
Decrease transition duration of extended difficulty list during hide
2023-01-05 14:22:17 +03:00
4491a5ba9f
Fix editor exporting beatmap combo colours in wrong order
2023-01-03 13:41:08 +03:00
182f36c434
Use StringSplitOptions.TrimEntries for string.Split() when possible
2022-12-27 09:41:58 +01:00
bb58976838
Merge remote-tracking branch 'upstream/master' into overlay-panels-context-menu
2022-12-26 17:54:15 -08:00
cb2b0d4178
Remove redundant type specs
2022-12-26 23:12:53 +01:00
fcbb21c75e
Fix typo
2022-12-26 20:38:35 +01:00
c7ca4bbba5
Use generic Enum methods
2022-12-26 20:36:39 +01:00
b9dfb8b602
Add localisation for context menu strings
2022-12-25 10:12:02 -08:00
2c2f347e25
Add context menus to overlay panels/cards
2022-12-25 09:57:42 -08:00
30de9ba795
Dispose previous waveform on track reload
2022-12-23 00:35:59 +03:00
08d2fbeb8e
Use new ArgumentNullException.ThrowIfNull throw-helper API
2022-12-22 21:27:59 +01:00
20370bd5ae
Invalidate waveform on track load
2022-12-22 20:49:09 +03:00
d0645ce151
Rewrite waveform invalidation
2022-12-22 15:59:51 +03:00
66a02374da
Clear cached waveform on track change in editor
2022-12-22 01:23:24 +03:00
4a7d7c6ed9
Use MaxBy in all locations that can and update inspection level to match dotnet-build
2022-12-19 16:47:10 +09:00
192536643c
Fix some more inspections
2022-12-16 20:21:19 +09:00
de079e08dc
Fix incorrect ConfigureAwait call in ImportAsUpdate
2022-12-16 18:54:56 +09:00
ba54551313
Merge branch 'master' into guard-url-protocols
2022-12-16 18:23:16 +09:00
27c497145f
Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0
2022-12-16 18:16:26 +09:00
b8904fe747
Move ImportParameters to better home
2022-12-13 21:41:26 +09:00
cb16d62700
Hook up ImportParameter flow with IModelImporter caller methods
2022-12-13 21:29:32 +09:00
cf2719d4c0
Convert batchImport parameter to parameters class to allow further import configuration
2022-12-13 19:55:18 +09:00
902dff15e3
Add todo regarding validity check
2022-12-12 13:44:09 +09:00
94cfcdb338
Remove SmoothCircularProgress usage in BeatmapCardThumbnail
2022-12-03 16:16:21 +03:00
809d02cda0
Fix two implementation oversights
2022-12-02 16:05:14 +09:00
896f2d8f74
Fix multiple instances of last hitobject time being calculated incorrectly
2022-12-01 18:04:06 +09:00
7bc8908ca9
Partial everything
2022-11-27 00:00:27 +09:00
985781bc3b
Merge pull request #21356 from peppy/standardise-broken-storyboard-paths
...
Add support for storyboards with incorrect path specifications (`\\` instead of `\`)
2022-11-22 14:33:51 +09:00
2774c1ea49
Merge pull request #21215 from jai-x/triangles-bundled-beatmap
...
Add winner of Triangles mapping competition as a bundled beatmap
2022-11-21 16:22:23 +09:00
3da21e596a
Add support for storyboards with incorrect path specifications (\\ instead of \)
...
Closes https://github.com/ppy/osu/issues/21204 .
2022-11-21 16:12:01 +09:00
4578a96813
Fix beatmap card expanded content not blocking clicks from behind
2022-11-13 08:18:44 -08:00
c5cb4e4e7d
Add winner of Triangles mapping competition as a bundled beatmap
...
https://osu.ppy.sh/home/news/2022-10-06-results-triangles
2022-11-12 17:48:40 +00:00
064a245c50
Don't trim whitespace from variable keys / values
2022-11-08 13:30:11 +09:00
b764d1bd04
Decode variables earlier in flow in case they include indent logic
...
Without this change, the `depth` calculation could be incorrect.
2022-11-08 13:29:42 +09:00
bd512c4937
Remove equality comparison implementation from BeatmapCard
...
This turned out to be a hurdle instead as it disallows adding two
beatmap cards of equal beatmap, which, while being a good behaviour in
client, makes tests more complicated to work.
2022-11-04 19:27:20 +03:00
07bfac40fa
Adjust padding to avoid overlap with card border when expanded
2022-11-03 14:03:28 +09:00
66a6084d3f
Scale in the background fill alongside the icon
2022-11-03 14:03:19 +09:00
df9f49eef2
Move hover layer behind icon
...
Looked bad on the "already downloaded" state where the icon becomes
black.
2022-11-03 13:56:07 +09:00
fb0bc597a0
Merge branch 'master' into improve-beatmap-card-buttons
2022-11-03 13:53:29 +09:00
978d15955c
Fix control points not being cloned when running beatmap conversion
...
Closes #20994 .
I haven't considered how this affects performance of difficulty
calculation or otherwise. Seems like a sane initial fix which we can
iterate on going forward.
I've tested using the scenario in the linked issue.
I'm not going to add test coverage because
[BeatmapConversionTest](https://github.com/ppy/osu/blob/master/osu.Game/Tests/Beatmaps/BeatmapConversionTest.cs )
should correctly cover this scenario once we are serialising control
points as well.
2022-11-01 17:42:09 +09:00
