54982dcdd7
Refactor LoadingLayer to avoid applying effects to external drawables
...
In theory this seemed like a good idea (and an optimisation in some
cases, due to lower fill rate), but in practice this leads to weird edge
cases.
This aims to do away with the operations on external drawables by
applying a dim to the area behind the `LoadingLayer` when required.
I went over each usage and ensured they look as good or better than
previously.
The specific bad usage here was the restoration of the colour on dispose
(if the `LoadingLayer` was disposed in a still-visible state).
I'm aware that the `BeatmapListingOverlay` will now dim completely during
load. I think this is fine for the time being.
2021-01-05 17:31:45 +09:00
206bf3713e
Make IAPIProvider read-only bindables into IBindables
2020-12-18 15:16:36 +09:00
53e083f329
Merge branch 'master' into show-loved-pp
2020-03-11 01:08:13 +09:00
9aacc3f5ae
Replace Scores property with DisplayScores method
...
Also adds null checks to prevent crashes in tests.
2020-03-04 19:24:52 +01:00
f661806513
Move checking logic out of ScoreTable
2020-02-29 15:29:00 +01:00
63006e8672
Refactor to avoid visual inconsistency for beatmaps with no leaderboard
2020-02-22 03:40:59 +03:00
623b78d675
Combine all loading animation implementations
2020-02-21 15:32:46 +09:00
db4fe4f728
Merge branch 'master' into adjust-beatmap-overlay
2020-02-21 09:52:44 +09:00
958c891d15
Update with framework-side bindable list changes
2020-02-17 15:06:14 +09:00
4d180a685a
Adjust font sizes and spacing in BeatmapSetOverlay
2020-02-16 21:43:33 +01:00
c93d2c7f00
Adjust loading container corner radius
2020-02-05 18:26:01 +01:00
f30cdab025
Update Scores section
2020-02-04 14:35:04 +03:00
f0d49d0cdf
Decouple APILegacyScoreInfo from ScoreInfo
2019-12-03 15:31:11 +09:00
c0fe91a84c
Merge branch 'master' into sharpen
2019-11-26 18:21:50 +08:00
96533631fc
Simplify if/else statement
2019-11-24 01:29:11 +03:00
29b05e2939
Fix getScores can be fired twice on user change
2019-11-24 00:01:49 +03:00
2e161f7e99
Hook up the rest of the logic
2019-11-22 22:25:58 +03:00
aede1b183a
Make ScopeSelector always visible
2019-11-22 22:04:58 +03:00
d6c9387beb
Implement NotSupporterPlaceholder
2019-11-22 21:55:21 +03:00
b026197859
Add spacing
2019-11-22 18:23:48 +09:00
dad2e5c678
Improve legibility of NoScroesPlaceholder
2019-11-22 18:10:44 +09:00
0cc1698b6d
Rename incorrectly named container
2019-11-22 18:05:12 +09:00
da425c93fa
Fix beatmap switch doesn't trigger scores update
2019-11-22 05:08:50 +03:00
dee9ffc694
Merge master with conflicts resolved
2019-11-22 04:59:46 +03:00
18f77008db
Update dependency
2019-11-15 12:04:01 +03:00
2d3fadc1a8
Don't update mod filter visibility on every beatmap change
2019-11-14 00:38:37 +03:00
633c497602
Hide content if beatmap has no leaderboard
2019-11-13 17:36:08 +03:00
8005ee73af
Trim whitespace
2019-11-13 17:23:46 +03:00
3f6140db6d
Improve loading animation
2019-11-13 17:18:58 +03:00
4e90daf212
Implement NoScoresPlaceholder
2019-11-13 16:39:33 +03:00
5f609b48da
Use local bindable for api.LocalUser
2019-11-13 00:29:28 +03:00
ca52d09e81
Enforce expression body for typical simple ones.
2019-11-12 19:56:37 +08:00
0578f91a76
Small logic adjustments
2019-11-11 19:06:46 +03:00
c5b64e26a3
Layout adjustment
2019-11-11 18:51:29 +03:00
5f5d130d1a
Update mod filter visibility on user change
2019-11-11 18:40:57 +03:00
31191dadf1
Handle mods change
2019-11-11 18:31:42 +03:00
2cfd54ca0d
Handle scope changing
2019-11-11 18:27:48 +03:00
00b9229737
Add mod filter to beatmap overlay
2019-11-11 18:21:07 +03:00
32b2f5e330
Use Bindable for ScoresContainer
2019-11-11 18:10:25 +03:00
b9384d7a53
Remove unnecessary null check
2019-08-07 07:00:50 +03:00
24f9872315
Fix unnecessary scores loading
2019-08-07 06:45:39 +03:00
2a94b68ecb
Simplify logic
2019-07-20 22:50:17 +09:00
fa978a47b0
Fix loading animation is no longer present
2019-07-18 15:08:50 +03:00
8f9b8ed5a1
Simplify information propagation logic
2019-07-11 11:17:33 +09:00
cc9ee472d6
Move score nulling out of loading property
2019-07-11 11:07:30 +09:00
a49bde7ed3
Move protected below public
2019-07-11 10:38:32 +09:00
953d32366c
Move request inside the ScoresContainer again
2019-07-10 19:40:29 +03:00
9907a58ec4
Revert animations and apply suggested changes
2019-07-09 17:38:17 +03:00
e8b9b1b0bf
visibility logic adjustments
2019-07-09 12:16:58 +03:00
8d6af1625a
Visibility improvements
2019-07-09 11:40:51 +03:00
