Commit Graph

36686 Commits

Author SHA1 Message Date
fea0895f16 Call spectator EndPlaying() immediately after score submission
As it turns out, in current `master`, if a gameplay session ends
normally (i.e. by the player completing the beatmap in full), then
the spectator server `EndPlaying()` method will not be called until
`SubmittingPlayer.OnExiting()`, which in practice turns out to be
the moment where the user exits from the post-gameplay results screen
back to song select.

There is seemingly no reasonable cause for not calling this earlier. In
fact the solo spectator flow looks more broken without this call than
with, because without it the spectator view just hangs until the
spectated player exits gameplay, and *only then* shows results, rather
than do it upon normal gameplay completion.
2022-12-17 21:35:43 +01:00
813c351607 Fix breadcrumb tab item click area not extending to background height 2022-12-16 21:44:10 -08:00
192536643c Fix some more inspections 2022-12-16 20:21:19 +09:00
dd9a418549 Fix assembly location lookups 2022-12-16 19:19:59 +09:00
de079e08dc Fix incorrect ConfigureAwait call in ImportAsUpdate 2022-12-16 18:54:56 +09:00
ba54551313 Merge branch 'master' into guard-url-protocols 2022-12-16 18:23:16 +09:00
27c497145f Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0 2022-12-16 18:16:26 +09:00
d5b2c7dfe9 Clamp SFX panning on results screen 2022-12-16 17:19:07 +09:00
d6cae991da Update netstandard2.1 references to net6.0 2022-12-16 17:16:13 +09:00
e63b544167 Update framework 2022-12-16 17:02:51 +09:00
ce408eaac0 Merge branch 'net6-ios' into guard-url-protocols 2022-12-16 17:02:32 +09:00
cbee72897a Merge pull request #21654 from Susko3/use-localisable-strings-for-dates-and-times
Use `LocalisableString`s for date and time formats
2022-12-16 16:17:14 +09:00
232f590ba3 Merge pull request #21628 from peppy/go-hard-file-writes
Use hard links on windows when importing beatmaps from a legacy osu! install
2022-12-16 14:52:57 +09:00
0f34d908c7 Use LocalisableStrings for date and time formats 2022-12-16 00:05:47 +01:00
5fbd4ad3b4 Update usages of SupportsJIT in line with framework changes 2022-12-16 00:22:11 +03:00
660cc72f2a Avoid configuring web proxies on iOS for now 2022-12-16 00:22:11 +03:00
9813bc9544 Reword disclaimer and fix translation keys 2022-12-15 22:46:31 +09:00
91adf2e80f Apply the wala-hyphen
Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>
2022-12-15 22:44:47 +09:00
d2b98b803d Turn on featured artist filter by default and add disclaimer when toggling for the first time 2022-12-15 18:42:47 +09:00
0763b86236 Add more padding around text in dialog popups 2022-12-15 17:32:27 +09:00
78bc94d3cb Set featured artists filter to enabled by default 2022-12-15 16:57:39 +09:00
a7f3e13946 Fix MultipleSelectionFilter not correctly handling initial selection 2022-12-15 16:56:09 +09:00
6bf1477939 Fix some hard links not being created due to missing directory structure
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-12-15 14:17:28 +09:00
fb85eaee95 Add description for lazer score version 30000001 2022-12-14 18:30:33 +09:00
50dc76d579 Merge pull request #21618 from smoogipoo/multi-spec-only-local-results
Only show local results in multi-spectator results screen
2022-12-14 14:00:02 +09:00
a3c3112f89 Add SetLastError hint to CreateHardLink pinvoke method
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-12-14 11:34:06 +09:00
f4316a9827 Fix incorrect grammar in hard link explanation text
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-12-14 11:30:01 +09:00
849245b90c Merge branch 'master' into beginplaying-score-token 2022-12-13 17:15:24 +01:00
dfb8f4fdd9 Merge branch 'master' into buttons-fix 2022-12-13 16:35:03 +01:00
3d65984a89 Update framework 2022-12-13 22:34:01 +09:00
bf56f5f8c0 Show error message on attempting to open a URL with an unsupported protocol 2022-12-13 22:33:56 +09:00
efe057176e Make OsuButton abstract 2022-12-13 22:13:48 +09:00
edc78205d5 Add comments about why both positional input checks are required in OsuClickableContainer 2022-12-13 22:12:52 +09:00
b8904fe747 Move ImportParameters to better home 2022-12-13 21:41:26 +09:00
cb16d62700 Hook up ImportParameter flow with IModelImporter caller methods 2022-12-13 21:29:32 +09:00
6bb612ce69 Move hard link availability check to helper class 2022-12-13 20:20:42 +09:00
bbf931c746 Move hard link helper functions to their own class 2022-12-13 19:55:18 +09:00
1d4230993d Hook up parameter with RealmFileStore to complete the chain 2022-12-13 19:55:18 +09:00
cf2719d4c0 Convert batchImport parameter to parameters class to allow further import configuration 2022-12-13 19:55:18 +09:00
ad7554cc7d Allow keeping stream open after encoding scores 2022-12-13 16:15:14 +09:00
15bd82add8 Fix DrawableUsername being affected 2022-12-12 18:24:49 +03:00
890dd9cd06 Fix input doesn't take original drawable modifications into account 2022-12-12 15:10:03 +03:00
b0d475cd8b CI fix 2022-12-12 14:57:07 +03:00
d2b3533356 Fix OsuClickableContainer input receiving 2022-12-12 14:42:54 +03:00
7e39f171fb Fix OsuButton input receiving 2022-12-12 14:42:54 +03:00
5800734589 Merge pull request #21587 from smoogipoo/spectatorstate-maximum-statistics
Store maximum statistics to spectator state
2022-12-12 20:00:52 +09:00
df94af4495 Inline ScoringValues and make some more methods private inside ScoreProcessor 2022-12-12 19:22:09 +09:00
7b48c91fe2 Only show local results in multi-spectator results screen 2022-12-12 18:56:43 +09:00
02b3bbf0d3 Merge pull request #21616 from Joehuu/changelog-build-masking
Fix changelog single build dates disappearing before being off screen
2022-12-12 18:28:48 +09:00
05b5949810 Use explicit casts 2022-12-12 17:38:39 +09:00