Commit Graph

29801 Commits

Author SHA1 Message Date
5f6c35a577 Merge pull request #9215 from bdach/hold-note-release-hitsounds
Fix incorrect sample choices for hold notes
2020-06-08 10:51:57 +09:00
35574f30e7 Merge branch 'master' into hold-note-release-hitsounds 2020-06-08 10:19:59 +09:00
36d318d4dc Merge pull request #9188 from bdach/contributing-guidelines
Add contributing guidelines
2020-06-07 21:48:04 +09:00
b41384dde8 Merge branch 'master' into multiplayer-beatmap-checksum 2020-06-07 18:05:33 +09:00
efd5e14410 Clarify why ruleset bindable must be set at the BDL of any base test scene 2020-06-06 19:20:06 +03:00
0f78af7252 Remove unnecessary disabled check
I have a bad memory here, til.
2020-06-06 19:19:30 +03:00
c3036c1d45 Merge pull request #9197 from peppy/better-reimport-support
Check all files match before using an existing archive model
2020-06-05 22:02:36 +09:00
2ad5b2065f Merge branch 'master' into better-reimport-support 2020-06-05 20:59:55 +09:00
bb89114b70 Show a loading spinner on multiplayer lounge loads 2020-06-05 20:52:27 +09:00
0107e9ba16 Change lookups to use SingleOrDefault() 2020-06-05 19:18:00 +09:00
caf94df0d0 Merge branch 'master' into multiplayer-beatmap-checksum 2020-06-05 19:16:05 +09:00
896177801a Avoid creating copies of node samples every time 2020-06-05 00:07:27 +02:00
4c6116e6e7 Fix compilation failure in Android test project 2020-06-04 23:50:58 +02:00
c4cae006aa Correctly slice node sample list when converting 2020-06-04 22:47:39 +02:00
ac019bddd6 Only play samples at start of hold note in mania maps 2020-06-04 22:33:34 +02:00
35544ede50 Add failing test cases 2020-06-04 22:33:30 +02:00
6b88141e58 Add mania sample conversion test 2020-06-04 21:53:37 +02:00
5d1770dec8 Merge pull request #9212 from smoogipoo/fix-scorepanel-input
Fix score panel not receiving input in some places
2020-06-05 00:26:02 +09:00
bd2e4c50dd Merge pull request #9211 from smoogipoo/change-date-format
Change format of date on score panel
2020-06-04 23:31:28 +09:00
2ec7059ac4 Merge pull request #9213 from smoogipoo/fix-keybinding-crash
Fix crash when double-clicking clear binding button
2020-06-04 23:31:02 +09:00
9c1542f897 Fix crash when pressing clear button twice 2020-06-04 22:17:00 +09:00
afcefe01bf Fix score panel not receiving input in some places 2020-06-04 21:48:55 +09:00
5d7bb8cb4e Change format of date on score panel 2020-06-04 21:33:38 +09:00
9920911390 Fix tournament displayed beatmap potentially being out of order on quick changes 2020-06-04 17:20:08 +09:00
741fa20149 Use CreateRuleset() for editor test scenes as well 2020-06-04 00:47:10 +03:00
c72592c52c Remove bindable-disabling logic and don't tie immediately to CreateRuleset() 2020-06-04 00:44:28 +03:00
af3daaaeaf Add reference to contributing guidelines in README 2020-06-03 23:44:02 +02:00
ddf5282d0e Move items from README.md to contributing guidelines 2020-06-03 23:44:02 +02:00
c2fd2b8616 Add notes about draft PRs & pushing 2020-06-03 23:43:32 +02:00
bbad70c3f0 Fix mod perfect test scenes failing due to null ruleset provided
Just a workaround for now, a better fix may be to put the test data creation in an action that is guaranteed to be invoked after the test scene has fully loaded (all dependencies would've been resolved by then).
2020-06-04 00:43:11 +03:00
136e10086a Set the ruleset bindable value at the BDL for its subclasses usages
There are test scenes using current value of ruleset bindable on their BDL (example in TestSceneSliderSnaking's BDL)
2020-06-04 00:37:06 +03:00
8529486a5c Merge branch 'master' into contributing-guidelines 2020-06-03 23:09:35 +02:00
11da045d8c Reorder declaration position of ruleset-creation methods
Should be recognized as a normal protected method in its declaring class.
2020-06-03 23:43:18 +03:00
611f64fd36 Add base ready-made abstract scene for osu! mod tests 2020-06-03 23:24:00 +03:00
84b40ea2c6 Merge remote-tracking branch 'upstream/master' into test-scene-create-ruleset
# Conflicts:
#	osu.Game.Rulesets.Catch.Tests/TestSceneBananaShower.cs
#	osu.Game.Rulesets.Catch.Tests/TestSceneHyperDash.cs
#	osu.Game/Tests/Visual/ModTestScene.cs
#	osu.Game/Tests/Visual/OsuTestScene.cs
2020-06-03 22:00:02 +03:00
66ec2afe5c Remove broken import test 2020-06-03 23:38:40 +09:00
5ed3cd205f Simplify reuse check using FileInfo IDs 2020-06-03 23:35:56 +09:00
c4698e61ec Merge pull request #9195 from peppy/fix-multi-chat-history
Fix chat history not being loaded for multiplayer matches
2020-06-03 22:49:27 +09:00
f6d9f0597b Add implicit join logic for multiplayer rooms 2020-06-03 21:28:29 +09:00
25160dc220 Fix test name 2020-06-03 19:15:52 +09:00
6133c7d747 Change suggestion to warning 2020-06-03 18:51:02 +09:00
012933545e Add test coverage 2020-06-03 18:33:41 +09:00
c155ab8339 Check filenames and timestamps before reusing an already imported model 2020-06-03 18:03:10 +09:00
3c7e5a5b42 Fix ChannelManager not being loaded in tests 2020-06-03 18:00:31 +09:00
c0881e14ab Add "struct can be made readonly" inspection 2020-06-03 17:44:14 +09:00
092f5b6521 Fix incorrect reference + simplify 2020-06-03 17:41:05 +09:00
1ba3f0ac14 Fix chat history not being loaded for multiplayer matches 2020-06-03 17:31:55 +09:00
8aa8d2c880 Resolve NREs 2020-06-03 16:59:37 +09:00
f3b5149648 Move some suggestions to warnings, resolve issues 2020-06-03 16:48:44 +09:00
73467410ab Merge pull request #9192 from peppy/fix-redundant-override
Fix redundant override showing up in build warnings
2020-06-03 16:15:33 +09:00