764f0323f4
Show "rewind" text on random button when beginning a right mouse press
2023-05-17 14:51:40 +09:00
94b184712d
Fix random button hover state not correctly being reset on right click
2023-05-17 14:51:40 +09:00
444f66b0ee
Move to base class for added safety
2023-05-03 18:46:30 +09:00
cd31cff8cd
Fix event subscriptions not being cleaned up in DrawableCarouselBeatmap
...
The handling of cleanup is performed only the `Item_Set` method. This
was already correctly called for `DrawableCarouselBeatmapSet`, but not
for the class in question here.
This would cause runaway memory usage at song select when opening many
beatmaps to show their difficulties. For simplicity, we don't yet pool
these (and generate the drawables each time a set is opened) which isn't
great but likely will be improved upon when we update the visual /
filtering of the carousel. But this simplicity caused the memory usage
to blow out until exiting back to the main menu when cleanup would
finally occur.
2023-05-03 18:41:30 +09:00
c80a25328d
Shorten label to just "matches"
2023-04-17 20:59:41 -07:00
d0cbe206a9
Revert back to one number with "matching beatmap difficulties" label
2023-04-10 23:37:29 -07:00
f0c8a3202b
Merge remote-tracking branch 'upstream/master' into fix-beatmap-terminology
2023-04-10 23:22:15 -07:00
f80de08f24
Adjust BeatmapSetsChanged xmldoc
...
Co-Authored-By: Dean Herbert <pe@ppy.sh >
2023-04-10 11:28:23 -07:00
c7dea71793
Use existing BeatmapSetsChanged action
2023-04-10 11:26:18 -07:00
7f5b99c91b
Fix song select beatmap difficulty count not updating when deleting
2023-04-09 22:12:51 -07:00
8b30c67580
Fix incorrect song select matching label by showing both beatmap and difficulty count for less ambiguity
2023-03-26 18:08:28 -07:00
425be20e46
Fix song select search textbox font size incorrectly having increased
2023-03-22 14:17:39 +09:00
5cb8160eee
Merge pull request #22773 from peppy/show-song-select-visible-beatmap-count
...
Show count of visible beatmaps at song select
2023-03-21 18:22:29 +09:00
ea8da69263
Fix importing beatmaps not changing count of visible beatmaps
...
Reproduction steps:
1. Go to song select
2. Open beatmap listing
3. Import a beatmap that would fit the current filter criteria
4. The count of visible beatmaps does not change
Fixed by updating the count on `BeatmapSetsChanged` too.
2023-03-20 20:53:53 +01:00
695ee39b87
Privatise setter
2023-03-20 20:30:54 +01:00
556964eae0
Merge branch 'master' into BitmapUpdatesOnScore
2023-03-16 12:16:42 +03:00
cd102da3af
Move matches string inside text box
2023-03-16 16:34:31 +09:00
89b42ddd98
Don't localise beatmap count string for now
2023-03-16 15:02:38 +09:00
6c5ccdfd90
Merge branch 'master' into optimise-search
2023-03-07 22:07:29 +01:00
5213bfa5c9
Merge branch 'master' into make_skin_reset_dangerous
2023-03-07 21:06:44 +01:00
5af41bb1c8
Move filter matching code into own method to simplify early returns
2023-03-07 17:24:17 +09:00
87d0bef313
Use nullable comparison helper method instead of manual implementation
2023-03-06 15:16:32 +09:00
908651cc11
make ResetConfirmDialog properly utilise its parent's logic
...
Adjust name of `DeleteAction` to `DangerousAction`
2023-03-05 20:57:26 +01:00
70a925aab1
added extra early-returns
2023-03-04 16:49:33 +01:00
b90c389ff0
using List instead of Span in GetSearchableTerms
2023-03-04 15:42:35 +01:00
91d206e8d2
Optimised GetSearchableTerms
...
Reduced memory allocations to 1
2023-03-03 19:21:50 +01:00
82293c0c86
Don't filter away results with missing data when using "Date Submitted" or "Date Ranked" sort modes
...
From a user's perspective, changing a sort / order mode shouldn't filter
away results, but we were doing this.
In terms of UX expectations, in stable this kind of scenario would
results in a group being added to the end of son select with "Not
ranked" or "Unknown". I think we should aim to match this eventually.
2023-03-03 16:36:18 +09:00
dc669835e2
Show count of visible beatmaps at song select
2023-03-03 15:28:51 +09:00
90227a6496
Rename DeleteConfirmationDialog.cs into DangerousActionDialog.cs
2023-02-27 21:57:59 +01:00
6afa65bd3d
Merge branch 'master' into skinnable-clean-up-documentation
2023-02-17 20:59:18 +01:00
394d368f16
Fix song select potentially updating background parameters when not the current screen
2023-02-16 18:45:22 +09:00
a92e42bb84
Rename SkinnableTargetContainer to SkinComponentsContainer
...
Also use full `SkinComponentsContainerLookup` instead of the sub-type.
This will potentially be useful once we bring in per-ruleset targets.
2023-02-15 18:37:41 +09:00
9ed068c1e6
Only apply dim changes when background blur is disabled
2023-02-15 14:16:34 +09:00
19e3c5d33c
Adjust song select background dimming to be more evenly applied
2023-02-15 13:59:24 +09:00
51d4ae5241
Merge branch 'master' into footer_V2_implementation
2023-02-14 14:00:53 +09:00
f0ebb920b9
Make Actions nullable
2023-02-14 13:54:00 +09:00
5006dbe3db
Update osu.Game/Screens/Select/FooterV2/FooterButtonV2.cs
...
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com >
2023-02-14 00:07:02 +01:00
ae9a17d76b
Add offset to FooterButtonV2.cs shadow
2023-02-13 22:20:41 +01:00
be52d0a60c
Add note explaining shadow opacity
...
pass ColourProvider in from test, instead of hard coding it in `FooterButtonV2.cs`
2023-02-13 22:18:34 +01:00
61584ba63c
Fix corner_radius missing in some parts of FooterButtonV2.cs.
...
Adjust shadow radius value to 5 to match figma.
2023-02-13 22:15:29 +01:00
6e6421caea
Change FooterV2.cs colour to use ColourProvider instead of OsuColour.
...
Remove unnecessary `FillFlowContainer`
2023-02-13 22:12:25 +01:00
7e127dafe2
Update reference
2023-02-07 11:52:47 +03:00
2c7386db39
FIx score appearing on BeatmapLeaderboard and TopLocalRank
2023-02-06 15:14:14 +03:00
ddcc02fdfe
Merge pull request #22505 from Joehuu/fix-hover-click-sounds
...
Fix some clickable elements having no hover and click sounds
2023-02-06 16:52:19 +09:00
5a76c1ab9c
Refactor HoverSampleDebounceComponent to inherit Component
2023-02-03 00:29:25 -08:00
4ec46c7476
Merge branch 'master' into footer_V2_implementation
2023-02-03 16:30:16 +09:00
48f7e0163c
Adjust comments and formatting of comments
2023-02-03 16:27:20 +09:00
4248453616
Use FinishTransforms rather than manual duplication of background colour logic
2023-02-03 16:27:20 +09:00
a1200b8fe8
Adjust footer button colour handling to read better and take into account mouse down
2023-02-03 16:27:20 +09:00
f7094567d7
Rename and document method to limit scope
2023-02-03 15:04:47 +09:00
