Commit Graph

8735 Commits

Author SHA1 Message Date
ec1a7994cc Switch method to statement body for better readability
Almost thought the method was not wrapped in an `AddStep`.
2022-07-30 10:11:01 +03:00
0c125db197 Fix potential nullref on TestSceneAutoplay check steps 2022-07-30 10:11:01 +03:00
3bc1774c87 Merge branch 'master' into pie-chart-progress 2022-07-29 16:54:59 +03:00
3b1a76b190 Remove redundant/overwritten specifications 2022-07-29 16:45:29 +03:00
905bbdc8ee Remove caching of GameplayClockContainer in favour of GameplayClock
Also fixes `SongProgress` being displayed in skin editor on non-gameplay
screens, due to `GameplayClock` not marked as a required dependency.
2022-07-29 16:45:29 +03:00
6703b8df02 Merge pull request #19454 from peppy/filter-control-tests-realm-refresh
Ensure realm is in a good state before asserts in `TestSceneFilterControl`
2022-07-29 17:57:38 +09:00
07e3765b34 Ensure collection is added to dropdown before trying to click it 2022-07-29 17:25:30 +09:00
eb92c35335 Merge pull request #19442 from smoogipoo/fix-beginplaying-misordering
Move spectator begin/end playing to SubmittingPlayer
2022-07-29 16:09:50 +09:00
e07e761c10 Ensure realm is in a good state before asserts in TestSceneFilterControl 2022-07-29 15:59:53 +09:00
aaa6f963bd Fix potential test failures due to Setup/SetUpSteps ordering 2022-07-29 15:27:39 +09:00
45879f7836 Merge pull request #19443 from smoogipoo/fix-intermittent-hud-tests
Fix intermittent HUD tests
2022-07-28 23:20:46 +09:00
e664690fe2 Remove unnecessary LoadTrack call 2022-07-28 22:19:46 +09:00
3005ff1b9f Merge branch 'master' into pie-chart-progress 2022-07-28 22:19:27 +09:00
a59d7f6710 Merge branch 'master' into collections-track-beatmap-updates 2022-07-28 22:05:34 +09:00
aa03df905f Merge pull request #19441 from peppy/test-working-beatmap-unfuck
Reduce calls to `LoadTrack` by implicitly running on test/dummy classes
2022-07-28 22:05:25 +09:00
11e0022fad Merge branch 'master' into realm-collections 2022-07-28 21:00:08 +09:00
ce694123eb Move spectator begin/end playing to SubmittingPlayer 2022-07-28 20:44:04 +09:00
7108553883 Tidy up various things everywhere 2022-07-28 18:25:14 +09:00
a21aee4e9c Reduce calls to LoadTrack by implicitly running on test/dummy classes 2022-07-28 18:11:40 +09:00
1039338d80 Fix intermittent HUD tests 2022-07-28 17:58:07 +09:00
1da9830145 Merge pull request #19435 from peppy/remove-beatmap-manager-ruleset-store
Remove unused `RulesetStore` from `BeatmapManager` constructor
2022-07-28 17:46:12 +09:00
6d4023b933 Adjust comment 2022-07-28 16:56:11 +09:00
cd01c5d3ac Fix assertion 2022-07-28 16:34:31 +09:00
0d36907cad apply code quality fixes 2022-07-28 15:30:45 +08:00
70ed347b06 simplify helper methods 2022-07-28 15:19:35 +08:00
2b9d46d803 Remove unused RulesetStore from BeatmapManager constructor 2022-07-28 16:19:05 +09:00
db62d4be3a apply suggestions
- refactor `SongProgress`
- make`UpdateProgress` more readable
- enable NRT on new classes
- refactor `TestSceneSongProgress` to use `GameplayClockContainer`
2022-07-28 15:15:41 +08:00
6bf293e130 Fix managed object reused between test runs 2022-07-28 15:45:33 +09:00
8ac886a247 Update test to account for sort order 2022-07-28 15:20:25 +09:00
67c44552cb Add realm Refresh calls to ensure tests are stable 2022-07-28 15:18:04 +09:00
485d140a21 Add realm refresh calls to fix intermittent test failures on new update tests 2022-07-28 15:15:41 +09:00
2ae5a34c0e Add test coverage of beatmap updates transferring collection hashes 2022-07-28 15:02:58 +09:00
ad482b8afc Tidy up naming of collection dropdowns 2022-07-28 13:57:21 +09:00
34a2d1a6e1 Fix ManageCollectionsDialog and remove weird placeholder logic 2022-07-28 13:57:21 +09:00
67c7f324ee Simplify CollectionFilterDropdown filter flow weirdness 2022-07-28 13:57:21 +09:00
0913cf013c Split out tests and fix variable conflict 2022-07-28 13:24:14 +09:00
aa65b73f19 Merge branch 'master' into add-notif-externalbutton 2022-07-28 12:17:36 +09:00
8da499fb0f Add proper test coverage 2022-07-28 12:16:21 +09:00
9088caa377 move LegacyComboCounter to osu.Game.Skinning 2022-07-28 08:36:26 +08:00
438067a18b Convert realm data propagation to more correctly use Live<T>
wip
2022-07-27 19:35:09 +09:00
41393616d8 Replace BeatmapCollection with RealmBeatmapCollection 2022-07-27 19:35:09 +09:00
9c543fef48 Remove CollectionManager 2022-07-27 18:45:33 +09:00
6af6f03e29 refactor song progress test scene 2022-07-27 15:57:47 +08:00
1e013bd4e9 move song progress graph to its own test scene 2022-07-27 15:57:23 +08:00
494486ad09 Fix potential test failure if scores are added to the beatmap which is subsequently removed 2022-07-27 16:27:10 +09:00
37e642b0bd make SongProgress abstract
- move unrelated logic to `DefaultSongProgress`
- make `LegacySongProgress` inherit `SongProgress`
2022-07-27 15:19:21 +08:00
6b73f7c7ec Split out legacy import path from realm manager 2022-07-27 15:04:09 +09:00
8f7dff5c2c Merge pull request #19378 from peppy/beatmap-update-test
Add separate beatmap update flow to handle edge cases better
2022-07-26 18:49:20 +09:00
6ff44ed2c6 Merge pull request #19399 from frenzibyte/carousel-order-stability
Maintain sort stability by using carousel item ID as a fallback
2022-07-26 17:33:30 +09:00
7f75184a01 Merge branch 'master' into beatmap-update-test 2022-07-26 17:27:36 +09:00