f443cfb93e
Move blueprint validity conditions to allow more correct external usage of EndPlacement
...
Until now, these were haphazardly enforce inline in blueprint
implementations. The only thing stopping complete breakage is that
`EndPlacement` wasn't called (too much) from outside the blueprint,
leaving them responsible for their own placement.
By moving this conditional out of the provided paramters to
`EndPlacement`, it allows more flexible usage of that method externally.
Coming in a future PR.
2023-05-12 16:02:22 +09:00
efc4df95eb
Merge pull request #23429 from peppy/fix-incorrect-mania-description-keys
...
Fix incorrect special style description text
2023-05-09 07:04:57 +02:00
0a47ffcbdd
Match generally used casing
...
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com >
2023-05-09 07:03:13 +02:00
1ff1730948
Remove no-longer-correct remark
2023-05-08 22:35:41 +02:00
3f45948664
Merge branch 'master' into fix-mania-head-note-animation
2023-05-08 22:23:01 +02:00
27c10cbdb7
Remove clamping of sizingContainer in DrawableHoldNote to fix head note alignment
2023-05-08 18:14:07 +09:00
814f0b3fed
Add back early return in OnReleased for safety
2023-05-08 15:43:11 +09:00
85d0c56cd2
Fix incorrect special style description text
...
Closes https://github.com/ppy/osu/issues/23428 .
2023-05-08 13:00:45 +09:00
6a59ded1ba
Move logic to Update instead
2023-05-03 15:18:37 +09:00
4013cdcfa8
Merge branch 'master' into mania-fix-hold-note-rewind
2023-05-03 15:04:59 +09:00
e7a478ce9c
Update convert-samples-expected-conversion.json
2023-04-30 16:04:03 +02:00
d97daee96b
remove all non-test usage of SampleControlPoint
2023-04-26 13:55:39 +02:00
39d9f0c3f5
removing using
2023-04-26 13:22:13 +02:00
6c70948681
Remove IContext & add IHasGenerateTicks
2023-04-26 13:10:57 +02:00
e4b64bdc3e
clean up code stuff
2023-04-25 19:06:29 +02:00
ea1e6e9798
Add LegacyContext
2023-04-25 12:12:46 +02:00
a4c6850ab2
made the SampleControlPoint and DifficultyControlPoint obsolete
2023-04-25 11:34:09 +02:00
ad51f880e0
Remove overrides on DC/NC mods
2023-04-10 17:49:29 +09:00
15f6bc155e
Add progressive score multiplier for HT
2023-04-10 13:35:48 +09:00
c923482976
Add progressive score multiplier for DT
2023-04-10 13:31:48 +09:00
2b525b626c
Revert to previous conditional style
2023-03-28 06:22:00 +02:00
c54934cb45
Fix hit lighting misalignment on argon skin with upscroll
2023-03-27 18:15:01 +02:00
b5e04791e9
Merge branch 'master' into mania-shadow-icon-changes
2023-03-20 19:33:52 +01:00
fe91f85f6f
Reuse colour constants in fallback path
2023-03-20 18:16:33 +01:00
d87f0557ce
Update colours for 3k to not use double-purples
2023-03-15 17:18:45 +09:00
5aebbac6c5
Fix osu!mania hold note animations not correctly re-applying after rewind
...
There's early exit logic in `OnPressed`/`OnReleased` for the sake of
keeping order correct, but this doesn't account for the fact that
`DrawableHitObject` resets all animations when the hit state changes.
A bit of an ugly workaround, but seems to work as expected.
2023-03-14 18:15:19 +09:00
f40a4b591f
Adjust animation length and colouring of hitting layer
2023-03-14 18:14:29 +09:00
300d81c46b
Add hitting layer to fix hit lighting not being applied to tail piece
...
Taken from https://github.com/ppy/osu/pull/22820#issuecomment-1462626898 .
2023-03-14 17:29:19 +09:00
6b2a70b112
Remove unused fields
2023-03-09 19:14:08 +01:00
08b88ed639
Adjust hold note head icon to be more centered
2023-03-09 20:46:24 +09:00
e12ab165b8
Adjust colours a bit to make hold note bodies more accented
2023-03-09 20:46:24 +09:00
2ad531f263
Adjust argon note shadows and body to be closer in line with new design proposal
2023-03-09 20:27:58 +09:00
526eeedec2
Adjust explosion and hit target to not include shadow portion in height calculation
2023-03-09 20:27:43 +09:00
ed3ff62e4f
Add note about why bodyPiece sizing is done as it is
...
I think we're going to have to change this as it's quite limiting in
what you can do with osu!mania skin implementation, but for now I want
to leave a note as to why this is done, because each time I have to
trial and error check what breaks when adjusting it.
2023-03-09 20:26:49 +09:00
bfc0b946fb
Remove additive blending from argon body piece
2023-03-09 20:26:35 +09:00
030742c648
Use different icon style on hold note heads
2023-03-09 19:02:45 +09:00
e246784867
Fix dual stage column colours not being looked up correctly
2023-03-09 18:25:30 +09:00
b8e87e3a08
Update osu!mania argon colours to match new proposal
2023-03-08 20:03:06 +09:00
36058b3da2
Fix upwards scroll direction not working with recent hold note display changes
2023-03-03 18:03:06 +09:00
da8ab7143b
Merge branch 'master' into maximum-judgement-offset-in-hit-object
2023-02-15 14:48:15 +09:00
bd8c58dc62
Adjust applied body ratio to ROUGHLY match stable
2023-02-14 14:34:12 +09:00
b1d2a433f8
Apply second attempt at fixing long note bodies
2023-02-10 20:36:58 +09:00
5091c50003
Change scroll direction logic to not interfere with scale
2023-02-10 19:18:17 +09:00
61c968d7f8
Revert completely incorrect change
2023-02-10 19:18:00 +09:00
c691a0d3af
Merge branch 'master' into sheared_slider_implementation_clean_ii
2023-02-06 17:49:33 +09:00
3f0ce75bf5
Rename NormalSliderBar.cs to RoundedSliderBar.cs
2023-02-02 17:24:45 +01:00
8a39afd293
Merge pull request #22402 from itsMapleLeaf/argon-mania-hold-tail-no-sprite
...
Improve argon osu!mania hold notes visuals and fix reverse scroll direction looking wrong
2023-02-02 14:39:23 +09:00
ccd68a6263
optimize imports
2023-02-01 19:22:28 -06:00
a8ce0a3278
now without the weird hacks
2023-02-01 18:50:38 -06:00
0d6e757baf
Merge branch 'argon-mania-hold-tail-no-sprite' of https://github.com/itsMapleLeaf/osu into argon-mania-hold-tail-no-sprite
2023-01-31 19:53:03 -06:00
