9321ec29dc
Update slider sample source asserts to match expected behaviour
...
As pointed out in review, if the current time is after the end of the
slider, the correct hit object to use for sample retrieval is the object
itself, not any nested object.
2023-02-21 14:04:38 +09:00
e686b4393e
Add wait steps to ensure frame-stable clock has caught up before checking state
2023-02-21 14:04:19 +09:00
5ba6059911
Merge branch 'master' into fix-taiko-drum-nested-sample-detection
2023-02-21 13:58:15 +09:00
3183f5cee2
Merge branch 'master' into revert-result-in-playfield
2023-02-19 16:33:10 +01:00
704dddf14b
Merge branch 'master' into skin-editor-clipboard
2023-02-17 22:59:18 +01:00
6afa65bd3d
Merge branch 'master' into skinnable-clean-up-documentation
2023-02-17 20:59:18 +01:00
ddd6c1a1c6
refactor(KeyCounter): address bindables issues
...
`IsCounting` is back being an auto-property.
`countPresses` is now encapsulated and being exposed as an
`IBindable<int>` via `CountPresses`
2023-02-16 22:20:34 +00:00
3ee046000e
Merge branch 'master' into revert-result-in-playfield
2023-02-16 21:54:29 +01:00
2fdf1fd876
Merge branch 'master' into fix-taiko-drum-nested-sample-detection
2023-02-16 19:43:02 +01:00
5bdc5dfadd
Add one more assert to keep coverage from previous implementation
2023-02-16 19:02:51 +01:00
b59ec551f6
Add test coverage of GameplaySampleTriggerSource
not considering nested objects
2023-02-16 18:21:33 +09:00
979c079f8b
Refactor GameplaySampleTriggerSource
test to not be realtime dependent
2023-02-16 17:58:44 +09:00
9d02a2ef0e
Apply NRT to GamepleSampleTriggerSource
tests
2023-02-16 17:58:44 +09:00
2fbaf88a3c
Add clipboard dependency to SkinEditor
specific tests
...
This is usually provided by the `SkinEditorOverlay`, which is not always
present in tests.
2023-02-16 15:24:38 +09:00
74e7cc2056
feat: implement new design of key counter
2023-02-15 22:18:02 +00:00
076eb81b21
refactor: rename trigger classes
...
Makes it better to understand their purpose
2023-02-15 21:46:13 +00:00
157bba7830
refactor: rename Trigger
class to InputTrigger
2023-02-15 21:41:36 +00:00
a92e42bb84
Rename SkinnableTargetContainer
to SkinComponentsContainer
...
Also use full `SkinComponentsContainerLookup` instead of the sub-type.
This will potentially be useful once we bring in per-ruleset targets.
2023-02-15 18:37:41 +09:00
b1cf6d83d8
Move extension methods closer to serialisation classes
2023-02-15 18:37:41 +09:00
856efd9fd9
Rename SkinnableDrawableInfo
to SerialisedDrawableInfo
2023-02-15 18:23:19 +09:00
9e651a7ca2
Rename SkinnableInfo
to SkinnableDrawableInfo
2023-02-15 18:23:17 +09:00
6010dde86e
Move SkinnableInfo
to better namespace
2023-02-15 18:23:10 +09:00
d9b4d932c9
Fix test container lookup failure
2023-02-15 17:47:34 +09:00
ca75f0ec77
Apply NRT to TestSceneBeatmapSkinFallbacks
2023-02-15 17:30:21 +09:00
8bbd00822c
Simplify and rename SkinnableTargetComponentsContainer
2023-02-15 17:30:21 +09:00
51d4ae5241
Merge branch 'master' into footer_V2_implementation
2023-02-14 14:00:53 +09:00
939144fb6c
Merge pull request #22628 from EVAST9919/letterbox-no-containers
...
Remove unnecessary containers in `LetterboxOverlay`
2023-02-13 23:54:48 +01:00
6e6421caea
Change FooterV2.cs colour to use ColourProvider
instead of OsuColour
.
...
Remove unnecessary `FillFlowContainer`
2023-02-13 22:12:25 +01:00
006356e617
Add TestSceneLetterboxOverlay
2023-02-13 14:17:33 +03:00
11d0e185b8
refactor: separate impl of KeyCounterDisplay
...
This allows for different layouts of display. Idk, maybe someone would
want to mix both variants? (don't do this please). This commit is mostly
prep for further changes.
2023-02-13 01:36:12 +00:00
cb51b9e350
Use existing ModdingBeatmap
activity
2023-02-12 15:01:50 -08:00
bbeef53569
Add TestingBeatmap
activity
2023-02-12 13:11:42 -08:00
afb66d8af4
Make user activity class names more specific
2023-02-12 12:32:17 -08:00
8292052dc2
Merge pull request #22598 from peppy/fix-skip-intro-replay
...
Fix "skip" key binding no longer working in replay playback
2023-02-11 11:27:10 +01:00
0c5dae5f26
Merge pull request #22529 from ItsShamed/dsc/presence
...
Add support for `Watching` and `Spectating` activities in `ReplayPlayer` and `SoloSpectatingPlayer`
2023-02-11 17:29:47 +09:00
96fbd04698
Add failing test coverage of skip no longer working in replay playback
2023-02-10 18:57:04 +09:00
eccde923e5
Merge pull request #22554 from Walavouchey/ranking-accuracycircle-readability
...
Improve readability of `AccuracyCircle`
2023-02-10 17:03:46 +09:00
5ddaf8ea3c
Fix test setting invalid TimeOffset
2023-02-09 17:43:04 +09:00
92eb6b6717
Simplify TestSceneAccuracyCircle
test specifications
2023-02-09 15:42:03 +09:00
3b5d573db1
Display tournament banner on user profile
2023-02-08 17:16:09 -08:00
9544a1d26d
use values closer to the extremities for test cases
2023-02-09 00:02:32 +01:00
6ace6bfee1
ensure AccuracyCircle
doesn't land in gaps created by RankNotch
es
2023-02-08 13:20:53 +01:00
38031fdf23
Add test coverage of stores stored in database as well
2023-02-08 15:38:07 +09:00
d4d985ba0f
Improve test to also check that reverting hash restores old scores
2023-02-08 15:34:46 +09:00
c7eec371f5
Clean up tests somewhat
2023-02-08 15:22:17 +09:00
338d96534a
Add leaderboard test on beatmap update
2023-02-08 05:01:54 +03:00
7e127dafe2
Update reference
2023-02-07 11:52:47 +03:00
cb26601cb4
Fix test's score generation
2023-02-07 02:29:28 +03:00
bc89f8dc5b
feat: add name and rulset verb display support
2023-02-06 12:44:00 +00:00
c691a0d3af
Merge branch 'master' into sheared_slider_implementation_clean_ii
2023-02-06 17:49:33 +09:00