Commit Graph

60254 Commits

Author SHA1 Message Date
5757eb7529 Update a few more instances of 0.96f scale constants 2023-05-03 18:20:12 +09:00
88135a3be8 Merge pull request #23384 from peppy/fix-incorrect-transform-thread
Fix potentially incorrect thread access in `OsuTabControlCheckbox`
2023-05-03 10:37:27 +02:00
ff28d941b3 Merge pull request #23385 from Joehuu/scroll-back-button-block-hover
Fix overlay scroll back button not absorbing hover from behind
2023-05-03 16:28:05 +09:00
de1b28bcb2 Fix incorrect initial state of checkbox
This only ever barely used to work without the `(..., true)`
in `master` because of haphazard operation ordering.
2023-05-03 09:27:23 +02:00
5f781bd6de Move callback to LoadComplete()
Is the more correct place for `BindValueChanged()` callbacks.
2023-05-03 09:26:54 +02:00
29a943d514 Merge pull request #23383 from peppy/fix-multi-freemod-overlays-test-failure
Fix test failure in `MultiplayerMatchSongSelect` due to multiple overlays present
2023-05-03 09:09:41 +02:00
2add8e119f Merge pull request #23379 from peppy/legacy-skin-reverse-arrow-colour-flip
Add support for flipping colour of reverse arrow on legacy default skin when combo colour is too bright
2023-05-03 08:48:32 +02:00
6a59ded1ba Move logic to Update instead 2023-05-03 15:18:37 +09:00
4013cdcfa8 Merge branch 'master' into mania-fix-hold-note-rewind 2023-05-03 15:04:59 +09:00
453143813f Extend input handling of osu! logo to full border area
This is the easiest way to make this happen. It does mean the pink area
is being drawn behind the white border, but I haven't found a scenario
where this is noticeable.

Closes #4217.
2023-05-03 14:57:57 +09:00
1c74f6e8ea Fix regressed button hover fade in 2023-05-02 22:54:42 -07:00
bede1292de Fix overlay scroll back button not absorbing hover from behind 2023-05-02 22:40:37 -07:00
a3efae3690 Fix potentially incorrect thread access in OsuTabControlCheckbox
https://github.com/ppy/osu/actions/runs/4868337922/jobs/8681736829.
2023-05-03 14:33:32 +09:00
384693a431 Fix test failure in MultiplayerMatchSongSelect due to multiple overlays present
https://github.com/ppy/osu/actions/runs/4868337922/jobs/8681736995?pr=23308.
2023-05-03 14:30:58 +09:00
6b017ac05f Merge pull request #23308 from OliBomby/sample-control-points
Remove SampleControlPoint and DifficultyControlPoint from HitObject
2023-05-03 14:21:51 +09:00
f930c4bd0a Move struct to bottom of file 2023-05-03 13:33:31 +09:00
48fd99818e Split out default and sample application 2023-05-03 13:30:45 +09:00
cca15f930c Refactor applyLegacyInfoAndDefaults for legibility 2023-05-03 13:26:50 +09:00
588a4e6196 Move pragma disable to top of LegacyBeatmapDecoder
Makes more sense as it's used multiple times in the class.
2023-05-03 13:19:14 +09:00
16c624fb61 Ensure static banana samples are not mutated 2023-05-03 13:02:37 +09:00
9c4312b407 Add support for flipping colour of reverse arrow on legacy default skin when combo colour is too bright 2023-05-03 12:37:07 +09:00
e394b487e0 Merge branch 'master' into edit-mods-preset 2023-05-03 12:06:16 +09:00
e42b0cc5b1 Merge pull request #23370 from peppy/fix-editor-playfield-padding
Add more padding around playfield in editor to avoid overlap with tool areas
2023-05-03 11:44:55 +09:00
03459a4f19 Merge pull request #23371 from peppy/argon-slider-ball-fade-faster
Increase the rate of slider ball fade on argon skins to match other implementations
2023-05-02 19:03:47 +02:00
95badb9455 Adjust composer tests to new screen layout
`TestSceneHitObjectComposer.TestPlacementFailsWhenClickingButton()` was
attempting to cover the case of the user clicking a toolbox button which
was in front of the playfield, and ensure that the click did not result
in a placement. However, since the paddings in
67f83f246b were added, it is impossible
for a toolbox button to be in front of the playfield in the collapsed
state, which the test was relying on.

The test scenario is still however relevant in the case of the toolbox
being expanded, as in that state the toolbux buttons may very well end
up being in front of the playfield, and they still should not result in
a hitobject being placed. To ensure that this is the case, add a few
extra test steps ensuring that the toolbox is expanded first before
trying to retrieve an overlapping button.
2023-05-02 18:45:45 +02:00
ec8362c6fc Merge pull request #23367 from peppy/fix-uo-tooltip
Fix slider bar tooltips potentially showing negative zero
2023-05-02 18:03:09 +02:00
48dd42407b Merge pull request #23369 from peppy/beatmap-attribute-text-unicode-preference
Fix `BeatmapAttributeText` not supporting unicode artist/title
2023-05-02 17:32:55 +02:00
94ae9d7664 Merge pull request #23357 from OliBomby/fix-reverse-crash
Prevent infinite repeat count when adjusting repeats of 0 length slider
2023-05-02 19:53:26 +09:00
1b565ab9e8 Merge pull request #21789 from mk56-spn/bubble_mod_implementation_clean
Add "bubble" mod to osu! ruleset
2023-05-02 19:52:32 +09:00
2aaa52e904 Merge pull request #23374 from EVAST9919/ruleset-shaders-test
Add missing ruleset shader tests
2023-05-02 19:52:09 +09:00
90d98cd329 remove constructor argument from Banana 2023-05-02 12:41:39 +02:00
d2d81bb82c remove redundant zero check in sv calculation 2023-05-02 12:29:11 +02:00
ba5088f71a Add missing ruleset shader tests 2023-05-02 11:55:05 +03:00
8160d56264 Update test shaders 2023-05-02 11:51:05 +03:00
e44672bdd5 Avoid using Schedule in transforms (doesn't handle rewind well) 2023-05-02 17:08:49 +09:00
7830711c8e Tidy up various code quality issues in OsuModBubbles 2023-05-02 17:08:37 +09:00
fb0e90913d Ensure lifetime start is also updated when reverting judgements 2023-05-02 17:07:12 +09:00
414b80d44e Change flashlight depth in a more standard way 2023-05-02 17:00:54 +09:00
b2b9f2a036 Merge branch 'master' into bubble_mod_implementation_clean 2023-05-02 16:59:55 +09:00
a619812cab Fix nullability and remove extra preempt from SliderEndCircle calculation 2023-05-02 16:36:43 +09:00
1a04be15c7 Fix fade in delay for first slider end circle being incorrect when snaking disabled 2023-05-02 16:27:17 +09:00
e3c51b9652 Add ability to toggle snaking in slider test scene 2023-05-02 16:26:56 +09:00
bd72c67d68 Increase the rate of slider ball fade on argon skins to match other implementations 2023-05-02 15:47:35 +09:00
2e018c8b06 Fix comment 2 osu.Game/Rulesets/Objects/Types/IHasGenerateTicks.cs
Co-authored-by: Dean Herbert <pe@ppy.sh>
2023-05-02 08:41:47 +02:00
c2ad8c2320 Fix comment 1 osu.Game/Rulesets/Objects/Types/IHasGenerateTicks.cs
Co-authored-by: Dean Herbert <pe@ppy.sh>
2023-05-02 08:41:30 +02:00
67f83f246b Add more padding around playfield in editor to avoid overlap with tool areas
Closes #23130.
2023-05-02 15:37:02 +09:00
4a97c2c105 Merge pull request #23038 from cdwcgt/scale-background-dim
Add feature to adjust `ScalingContainer` background dim
2023-05-02 15:36:52 +09:00
ce4a6c38a0 Merge pull request #22950 from Joehuu/fix-initial-playlist-highlight
Fix now playing playlist not highlighting selected item on initial open
2023-05-02 15:36:34 +09:00
8a536c1cdb Fix non-block namespace usage 2023-05-02 15:09:24 +09:00
1e4a628cb1 Merge pull request #23284 from Hy0tic/multiplier-doesnt-update-with-preset-mod
Fix issue where multiplier show wrong value when adjusting speed on preset
2023-05-02 14:59:41 +09:00