53ae24db9b
Merge pull request #12058 from peppy/fix-whitespace-in-ini
...
Fix skin parser not stripping whitespace before parsing
2021-03-18 18:46:28 +09:00
5b0d75ee56
Only trim trailing spaces to avoid breakage in storyboard parsing
2021-03-18 16:30:30 +09:00
bb3c3f302a
Fix skin parser not stripping whitespace before parsing
2021-03-18 15:36:11 +09:00
b3e96c8385
Merge pull request #12043 from bdach/fix-reverse-crash
...
Fix selection box operation hotkeys not registering in change handler
2021-03-18 13:30:33 +09:00
f95ce90c95
Adjust kudosu count formatting
2021-03-17 23:32:08 +01:00
08ffe425f9
Update kudosu description color in line with web
2021-03-17 14:46:23 -07:00
2e63c2ce20
Fix selection box operation hotkeys not registering in change handler
...
Could lead to crashes after reversing a note cluster and playing it
back.
The root cause of the crash was that the hotkey operations were not ran
inside of an editor change handler operation. This, in turn, caused the
autoplay replay to not be regenerated after flipping an object cluster,
therefore finally manifesting as a hard crash due to negative time
offsets appearing in judgement results, which interfered with the
default implementation of note lock.
Note that this incidentally also fixes the fact that selection box
hotkey operations (reverse and flip) did not handle undo/redo.
2021-03-17 22:17:42 +01:00
599c55fca5
Update total kudosu earned description text in line with web
2021-03-17 13:22:00 -07:00
6cea74f0fa
Remove available kudosu section from user profile overlay in line with web
2021-03-17 13:21:41 -07:00
5a7e416495
Merge pull request #12027 from peppy/new-beatmap-empty-fields
...
Don't fill beatmap metadata with template values on creating a new beatmap
2021-03-17 19:36:21 +09:00
d0e61e5b4d
Put back the label
2021-03-17 17:14:04 +09:00
3b6a1180b6
Remove non-accessed field
2021-03-17 17:02:11 +09:00
5adc675862
Focus artist textbox on entering song setup if fields are empty
2021-03-17 16:57:14 +09:00
26d6f96c4e
Fix LabelledTextBox not correctly forwarding focus to its underlying TextBox component
2021-03-17 16:56:58 +09:00
eda891223c
Start the editor with empty artist/creator/difficulty name fields
2021-03-17 16:47:12 +09:00
c7740d1181
Fix opening the editor occasionally causing a hard crash due to incorrect threading logic
...
Setting one of the global screen `Bindable`s (in this case, `Beatmap`)
is not valid from anywhere but the update thread. This changes the order
in which things happen during the editor startup process to ensure
correctness.
Closes #11968 .
2021-03-17 15:52:25 +09:00
b495504cae
Merge branch 'master' into fix-mouse-disable-default-indicator
2021-03-16 10:58:56 +09:00
da3dc61aae
Remove newline
2021-03-16 10:58:42 +09:00
393f1fbd3f
Remove skype
2021-03-15 10:07:50 -07:00
f3faad74d5
Merge pull request #12003 from UselessToucan/ef_core_5
2021-03-15 15:05:32 +09:00
3dd72d6f7d
Fix disable mouse buttons setting not showing default indicator when using keybind
2021-03-14 22:47:05 -07:00
1e519f0d31
Fix seemingly innocent logic change causing breakage in score imports
2021-03-15 14:20:59 +09:00
6d4c1ba2ae
Fix a couple of new inspections introduced in Rider EAPs
2021-03-15 13:35:08 +09:00
fce21f23d6
Add comments marking workarounds required for EFcore 5
2021-03-15 13:29:26 +09:00
2904f479c6
Share file lookup workaround in ArchiveModelManager with workaround extensions class
2021-03-15 13:26:14 +09:00
79d3379f55
Reformat application of configuration
2021-03-15 13:20:22 +09:00
8a35533889
Add fall-through case to catch a potential requery for unsupported model type
2021-03-15 13:11:58 +09:00
2bdffd1004
Move skin requery logic into extension methods
2021-03-15 13:11:58 +09:00
900da7b891
Rename and refactor extenion methods to be easier to read
2021-03-15 13:11:58 +09:00
28ef64b62a
Explicitly specify SingleQuery behavior
2021-03-14 21:43:27 +03:00
0a1e325fc7
Extract requerying of navigational properties from DbContext
2021-03-14 19:34:53 +03:00
6438a7ee12
Merge branch 'master' into user-hide-toolbar-forever
2021-03-13 17:31:37 +01:00
a227b0a581
Build on xmldoc with rationale
2021-03-13 23:29:47 +09:00
e70ba2d005
Remove unnecessary second variable
2021-03-13 23:29:01 +09:00
4afbccfcff
Fix initial operation potentially running before DI is completed
2021-03-13 19:30:40 +09:00
b13f193c8d
Fix incorrect task being returned for changelog continuations
2021-03-13 19:26:38 +09:00
0ba5312a40
Move blocking show logic to UpdateState
2021-03-13 00:05:26 -08:00
5999e4ba33
Add xmldoc for hiddenbyuser bool
2021-03-12 20:18:32 -08:00
62f2a823f6
Hide toolbar forever when the user hides it
2021-03-12 15:48:50 -08:00
6c0734a09f
Handle global action in toolbar instead of osugame
2021-03-12 15:48:49 -08:00
e7707eee94
Switch RestoreDefaultsValueButton to use HasPendingTasks to avoid tooltip always showing
2021-03-12 15:23:11 +09:00
a60ff80c04
Use expression body in ModsJson get accessor
2021-03-12 00:02:29 +03:00
5a4b0174b1
Ignore MultipleCollectionIncludeWarning
2021-03-11 22:40:35 +03:00
d2f943395d
Hotfix importing scores from stable
2021-03-11 22:12:47 +03:00
c6c616f244
Actualize tests
2021-03-11 21:02:40 +03:00
47b80d2474
Workaround InvalidOperation exceptions
2021-03-11 20:51:54 +03:00
f1302d1600
Update Microsoft.EntityFrameworkCore
2021-03-11 19:23:56 +03:00
023af75cc3
Merge branch 'master' into fix-storyboard-alpha-start-time-woes
2021-03-11 22:09:56 +09:00
efb4a366d4
Fix xmldoc explaining incorrect behaviour
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com >
2021-03-11 12:15:59 +09:00
8aaba32431
Fix storyboard commands occurring before the earliest point of visibility delaying gameplay
...
In osu-stable, storyboard intros start from the first command, but in
the case of storyboard drawables which have an initial hidden state, all
commands before the time at which they become visible (ie. the first
command where `Alpha` increases to a non-zero value) are ignored.
This brings lazer in line with that behaviour. It also removes several
unnecessary LINQ calls.
Note that the alpha check being done in its own pass is important, as
it must be the "minimum present alpha across all command groups,
including loops". This is what makes the implementation slightly
complex.
Closes #11981 .
2021-03-09 15:55:12 +09:00
