dde9fd28e6
Hide ShowMore button if there's nothing to load
2021-05-09 04:57:24 +03:00
0e91e6a155
Merge pull request #12724 from bdach/remove-current-from-legacyscorecounter
...
Remove vestigial `Current` reimplementation from `LegacyScoreCounter`
2021-05-09 05:01:53 +09:00
ea066cddc9
Merge pull request #12722 from bdach/fix-beatmap-listing-temporary-files
...
Fix temporary files from beatmap downloads not being cleaned up
2021-05-09 04:51:48 +09:00
c3bf6a0287
Remove weird vestigial Current reimplementation
...
Has no functional purpose anymore since the changes in the HUD element
data binding flow.
2021-05-08 21:01:37 +02:00
dec5400c0a
Merge branch 'master' into skin-components-bind-outwards-score-display
2021-05-08 19:58:19 +02:00
9e0ea494fd
Merge branch 'master' into skin-components-bind-outwards
2021-05-08 19:04:56 +02:00
fe86ee629e
Fix temp files from beatmap listing imports not being cleaned up
...
As reported in #12718 , it turns out that temporary files from beatmap
set downloads performed via the beatmap listing overlay could remain in
the user's filesystem even after the download has concluded.
The reason for the issue is a failure in component integration.
In the case of online downloads, files are first downloaded to a
temporary directory (`C:/Temp` or `/tmp`), with a randomly generated
filename, which ends in an extension of `.tmp`.
On the other side, `ArchiveModelManager`s have a `ShouldDeleteArchive()`
method, which determines whether a file should be deleted after
importing. At the time of writing, in the case of beatmap imports the
file is only automatically cleaned up if the extension of the file is
equal to `.osz`, which was not the case for temporary files.
As it turns out, `APIDownloadRequest` has a facility for adjusting the
file's extension, via the protected `FileExtension` property. Therefore,
use it in the case of `DownloadBeatmapSetRequest` to specify `.osz`,
which then will make sure that the `ShouldDeleteArchive()` check in
`BeatmapManager` picks it up for clean-up.
2021-05-08 17:09:14 +02:00
495eb04e2f
Merge pull request #12488 from Denrage/add-missing-author-links
...
Add missing author links in Beatmap Details
2021-05-08 05:41:40 +09:00
5b2f786f97
Update framework
2021-05-07 19:16:00 +09:00
01eff7f316
Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-score-display
2021-05-07 16:30:08 +09:00
17b93361d5
Merge branch 'master' into skin-components-bind-outwards
2021-05-07 16:20:24 +09:00
a2e4fb5b6b
Update ScoreCounter components to bind outwards
2021-05-07 16:16:48 +09:00
fc2a527e9d
Revert "Guard against potentially null track if ever"
...
This reverts commit b1134c3857
2021-05-07 09:57:08 +03:00
7c4e54a1d4
Unrevert null-colaescing/conditionals removal
2021-05-07 09:54:14 +03:00
165f443ab5
Merge branch 'master' into add-missing-author-links
2021-05-07 14:32:44 +09:00
b1134c3857
Guard against potentially null track if ever
2021-05-07 08:30:50 +03:00
37f44d2e37
Revert wrong not-null track changes
...
This reverts commit f9d99a988271547bece0
2021-05-07 08:28:44 +03:00
71547bece0
Remove any null-coalescing/conditionals in WorkingBeatmap.Track usages
2021-05-07 07:46:23 +03:00
f9d99a9882
Mark WorkingBeatmap.Track as not null
2021-05-07 07:25:14 +03:00
539643c72b
Set loadable beatmap track to clock immediately in BDL
...
This reverts commit 84da247002
2021-05-07 07:21:56 +03:00
84da247002
Fix editor clock using the wrong beatmap track on creation
2021-05-07 05:32:55 +03:00
fc04b88e1a
Merge pull request #12697 from peppy/update-framework
...
Update framework
2021-05-06 17:46:08 +09:00
af75c9ac82
Update framework
2021-05-06 16:08:28 +09:00
ee23124bb1
Remove no-longer-used interface
2021-05-06 15:18:06 +09:00
d4658c609b
Fix warning text of bg source setting not being updated when user with supporter signs in/out
2021-05-05 22:54:35 -07:00
3cac837acf
Merge branch 'master' into skin-bindables
2021-05-05 20:16:27 +02:00
cb8bda2248
Merge pull request #12503 from Denrage/split-BufferedWedgeInfo
2021-05-06 03:16:16 +09:00
cffeb8641f
Make setters private for protected containers
2021-05-06 02:14:57 +09:00
fe9ade6754
Rename Container to DisplayedContent
2021-05-06 02:14:04 +09:00
b6b9a69601
Removed unnecessary class for wrapping
2021-05-05 18:50:49 +02:00
bb385f4255
Reverted difficulty and mod updates
2021-05-05 18:15:59 +02:00
2797507758
Reorganized elements for readability
2021-05-05 17:56:07 +02:00
88506a51dd
reduced complexity
2021-05-05 17:51:29 +02:00
5049e2fbf9
Refactored out changes in DifficultyColourBar
2021-05-05 15:28:33 +02:00
ed1ae4775f
Merge pull request #12432 from marlinabowring/play-storyboard-outro
...
Add support for playing storyboards beyond gameplay end time
2021-05-05 22:21:25 +09:00
4ef901d08d
Remove unnecessary redirection property to Container.Info
2021-05-05 21:07:49 +09:00
cf6ed7a7cf
Refactored out changes in StarRatingDisplay
2021-05-05 13:13:37 +02:00
a2ad079b8a
Merge pull request #12675 from Joehuu/settings-item-notes
2021-05-05 18:11:16 +09:00
377af38d94
Remove unnecessary pixelSnapping parameter
...
This was only required because there was text being rendered to the
`BufferedContainer` content until now. Removing this should allow for
better resolution in the background display (due to using a better
minify scale mode).
2021-05-05 17:59:51 +09:00
805ef621e9
Merge branch 'master' into play-storyboard-outro
2021-05-05 17:51:16 +09:00
9ec3255c50
Fix SkipOverlay's FadeContent not getting correct state from parent
2021-05-05 17:50:25 +09:00
08a45e9fc2
Remove dead code
2021-05-05 16:26:41 +09:00
19ffcd00c2
Initialise warning text flow lazily as most items will not use it
2021-05-05 16:26:41 +09:00
1288f69fad
Rename to WarningText
2021-05-05 16:16:49 +09:00
6178f38c95
Reword unlimited frame rate warning a bit
2021-05-05 16:15:06 +09:00
62fa638515
Merge pull request #12665 from frenzibyte/stable-frame-sort
2021-05-05 14:35:25 +09:00
1472960319
Hide and disable skip outro overlay on rewind
2021-05-04 21:35:36 -04:00
23b9d8c260
Fix alpha not being zero when string is set to empty and use inequality on supporter condition
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com >
2021-05-04 14:02:12 -07:00
4185053120
Merge branch 'master' into fix-selection-handler-visibility
2021-05-04 20:21:05 +02:00
a584213002
Use vertical padding instead of relative height for default button
2021-05-04 09:32:38 -07:00
