Commit Graph

29109 Commits

Author SHA1 Message Date
f0caa10066 Add support for a provided cancellation token for GetPlayableBeatmap() 2021-11-05 23:53:48 +01:00
6c385ccd29 Move second generic to abstract model downloader rather than interface type 2021-11-05 17:37:05 +09:00
99df37f32d Add input generic type to IModelDownloader 2021-11-05 17:02:45 +09:00
1fe9bca819 Change ModelDownloader's requirement to an IModelImporter rather than IModelManager 2021-11-05 16:47:18 +09:00
b90f44493c Remove importer inheritance from IModelManager
Now only exists in legacy implementations, to reduce inheritance
complexity of interfaces which are going to be used going forwards.
2021-11-05 16:45:38 +09:00
9f9ef570ee Also propagate Status in temporary BeatmapInfo usage 2021-11-05 14:44:58 +09:00
9e2c33d908 Merge branch 'master' into beatmap-refactor/to-model-removal-2 2021-11-05 13:16:32 +09:00
9b5ed791b5 Merge pull request #15459 from peppy/beatmap-refactor/remove-online-info
Remove `IOnlineInfo` implementations from database models
2021-11-05 13:16:21 +09:00
5721f1b2f3 Merge pull request #15479 from jaswon/skinnable-diagonal-scale
Fix scaling of skin components being too sensitive after rotation
2021-11-05 13:11:11 +09:00
acb06d4a99 Merge branch 'master' into beatmap-refactor/remove-online-info 2021-11-05 12:46:02 +09:00
9e7d559f55 fix aspect locked scaling of skin components 2021-11-04 17:10:41 -04:00
4c8d6a77be Fix labelled drawable descriptions not showing 2021-11-04 21:44:08 +01:00
630d63101d Merge branch 'master' into beatmap-refactor/to-model-removal-2 2021-11-05 01:16:42 +09:00
7049d0de66 Merge branch 'master' into beatmap-refactor/remove-online-info 2021-11-05 01:16:11 +09:00
aa2711e6ec Merge branch 'master' into update-framework 2021-11-04 13:51:57 +03:00
28e9b9a25f Update framework 2021-11-04 19:01:39 +09:00
45dcf187b9 Merge branch 'master' into beatmap-refactor/playlist-use-api-beatmap-extended 2021-11-04 18:59:04 +09:00
df3c3a32ce Fix unintentionally broken background update logic 2021-11-04 18:07:39 +09:00
b80c02b757 Fix crash on gameplay startup if beatmap has no background 2021-11-04 17:24:40 +09:00
eb17d897a3 Finally, remove the To* methods as they have no usages 2021-11-04 17:09:53 +09:00
08d94f864f Update ScoresContainer to not use ToBeatmapInfo 2021-11-04 17:09:53 +09:00
7bab487621 Remove usage of ToBeatmapInfo in APIScoreInfo.CreateScoreInfo 2021-11-04 17:09:53 +09:00
d2831b1152 Merge branch 'beatmap-refactor/remove-online-info' into beatmap-refactor/to-model-removal-2 2021-11-04 17:09:50 +09:00
5a078da4d9 Fix APIBeatmapSet.Beatmaps being IEnumerable, causing stupid issues 2021-11-04 16:50:14 +09:00
c820d445ad Merge pull request #15461 from peppy/fix-more-computationally-expensive
Fix a few more "maybe null" inspections
2021-11-04 16:49:38 +09:00
8f459e6ce8 Fix APIBeatmapSet.Beatmaps being IEnumerable, causing stupid issues 2021-11-04 16:44:17 +09:00
317506d4d7 Fix a few more "maybe null" inspections 2021-11-04 16:11:23 +09:00
09701d0af1 Use explicit primitive type specification 2021-11-04 16:02:37 +09:00
0f4f1349db Merge branch 'master' into editor-context-menu-on-select 2021-11-04 15:59:06 +09:00
a5a7181915 Fix unintentionally broken background update logic 2021-11-04 15:35:32 +09:00
4b1b92cde6 Stop BeatmapInfo from implementing IBeatmapOnlineInfo and remove all usages 2021-11-04 15:23:04 +09:00
9c926e5514 Remove BeatmapSetInfo.OnlineInfo and all usages 2021-11-04 15:23:04 +09:00
66f4516eee Allow creating sample API models without specifying a ruleset 2021-11-04 15:23:04 +09:00
e3a9fbecfe Add method to create sample APIBeatmap (with BeatmapSet populated) 2021-11-04 15:23:04 +09:00
0d0eab90bc Merge branch 'beatmap-refactor/playlist-use-api-beatmap-extended' into beatmap-refactor/remove-online-info 2021-11-04 15:23:02 +09:00
84d36cbae7 Add fallback for cases where BeatmapSet may be null
Seems to only happen in tests, but better safe than sorry.
2021-11-04 15:22:33 +09:00
e43d91ad5d Fix another case of incorrect null checking in editor verification processing 2021-11-04 15:18:10 +09:00
d1e6d1cb98 Update some other missed incorrect null/empty usages 2021-11-04 14:50:43 +09:00
a49366ff84 Remove nullability from IBeatmapInfo.Metadata 2021-11-04 14:28:39 +09:00
1e73b09e57 Fix another couple of cases of incorrect string null/empty checking 2021-11-04 14:22:28 +09:00
41854f2e16 Fix incorrect check on AudioFile presence 2021-11-04 14:02:09 +09:00
67d9590a79 Fix new inspections 2021-11-04 14:02:09 +09:00
0df339d0b8 Fix incorrect invocation of download method in SoloSpectator 2021-11-04 13:50:04 +09:00
0ab50f1cc9 Add inline comment explaining why we are manually populating beatmap.BeatmapSet 2021-11-04 13:45:59 +09:00
9f9c960fe3 Revert PlaylistItem.APIBeatmap to be private 2021-11-04 13:36:32 +09:00
05f1fd4bc9 Remove unnecessary properties and parameters 2021-11-04 13:33:54 +09:00
3453160a8b Change PlaylistItem.Beatmap to be an IBeatmapInfo 2021-11-04 13:16:56 +09:00
772b6c6dcd Enable nullable support on BeatmapMetadata 2021-11-04 12:11:42 +09:00
6fdeb66dc1 Use APIBeatmap instead of BeatmapInfo in playlist display classes where feasible 2021-11-04 11:55:50 +09:00
1d8e253112 Expose PlaylistItem.APIBeatmap for now 2021-11-04 11:53:26 +09:00